From: Rob Herring <robh@kernel.org>
To: Isaac True <isaac.true@canonical.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
wim@linux-watchdog.org, linux@roeck-us.net
Subject: Re: [PATCH 2/2] watchdog: gpio: add configurable minimum interval
Date: Fri, 1 Jul 2022 11:18:29 -0600 [thread overview]
Message-ID: <20220701171829.GA1149706-robh@kernel.org> (raw)
In-Reply-To: <20220629110626.2158127-2-isaac.true@canonical.com>
On Wed, Jun 29, 2022 at 01:06:26PM +0200, Isaac True wrote:
> Add the "min_hw_margin_ms" parameter to gpio_wdt devices, allowing a
> minimum interval to be specified, stopping watchdog devices from being
> fed too quickly if they require a certain interval between feeds.
I assume there is some real platform with a real problem you are trying
to solve? Details please.
Can you just hardcode some min? Maybe 10% of the max or something. Is
there a downside to a larger than necessary min?
Wouldn't be better to fix this without requiring a DT change and that
could work on stable kernels if needed.
Rob
next prev parent reply other threads:[~2022-07-01 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 11:06 [PATCH 1/2] dt-bindings: watchdog: gpio: add minimum interval Isaac True
2022-06-29 11:06 ` [PATCH 2/2] watchdog: gpio: add configurable " Isaac True
2022-07-01 17:18 ` Rob Herring [this message]
2022-07-01 17:48 ` Guenter Roeck
2022-07-04 11:05 ` Isaac True
2022-07-05 19:56 ` Rob Herring
2022-07-07 9:00 ` Isaac True
2022-07-08 11:44 ` Guenter Roeck
2022-07-12 21:04 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701171829.GA1149706-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=isaac.true@canonical.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.