From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A893EC433EF for ; Fri, 1 Jul 2022 23:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbiGAXCr (ORCPT ); Fri, 1 Jul 2022 19:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbiGAXCp (ORCPT ); Fri, 1 Jul 2022 19:02:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B118A7125C for ; Fri, 1 Jul 2022 16:02:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 71A8BB8323C for ; Fri, 1 Jul 2022 23:02:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D027C341C8; Fri, 1 Jul 2022 23:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656716562; bh=0BQiZ/cySDJim1WBEIbdKcr5s5T2CLdQuxXq9UwkD+Q=; h=Date:To:From:Subject:From; b=laVnn3w2aTIw93wDrky8ZApgn2rXTRMItM5724yU2VCEFRp4nxDUtA72LqeCoUFH7 P8emAtEwHM74hkWYlrBPlolRZvlyrboT8uJg6cBPzUewerA5GdCcOd726BkyDJcyaK x8YyQ+t6pe6wkRtg/l9dcfEx9CpgV9NlSBwu710M= Date: Fri, 01 Jul 2022 16:02:41 -0700 To: mm-commits@vger.kernel.org, jgg@nvidia.com, glider@google.com, elver@google.com, dvyukov@google.com, linus.walleij@linaro.org, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-kfence-pass-a-pointer-to-virt_to_page.patch added to mm-unstable branch Message-Id: <20220701230242.0D027C341C8@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm: kfence: pass a pointer to virt_to_page() has been added to the -mm mm-unstable branch. Its filename is mm-kfence-pass-a-pointer-to-virt_to_page.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-kfence-pass-a-pointer-to-virt_to_page.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Linus Walleij Subject: mm: kfence: pass a pointer to virt_to_page() Date: Thu, 30 Jun 2022 10:41:22 +0200 Functions that work on a pointer to virtual memory such as virt_to_pfn() and users of that function such as virt_to_page() are supposed to pass a pointer to virtual memory, ideally a (void *) or other pointer. However since many architectures implement virt_to_pfn() as a macro, this function becomes polymorphic and accepts both a (unsigned long) and a (void *). If we instead implement a proper virt_to_pfn(void *addr) function the following happens (occurred on arch/arm): mm/kfence/core.c:558:30: warning: passing argument 1 of 'virt_to_pfn' makes pointer from integer without a cast [-Wint-conversion] In one case we can refer to __kfence_pool directly (and that is a proper (char *) pointer) and in the other call site we use an explicit cast. Link: https://lkml.kernel.org/r/20220630084124.691207-4-linus.walleij@linaro.org Signed-off-by: Linus Walleij Reviewed-by: Marco Elver Cc: Alexander Potapenko Cc: Dmitry Vyukov Cc: Jason Gunthorpe Signed-off-by: Andrew Morton --- mm/kfence/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/kfence/core.c~mm-kfence-pass-a-pointer-to-virt_to_page +++ a/mm/kfence/core.c @@ -546,7 +546,7 @@ static unsigned long kfence_init_pool(vo if (!arch_kfence_init_pool()) return addr; - pages = virt_to_page(addr); + pages = virt_to_page(__kfence_pool); /* * Set up object pages: they must have PG_slab set, to avoid freeing @@ -660,7 +660,7 @@ static bool kfence_init_pool_late(void) /* Same as above. */ free_size = KFENCE_POOL_SIZE - (addr - (unsigned long)__kfence_pool); #ifdef CONFIG_CONTIG_ALLOC - free_contig_range(page_to_pfn(virt_to_page(addr)), free_size / PAGE_SIZE); + free_contig_range(page_to_pfn(virt_to_page((void *)addr)), free_size / PAGE_SIZE); #else free_pages_exact((void *)addr, free_size); #endif _ Patches currently in -mm which might be from linus.walleij@linaro.org are lib-test_free_pagesc-pass-a-pointer-to-virt_to_page.patch mm-highmem-pass-a-pointer-to-virt_to_page.patch mm-kfence-pass-a-pointer-to-virt_to_page.patch mm-gup-pass-a-pointer-to-virt_to_page.patch mm-nommu-pass-a-pointer-to-virt_to_page.patch