From: Stefano Brivio <sbrivio@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_set_pipapo: release elements in clone from abort path
Date: Sat, 2 Jul 2022 07:05:09 +0200 [thread overview]
Message-ID: <20220702070509.25802501@elisabeth> (raw)
In-Reply-To: <Yr+rQ3pKsQBjJAep@salvia>
On Sat, 2 Jul 2022 04:19:47 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sat, Jul 02, 2022 at 12:39:28AM +0200, Stefano Brivio wrote:
> [...]
> > Other than that, it looks good to me.
> >
> > I would also specify in the commit message that we additionally look
> > for elements pointers in the cloned matching data if priv->dirty is
> > set, because that means that cloned data might point to additional
> > elements we didn't commit to the working copy yet (such as the abort
> > path case, but perhaps not limited to it).
>
> This v2, I forgot to tag it properly:
>
> https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220702021631.796822-2-pablo@netfilter.org/
>
> it is updating documentation and it also adds a paragraph to the
> commit description as you suggested.
Thanks!
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2022-07-02 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 16:45 [PATCH nf] netfilter: nft_set_pipapo: release elements in clone from abort path Pablo Neira Ayuso
2022-07-01 22:39 ` Stefano Brivio
2022-07-02 2:19 ` Pablo Neira Ayuso
2022-07-02 5:05 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220702070509.25802501@elisabeth \
--to=sbrivio@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.