From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3EAC43334 for ; Mon, 4 Jul 2022 10:21:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234153AbiGDKV5 (ORCPT ); Mon, 4 Jul 2022 06:21:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234070AbiGDKVj (ORCPT ); Mon, 4 Jul 2022 06:21:39 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0345712627; Mon, 4 Jul 2022 03:19:23 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B22D220000D; Mon, 4 Jul 2022 10:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656929962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mh0Nhj24sgh2TKJWV5KlgEWJWx+38u9hSCW1uBlX7mk=; b=c4hXa5HR+Jt9+TXulYqwL+pt7blwXoqaHyaPXuNvYUy/wvL4oJYhMDvQc/GO5Uwcf9oOzA 54gpSsZOHX/xLbkTJ9TlnCeKJh+es6u3/Z8+U+0JZY42Qde/wf0csfbCYUswTVLnrzmmdJ 4CkKsOD+iqUbHNzDAYyzopRfC79cn4Ha9lrRbTAhX4gK7eI6E65LlofptOgrCZvr0K4KpY s0kgncOCXnnv1r2XrQeQPeQumKfYIfUvWkloGK0F6khaC+HlYtmez3HXBife0Td7ZJla1x IFrWR5f9V6f4jaeFe9K5daB7Oxbt5Uch58VWKjWLHRVIPTwIsTRLaJm+2ctxew== Date: Mon, 4 Jul 2022 12:19:16 +0200 From: Herve Codina To: Cc: , , , , , , , , , , , , , Subject: Re: [PATCH v4 3/3] ARM: dts: lan966x: Add UDPHS support Message-ID: <20220704121916.3156f644@bootlin.com> In-Reply-To: <32790e6f-e708-ceee-e17f-1b09c909c991@microchip.com> References: <20220701070928.459135-1-herve.codina@bootlin.com> <20220701070928.459135-4-herve.codina@bootlin.com> <72a1e572-45d7-de18-8f1f-9035d75b562b@microchip.com> <20220701160327.102880e5@bootlin.com> <32790e6f-e708-ceee-e17f-1b09c909c991@microchip.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Claudiu, On Mon, 4 Jul 2022 05:41:33 +0000 wrote: > On 01.07.2022 17:03, Herve Codina wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know = the content is safe > >=20 > > Hi Claudiu, > >=20 > > On Fri, 1 Jul 2022 10:56:46 +0000 > > wrote: > > =20 > >> On 01.07.2022 10:09, Herve Codina wrote: =20 > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you kno= w the content is safe > >>> > >>> Add UDPHS (the USB High Speed Device Port controller) support. > >>> > >>> The both lan966x SOCs (LAN9662 and LAN9668) have the same UDPHS > >>> IP. This IP is also the same as the one present in the SAMA5D3 > >>> SOC. > >>> > >>> Signed-off-by: Herve Codina > >>> --- > >>> arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++ > >>> 1 file changed, 11 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan96= 6x.dtsi > >>> index 3cb02fffe716..c98e7075c2b4 100644 > >>> --- a/arch/arm/boot/dts/lan966x.dtsi > >>> +++ b/arch/arm/boot/dts/lan966x.dtsi > >>> @@ -458,6 +458,17 @@ cpu_ctrl: syscon@e00c0000 { > >>> reg =3D <0xe00c0000 0x350>; > >>> }; > >>> > >>> + udc: usb@e0808000 { > >>> + compatible =3D "microchip,lan9662-udc", > >>> + "atmel,sama5d3-udc"; > >>> + reg =3D <0x00200000 0x80000>, > >>> + <0xe0808000 0x400>; > >>> + interrupts =3D ; > >>> + clocks =3D <&clks GCK_GATE_UDPHS>, <&nic_clk>; > >>> + clock-names =3D "pclk", "hclk"; > >>> + status =3D "disabled"; > >>> + }; > >>> + =20 > >> > >> I have these compilation warnings: > >> > >> DTC arch/arm/boot/dts/lan966x-pcb8291.dtb > >> arch/arm/boot/dts/lan966x.dtsi:461.21-470.5: Warning (simple_bus_reg): > >> /soc/usb@e0808000: simple-bus unit address format error, expected "200= 000" > >> DTC arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > >> arch/arm/boot/dts/lan966x.dtsi:461.21-470.5: Warning (simple_bus_reg): > >> /soc/usb@e0808000: simple-bus unit address format error, expected "200= 000" > >> DTC arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > >> arch/arm/boot/dts/lan966x.dtsi:461.21-470.5: Warning (simple_bus_reg): > >> /soc/usb@e0808000: simple-bus unit address format error, expected "200= 000" =20 > >=20 > > I am a bit confused but these warnings do not appear on my side (patches > > based on v5.19-rc1). > > What is the exact command that leads to these warning ? =20 >=20 > Oh, and the set of commands I'm using: > make sama7_defconfig > make menuconfig + enable CONFIG_SOC_LAN966 > make W=3D1 dtbs I have the warnings. They are present with 'W=3D1' set. I remove them and send a v5. Thanks, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D75FFC433EF for ; Mon, 4 Jul 2022 10:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Me1IC4tCTG+04kHr1NdbLjCwGpElcIAexooGw0bXFCg=; b=Mmf65YO8zIhj/x lavTljMxVEtTM2NxxufhvOQKml3/k4LIHQLSSHCTXB876qBUl/RWUM0mazjt8lqEKS6qduVYrFgrU U/P1R0C1tA95yOdDoRijiZdEIs2GOrqpMr3yFtcIqxAiB3oW8e5+Grr0zEUUp9A40Q48p2yvuUrR3 ivZhr+wzeK8Or1cSK3+3aOhBOPgi476x2mxjo/rACqFa3QkVPJ80Md1VSH8a1949RVqtbcsHUukWe vso5gEC7HqEZYsMUp1+NdSAd+nfswL3SHzN5Dau9Yqkwv5A/Veo+YTZoE+G4KtO4WhdulFZa470eq VsEFNSUaCp0WC99gVajg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8JdG-007Dsx-AY; Mon, 04 Jul 2022 10:48:47 +0000 Received: from relay12.mail.gandi.net ([2001:4b98:dc4:8::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8JAt-006tgc-Ux for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 10:19:30 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B22D220000D; Mon, 4 Jul 2022 10:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656929962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mh0Nhj24sgh2TKJWV5KlgEWJWx+38u9hSCW1uBlX7mk=; b=c4hXa5HR+Jt9+TXulYqwL+pt7blwXoqaHyaPXuNvYUy/wvL4oJYhMDvQc/GO5Uwcf9oOzA 54gpSsZOHX/xLbkTJ9TlnCeKJh+es6u3/Z8+U+0JZY42Qde/wf0csfbCYUswTVLnrzmmdJ 4CkKsOD+iqUbHNzDAYyzopRfC79cn4Ha9lrRbTAhX4gK7eI6E65LlofptOgrCZvr0K4KpY s0kgncOCXnnv1r2XrQeQPeQumKfYIfUvWkloGK0F6khaC+HlYtmez3HXBife0Td7ZJla1x IFrWR5f9V6f4jaeFe9K5daB7Oxbt5Uch58VWKjWLHRVIPTwIsTRLaJm+2ctxew== Date: Mon, 4 Jul 2022 12:19:16 +0200 From: Herve Codina To: Subject: Re: [PATCH v4 3/3] ARM: dts: lan966x: Add UDPHS support Message-ID: <20220704121916.3156f644@bootlin.com> In-Reply-To: <32790e6f-e708-ceee-e17f-1b09c909c991@microchip.com> References: <20220701070928.459135-1-herve.codina@bootlin.com> <20220701070928.459135-4-herve.codina@bootlin.com> <72a1e572-45d7-de18-8f1f-9035d75b562b@microchip.com> <20220701160327.102880e5@bootlin.com> <32790e6f-e708-ceee-e17f-1b09c909c991@microchip.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_031928_358593_4DECA22B X-CRM114-Status: GOOD ( 21.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, thomas.petazzoni@bootlin.com, sboyd@kernel.org, gregkh@linuxfoundation.org, mturquette@baylibre.com, linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Horatiu.Vultur@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2xhdWRpdSwKCk9uIE1vbiwgNCBKdWwgMjAyMiAwNTo0MTozMyArMDAwMAo8Q2xhdWRpdS5C ZXpuZWFAbWljcm9jaGlwLmNvbT4gd3JvdGU6Cgo+IE9uIDAxLjA3LjIwMjIgMTc6MDMsIEhlcnZl IENvZGluYSB3cm90ZToKPiA+IEVYVEVSTkFMIEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Ig b3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQo+ID4g Cj4gPiBIaSBDbGF1ZGl1LAo+ID4gCj4gPiBPbiBGcmksIDEgSnVsIDIwMjIgMTA6NTY6NDYgKzAw MDAKPiA+IDxDbGF1ZGl1LkJlem5lYUBtaWNyb2NoaXAuY29tPiB3cm90ZToKPiA+ICAgCj4gPj4g T24gMDEuMDcuMjAyMiAxMDowOSwgSGVydmUgQ29kaW5hIHdyb3RlOiAgCj4gPj4+IEVYVEVSTkFM IEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91 IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQo+ID4+Pgo+ID4+PiBBZGQgVURQSFMgKHRoZSBVU0Ig SGlnaCBTcGVlZCBEZXZpY2UgUG9ydCBjb250cm9sbGVyKSBzdXBwb3J0Lgo+ID4+Pgo+ID4+PiBU aGUgYm90aCBsYW45NjZ4IFNPQ3MgKExBTjk2NjIgYW5kIExBTjk2NjgpIGhhdmUgdGhlIHNhbWUg VURQSFMKPiA+Pj4gSVAuIFRoaXMgSVAgaXMgYWxzbyB0aGUgc2FtZSBhcyB0aGUgb25lIHByZXNl bnQgaW4gdGhlIFNBTUE1RDMKPiA+Pj4gU09DLgo+ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBI ZXJ2ZSBDb2RpbmEgPGhlcnZlLmNvZGluYUBib290bGluLmNvbT4KPiA+Pj4gLS0tCj4gPj4+ICBh cmNoL2FybS9ib290L2R0cy9sYW45NjZ4LmR0c2kgfCAxMSArKysrKysrKysrKwo+ID4+PiAgMSBm aWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKykKPiA+Pj4KPiA+Pj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtL2Jvb3QvZHRzL2xhbjk2NnguZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL2xhbjk2Nngu ZHRzaQo+ID4+PiBpbmRleCAzY2IwMmZmZmU3MTYuLmM5OGU3MDc1YzJiNCAxMDA2NDQKPiA+Pj4g LS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvbGFuOTY2eC5kdHNpCj4gPj4+ICsrKyBiL2FyY2gvYXJt L2Jvb3QvZHRzL2xhbjk2NnguZHRzaQo+ID4+PiBAQCAtNDU4LDYgKzQ1OCwxNyBAQCBjcHVfY3Ry bDogc3lzY29uQGUwMGMwMDAwIHsKPiA+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0g PDB4ZTAwYzAwMDAgMHgzNTA+Owo+ID4+PiAgICAgICAgICAgICAgICAgfTsKPiA+Pj4KPiA+Pj4g KyAgICAgICAgICAgICAgIHVkYzogdXNiQGUwODA4MDAwIHsKPiA+Pj4gKyAgICAgICAgICAgICAg ICAgICAgICAgY29tcGF0aWJsZSA9ICJtaWNyb2NoaXAsbGFuOTY2Mi11ZGMiLAo+ID4+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImF0bWVsLHNhbWE1ZDMtdWRjIjsKPiA+ Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MDAyMDAwMDAgMHg4MDAwMD4sCj4g Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwweGUwODA4MDAwIDB4NDAwPjsKPiA+ Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0cyA9IDxHSUNfU1BJIDc2IElSUV9U WVBFX0xFVkVMX0hJR0g+Owo+ID4+PiArICAgICAgICAgICAgICAgICAgICAgICBjbG9ja3MgPSA8 JmNsa3MgR0NLX0dBVEVfVURQSFM+LCA8Jm5pY19jbGs+Owo+ID4+PiArICAgICAgICAgICAgICAg ICAgICAgICBjbG9jay1uYW1lcyA9ICJwY2xrIiwgImhjbGsiOwo+ID4+PiArICAgICAgICAgICAg ICAgICAgICAgICBzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ID4+PiArICAgICAgICAgICAgICAgfTsK PiA+Pj4gKyAgCj4gPj4KPiA+PiBJIGhhdmUgdGhlc2UgY29tcGlsYXRpb24gd2FybmluZ3M6Cj4g Pj4KPiA+PiAgIERUQyAgICAgYXJjaC9hcm0vYm9vdC9kdHMvbGFuOTY2eC1wY2I4MjkxLmR0Ygo+ ID4+IGFyY2gvYXJtL2Jvb3QvZHRzL2xhbjk2NnguZHRzaTo0NjEuMjEtNDcwLjU6IFdhcm5pbmcg KHNpbXBsZV9idXNfcmVnKToKPiA+PiAvc29jL3VzYkBlMDgwODAwMDogc2ltcGxlLWJ1cyB1bml0 IGFkZHJlc3MgZm9ybWF0IGVycm9yLCBleHBlY3RlZCAiMjAwMDAwIgo+ID4+ICAgRFRDICAgICBh cmNoL2FybS9ib290L2R0cy9sYW45NjZ4LWtvbnRyb24ta3N3aXRjaC1kMTAtbW10LTZnLTJncy5k dGIKPiA+PiBhcmNoL2FybS9ib290L2R0cy9sYW45NjZ4LmR0c2k6NDYxLjIxLTQ3MC41OiBXYXJu aW5nIChzaW1wbGVfYnVzX3JlZyk6Cj4gPj4gL3NvYy91c2JAZTA4MDgwMDA6IHNpbXBsZS1idXMg dW5pdCBhZGRyZXNzIGZvcm1hdCBlcnJvciwgZXhwZWN0ZWQgIjIwMDAwMCIKPiA+PiAgIERUQyAg ICAgYXJjaC9hcm0vYm9vdC9kdHMvbGFuOTY2eC1rb250cm9uLWtzd2l0Y2gtZDEwLW1tdC04Zy5k dGIKPiA+PiBhcmNoL2FybS9ib290L2R0cy9sYW45NjZ4LmR0c2k6NDYxLjIxLTQ3MC41OiBXYXJu aW5nIChzaW1wbGVfYnVzX3JlZyk6Cj4gPj4gL3NvYy91c2JAZTA4MDgwMDA6IHNpbXBsZS1idXMg dW5pdCBhZGRyZXNzIGZvcm1hdCBlcnJvciwgZXhwZWN0ZWQgIjIwMDAwMCIgIAo+ID4gCj4gPiBJ IGFtIGEgYml0IGNvbmZ1c2VkIGJ1dCB0aGVzZSB3YXJuaW5ncyBkbyBub3QgYXBwZWFyIG9uIG15 IHNpZGUgKHBhdGNoZXMKPiA+IGJhc2VkIG9uIHY1LjE5LXJjMSkuCj4gPiBXaGF0IGlzIHRoZSBl eGFjdCBjb21tYW5kIHRoYXQgbGVhZHMgdG8gdGhlc2Ugd2FybmluZyA/ICAKPiAKPiBPaCwgYW5k IHRoZSBzZXQgb2YgY29tbWFuZHMgSSdtIHVzaW5nOgo+IG1ha2Ugc2FtYTdfZGVmY29uZmlnCj4g bWFrZSBtZW51Y29uZmlnICsgZW5hYmxlIENPTkZJR19TT0NfTEFOOTY2Cj4gbWFrZSBXPTEgZHRi cwoKSSBoYXZlIHRoZSB3YXJuaW5ncy4KVGhleSBhcmUgcHJlc2VudCB3aXRoICdXPTEnIHNldC4K CkkgcmVtb3ZlIHRoZW0gYW5kIHNlbmQgYSB2NS4KClRoYW5rcywKSGVydsOpCgotLSAKSGVydsOp IENvZGluYSwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0 dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK