From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB0B7CCA47B for ; Tue, 5 Jul 2022 10:15:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F19DC844E8; Tue, 5 Jul 2022 12:15:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="YPE4tB7X"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D3EDF844EF; Tue, 5 Jul 2022 12:15:32 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48D24805FE for ; Tue, 5 Jul 2022 12:15:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37C0E619A0; Tue, 5 Jul 2022 10:15:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B48C341C7; Tue, 5 Jul 2022 10:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657016128; bh=L9BzCFnT3dTzSyPZkVqwG89LMk9idoD7JE/0GuDTtMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YPE4tB7Xs5bUQvaSnrVqZ66AHnnNKULFqtmrN0GWXLmj2saeu3YHGzBeJhk8eXkYH u6mGnqpmiCNPNzSvv0//rWpoGx9LNFeWPbKa9kzQ7SeahpHvHqR6VMNB2DnxIdEliT UCCXZIkqKE0nrTcR/JHTgWzf1VaxFrxlVV52nsALLXPYuPt5MlwJ5RurXbB1CRkL4P eRHzWzBnKUT46M6cLjivftWG/5InU3NJWnQaR+o/Bw+D4ynRM0vVCY3zCMmuruQiSM j0hbZIa4EdmVdRCOl1HghKro5bLESKsLtJ2h2MxbewySeW+vAhYU4YNoTzE5+M0rDj mDSp8/Z9GNWkw== Received: by pali.im (Postfix) id AA7B5CBF; Tue, 5 Jul 2022 12:15:25 +0200 (CEST) Date: Tue, 5 Jul 2022 12:15:25 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Frieder Schrempf Cc: u-boot@lists.denx.de, Simon Glass , Sjoerd Simons , Parthiban Nallathambi , Hiremath Gireesh , Marcel Ziswiler , Patrick Delaunay , "Derald D. Woods" , Govindaraji Sivanantham , Navin Sankar Velliangiri , Martyn Welch , Patrice Chotard Subject: Re: [PATCH] distroboot: Fix ubifs Message-ID: <20220705101525.iw3ei54xctobykcr@pali> References: <20220531083236.18968-1-pali@kernel.org> <20220623160922.ntaj3p4echi7tvs6@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wednesday 29 June 2022 12:29:40 Frieder Schrempf wrote: > Am 23.06.22 um 18:09 schrieb Pali Rohár: > > On Tuesday 31 May 2022 10:32:36 Pali Rohár wrote: > >> Fix multiple issues in ubifs distroboot code: > >> > >> U-Boot supports attaching only one MTD device as UBI at the time. So > >> always call 'ubifsmount ubi0:${bootubivol}' for mounting UBI volume > >> ${bootubivol}. Usage of 'ubi${devnum}' is incorrect as 'ubi part' > >> command attach MTD device always as UBI device ubi0. > >> > >> Set distroboot ${bootfstype} variable to ubifs in ubifs_boot command. > >> Distroboot scripts require ${bootfstype} variable to be properly set and it > >> is already set for all other boot types. > >> > >> Set distroboot ${distro_bootpart} variable to ${bootubivol} value. UBI > >> device does not have partitions, but has volumes. Distroboot scripts > >> require something to be set in ${distro_bootpart} variable, so set it to > >> the UBI volume which is currently mounted by ubifs. > >> > >> Set distroboot ${devnum} variable to fixed string "ubi0". ubifs code > >> differs from the other partition code that it requires "ubi" prefix before > >> number. > >> > >> Explicitly unmount ubifs volume after loading all data from it. This allows > >> to detach UBI device from MTD device. > >> > >> Move definition of MTD device with UBI and UBI volume with ubifs filesystem > >> from global env variables ${bootubipart} and ${bootubivol} into the > >> distroboot "func" macro, defined in board include config files. UBIFS > >> distroboot macros then set ${bootubipart} and ${bootubivol} local variables > >> for compatibility with existing distroboot scripts. > >> > >> This last change allows to define more UBIFS target devices and make it > >> clear what is boot MTD/UBI device. > >> > >> All board include config files are adjusted to use this new scheme of > >> specifying boot MTD/UBI device. > >> > >> Signed-off-by: Pali Rohár > > > > PING? > > > > Sorry, I currently don't have the time to properly review and/or test > this. Though, in general the changes look good and I can at least provide: > > Acked-by: Frieder Schrempf > > I think it would help to split this up in smaller chunks, so people can > review it more easily... Splitting these changes is hard as it needs to be done atomtically to do not break boards or do not break compilation. I think it is better to have one bigger change than lot of smaller which cause compile or runtime errors until all small changes are applied.