From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
"Maxim Mikityanskiy" <maximmi@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net] Revert "tls: rx: move counting TlsDecryptErrors for sync"
Date: Tue, 5 Jul 2022 14:41:35 -0700 [thread overview]
Message-ID: <20220705144135.5685cf7f@kernel.org> (raw)
In-Reply-To: <20220705110837.24633-1-gal@nvidia.com>
On Tue, 5 Jul 2022 14:08:37 +0300 Gal Pressman wrote:
> This reverts commit 284b4d93daee56dff3e10029ddf2e03227f50dbf.
> When using TLS device offload and coming from tls_device_reencrypt()
> flow, -EBADMSG error in tls_do_decryption() should not be counted
> towards the TLSTlsDecryptError counter.
>
> Move the counter increase back to the decrypt_internal() call site in
> decrypt_skb_update().
> This also fixes an issue where:
> if (n_sgin < 1)
> return -EBADMSG;
>
> Errors in decrypt_internal() were not counted after the cited patch.
>
> Fixes: 284b4d93daee ("tls: rx: move counting TlsDecryptErrors for sync")
> Cc: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Maxim Mikityanskiy <maximmi@nvidia.com>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2022-07-05 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 11:08 [PATCH net] Revert "tls: rx: move counting TlsDecryptErrors for sync" Gal Pressman
2022-07-05 21:41 ` Jakub Kicinski [this message]
2022-07-06 22:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705144135.5685cf7f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.