From: Rob Herring <robh@kernel.org>
To: Jimmy Chen <jinghung.chen3@hotmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Alan Huang <alan-huang@quanta.corp-partner.google.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family
Date: Tue, 5 Jul 2022 10:39:13 -0600 [thread overview]
Message-ID: <20220705163913.GA2234759-robh@kernel.org> (raw)
In-Reply-To: <SG2PR03MB5006CBD49DB3052D57A6ABF0CC819@SG2PR03MB5006.apcprd03.prod.outlook.com>
On Tue, Jul 05, 2022 at 10:57:47AM +0800, Jimmy Chen wrote:
> This adds a LTE skus for Chromebook Villager to the yaml.
Your subject is wrong. This is not a .dts file change. Use 'git log
--oneline' for inspiration as to what the subject should look like for
this file/directory.
>
> Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com>
> ---
>
> The format of the added items is based on the below document.
> Documentation/arm/google/chromebook-boot-flow.rst
>
> Changes in v2:
> - Update the patch title and the commit message
> Changes in v3:
> - Update patch title
>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 4dd18fbf20b68..a136b1389c2ac 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -529,11 +529,26 @@ properties:
> - const: google,herobrine
> - const: qcom,sc7280
>
> + - description: Google Villager (rev0)
> + items:
> + - const: google,villager-rev0
> + - const: qcom,sc7280
> +
> - description: Google Villager (newest rev)
> items:
> - const: google,villager
> - const: qcom,sc7280
>
> + - description: Google Villager with LTE (rev0)
> + items:
> + - const: google,villager-rev0-sku0
> + - const: qcom,sc7280
> +
> + - description: Google Villager with LTE (newest rev)
> + items:
> + - const: google,villager-sku0
> + - const: qcom,sc7280
> +
> - items:
> - enum:
> - lenovo,flex-5g
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-07-05 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 2:57 [PATCH 1/2] [v3 1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family Jimmy Chen
2022-07-05 16:39 ` Rob Herring [this message]
2022-07-05 17:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705163913.GA2234759-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alan-huang@quanta.corp-partner.google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jinghung.chen3@hotmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.