From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
jgg@ziepe.ca, jhubbard@nvidia.com, william.kucharski@oracle.com,
dan.j.williams@intel.com, jack@suse.cz, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
nvdimm@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages
Date: Tue, 5 Jul 2022 16:47:10 -0700 [thread overview]
Message-ID: <20220705164710.9541b5cf0e5819193213ea5c@linux-foundation.org> (raw)
In-Reply-To: <YsTLgQ45ESpsNEGV@casper.infradead.org>
On Wed, 6 Jul 2022 00:38:41 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> On Tue, Jul 05, 2022 at 02:18:19PM -0700, Andrew Morton wrote:
> > On Tue, 5 Jul 2022 20:35:32 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
> >
> > > FSDAX page refcounts are 1-based, rather than 0-based: if refcount is
> > > 1, then the page is freed. The FSDAX pages can be pinned through GUP,
> > > then they will be unpinned via unpin_user_page() using a folio variant
> > > to put the page, however, folio variants did not consider this special
> > > case, the result will be to miss a wakeup event (like the user of
> > > __fuse_dax_break_layouts()). Since FSDAX pages are only possible get
> > > by GUP users, so fix GUP instead of folio_put() to lower overhead.
> > >
> >
> > What are the user visible runtime effects of this bug?
>
> "missing wake up event" seems pretty obvious to me? Something goes to
> sleep waiting for a page to become unused, and is never woken.
No, missed wakeups are often obscured by another wakeup coming in
shortly afterwards.
If this wakeup is not one of these, then are there reports from the
softlockup detector?
Do we have reports of processes permanently stuck in D state?
next prev parent reply other threads:[~2022-07-05 23:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 12:35 [PATCH v2] mm: fix missing wake-up event for FSDAX pages Muchun Song
2022-07-05 21:18 ` Andrew Morton
2022-07-05 23:38 ` Matthew Wilcox
2022-07-05 23:47 ` Andrew Morton [this message]
2022-07-06 2:47 ` Muchun Song
2022-07-06 3:00 ` Andrew Morton
2022-07-06 3:11 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705164710.9541b5cf0e5819193213ea5c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.