From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C2EEC43334 for ; Wed, 6 Jul 2022 11:42:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5A8416C5; Wed, 6 Jul 2022 13:41:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5A8416C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657107762; bh=JEjuk3NRh5Sqky4+wZoKy/erpto/3iqBO17mFsOx2OY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=fIgq4sgoA5AIqr8QMvkiui+aamDHX1yqoXs+fEw5TxOZLXZKvUoMpYHyYnCJ8MTEp C9B1cIMQYMchajDujas0JMLK0Cze1xZQNTAv1vTANdwxAtEDz7Xd/90nyi3d8WqCU4 2VO8OlC+NYcZiY4LgRqYIZneg7XBMiAElM/Puihg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 57406F8053B; Wed, 6 Jul 2022 13:40:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 748A9F800CB; Tue, 5 Jul 2022 22:12:17 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5738CF800CB for ; Tue, 5 Jul 2022 22:12:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5738CF800CB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jzyDqqOs" Received: by mail-qt1-x832.google.com with SMTP id z13so15398406qts.12 for ; Tue, 05 Jul 2022 13:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=jzyDqqOsmOiFQpBNDEIIiq2MN35QtJrUD2/ujzSWycMbbCOOa/kXWzucbOzXvgJPlM l41OpTnwJFtVKAh9ESeTZGx5QRNGnFLf7Ve6XK/dYXbRSWYolxdZFruwb2QvUjtDqKp3 XPq8C5Jcp4JG3opZdh2U+imHALhK3sBAHCCrGSqp8Vv6nsMRfMt39kYqHYOSFDIblB6A qByLsJ7MJ8hdI1n2d+9GcDpXsaJ8cJ751FUYmiFAN8pTN8GWtaPdCiQlJR4UCA74w7VK BYLuDVNV9YmL+YjlB3aU/m2FQ5afMCy9VI/vJGznIenuOAJI2wSPMGBH0t9pzT1ABtei oFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=I5oB2i5ovAVgwXDz4uFmHR2MLj4uLi3yDrZH+8BLu8BfE4z57wqLczkbcEG1vCw9D1 oAo0GcWtjapypxxzGl8wBkuhSEpSDipvZGL5v5q+BKI6jcCMP4xJOSXX0UmdzSxkYKf5 vpUhgv77MJ5U2+isHZq/70x0NudhjOGSD1Tl4dfW2WL9efynV4dizBpnQgyVPKG3p6QV k+RLdm6rLrSIHl/TGIN9nRUZQb1n8osECGvfCuUvXHhA/vqey4URMyC1pUGpYX4pvdIz DH81Jajt+KbQyiDn15gKfa1ChjPmwEaRTfjLkwS1Axz1Yg9N+DGxyI75gU53wWge8sH2 s0xg== X-Gm-Message-State: AJIora8oA4mTwS7A+obwqrP3JbITGrSOs3cvY0sPp40lqQu6vE++lb7i SuzexietE5oOuaD3WJ6khw== X-Google-Smtp-Source: AGRyM1u4u9ZwI6TH3XXA0OihqRZmFnWXSbIWS9PPVuMbOGG9LjOzdO13UTe9CCCWifIK+MVZg68DbA== X-Received: by 2002:ad4:594e:0:b0:472:f6bc:c7fb with SMTP id eo14-20020ad4594e000000b00472f6bcc7fbmr10360585qvb.96.1657051924471; Tue, 05 Jul 2022 13:12:04 -0700 (PDT) Received: from serve.minyard.net ([47.184.144.75]) by smtp.gmail.com with ESMTPSA id ey14-20020a05622a4c0e00b002fcb0d95f65sm22827224qtb.90.2022.07.05.13.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 13:12:02 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:1895:1b49:2a68:29f7]) by serve.minyard.net (Postfix) with ESMTPSA id B3B861800BD; Tue, 5 Jul 2022 20:11:57 +0000 (UTC) Date: Tue, 5 Jul 2022 15:11:56 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705201156.GL908082@minyard.net> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> X-Mailman-Approved-At: Wed, 06 Jul 2022 13:40:50 +0200 Cc: Andrew Lunn , Ricardo Ribalda , Jimmy Su , Benjamin Herrenschmidt , Linus Walleij , Sekhar Nori , Gwendal Grignou , dri-devel@lists.freedesktop.org, Benjamin Tissoires , Paul Mackerras , Moses Christopher Bollavarapu , Pavel Machek , Miquel Raynal , Heikki Krogerus , Evgeniy Polyakov , Matt Johnston , Olli Salonen , Angela Czubak , Robert Marko , Luka Perkov , Sean Young , Dave Stevenson , Michael Ellerman , Zheyu Ma , Javier Martinez Canillas , Christophe Leroy , Chanwoo Choi , linux-omap@vger.kernel.org, Antti Palosaari , Wenyou Yang , Dongchun Zhu , Miaoqian Lin , Steve Longerbeam , Bingbu Cao , Shunqian Zheng , lijian , Dan Carpenter , Bartlomiej Zolnierkiewicz , Viorel Suman , Petr Machata , Guido =?utf-8?Q?G=C3=BCnther?= , Jean Delvare , linux-serial@vger.kernel.org, linux-pm@vger.kernel.org, Eddie James , Riku Voipio , James Schulman , Scott Wood , Cai Huoqing , Jonas Malaco , Hsin-Yi Wang , Haibo Chen , Petr Cvek , linux-leds@vger.kernel.org, Joe Tessler , Andrey Konovalov , Andy Shevchenko , Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Heungjun Kim , Hans Verkuil , David Lin , Vladimir Oltean , David Rhodes , Claudiu Beznea , Jean-Baptiste Maneyrol , Alexandre Belloni , Dan Robertson , Martyn Welch , Jiri Slaby , devicetree@vger.kernel.org, David Airlie , Jon Nettleton , Srinivas Pandruvada , Marco Felsch , Wim Van Sebroeck , Sebastian Reichel , Max Filippov , "Lad, Prabhakar" , Thierry Reding , linux-i2c@vger.kernel.org, Martiros Shakhzadyan , Guenter Roeck , Matthias Schwarzott , Eric Dumazet , Marek =?utf-8?B?QmVow7pu?= , Saranya Gopal , Lars-Peter Clausen , Evgeny Novikov , Frank Rowand , Bartosz Golaszewski , Manivannan Sadhasivam , Pierre-Louis Bossart , Minghao Chi , linux-clk@vger.kernel.org, Nathan Chancellor , MyungJoo Ham , Charles Gorand , Jagan Teki , Vijendar Mukunda , Miguel Ojeda , Kyungmin Park , Tianshu Qiu , Martin Donnelly , Woojung Huh , Rudolf Marek , Charles Keepax , linux-watchdog@vger.kernel.org, Michael Hennerich , Ido Schimmel , acpi4asus-user@lists.sourceforge.net, Simon Trimmer , Ricard Wanderlof , Rikard Falkeborn , Alex Deucher , Jiri Valek - 2N , linux-rpi-kernel@lists.infradead.org, Biju Das , Wayne Chang , Chen-Yu Tsai , Sing-Han Chen , linux-arm-kernel@lists.infradead.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Hans de Goede , Stephen Boyd , Maslov Dmitry , linux-gpio@vger.kernel.org, Jens Frederich , Douglas Anderson , linux-media@vger.kernel.org, "David S. Miller" , Wolfram Sang , Jarkko Sakkinen , linux-usb@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , CGEL ZTE , Colin Leroy , platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai , Pali =?utf-8?B?Um9ow6Fy?= , Jonathan Cameron , Heiner Kallweit , Daniel Palmer , Arec Kao , Crt Mori , Jose Cazarin , Neil Armstrong , linux-iio@vger.kernel.org, Tom Rix , Michael Turquette , Peter Senna Tschudin , Benjamin Mugnier , Nuno =?utf-8?B?U8Oh?= , Jan-Simon Moeller , Wei Yongjun , Laurent Pinchart , Andrzej Hajda , Nikita Travkin , Jeremy Kerr , Jasmin Jessich , Sam Ravnborg , Kevin Cernekee , Alyssa Rosenzweig , linux-rtc@vger.kernel.org, Daniel Thompson , Florian Fainelli , Lucas Tanure , Stefan Mavrodiev , Masahiro Yamada , Sylvain Petinot , netdev@vger.kernel.org, Kieran Bingham , Jernej Skrabec , Xin Ji , Seven Lee , Matt Ranostay , Broadcom internal kernel review list , Adrien Grassein , Yang Yingliang , chrome-platform@lists.linux.dev, Mats Randgaard , Paolo Abeni , Alexey Dobriyan , Joel Stanley , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul , Kees Cook , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Yang Li , Tim Harvey , Jiri Kosina , Akinobu Mita , Mark Gross , Richard Fitzgerald , Mark Brown , wengjianfeng , Maxime Ripard , Sven Peter , Martin Kepplinger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , "Daniel W. S. Almeida" , Chiranjeevi Rapolu , Alessandro Zummo , linux-hwmon@vger.kernel.org, Felipe Balbi , Stephan Gerhold , Support Opensource , Alexandru Ardelean , Dmitry Torokhov , Marc Hulsman , Corentin Chary , Stephen Kitt , Daniel Scally , linux-fbdev@vger.kernel.org, Andrey Ryabinin , Arnd Bergmann , Kirill Shilimanov , Sakari Ailus , patches@opensource.cirrus.com, Zheng Yongjun , Alejandro Tafalla , Peter Rosin , Arnaud Ferraris , Hector Martin , Vignesh Raghavendra , Nick Dyer , Greg Kroah-Hartman , Tony Lindgren , Alexandre Torgue , Takashi Iwai , Paul Cercueil , George McCollister , Mac Chiang , Antoniu Miclaus , Alexander Potapenko , linux-staging@lists.linux.dev, Adam Ford , Peter Huewe , UNGLinuxDriver@microchip.com, Lee Jones , linux-mtd@lists.infradead.org, Alexey Khoroshilov , Marek Vasut , Paul Kocialkowski , alsa-devel@alsa-project.org, Vincenzo Frascino , Eric Piel , Herbert Xu , Tobias Schrammm , Richard Weinberger , Tomasz Duszynski , Janusz Krzysztofik , Russell King , linux-pwm@vger.kernel.org, Jason Gunthorpe , Thomas Zimmermann , Bastien Nocera , Jingoo Han , Jakub Kicinski , Vivien Didelot , Yizhuo , Shawn Tu , Leon Luo , Yan Lei , Akihiro Tsukada , Tudor Ambarus , Dmitry Rokosov , Oliver Graute , Alistair Francis , Dongliang Mu , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Eduardo Valentin , Rui Miguel Silva , Michael Srba , Rob Herring , linux-mediatek@lists.infradead.org, Fabio Estevam , Matthias Brugger , kasan-dev@googlegroups.com, "Paul J. Murphy" , Nicola Lunghi , Daniele Alessandrelli , Dmitry Vyukov , Ramesh Shanmugasundaram , Liam Girdwood , Juerg Haefliger , Oder Chiou , Shengjiu Wang , Nicolas Ferre , Robert Foss , Krzysztof Kozlowski , Daniel Vetter , Alvin =?utf-8?Q?=C5=A0ipraga?= , Luca Ceresoli , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Johannes Berg , Colin Ian King , Maximilian Luz , Helge Deller , Lucas Stach X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. For IPMI portions below: Acked-by: Corey Minyard > > static const struct i2c_device_id lcd2s_i2c_id[] = { > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index db40037eb347..a0e9e80d92ee 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -341,14 +341,12 @@ static int ipmb_probe(struct i2c_client *client) > return 0; > } > > -static int ipmb_remove(struct i2c_client *client) > +static void ipmb_remove(struct i2c_client *client) > { > struct ipmb_dev *ipmb_dev = i2c_get_clientdata(client); > > i2c_slave_unregister(client); > misc_deregister(&ipmb_dev->miscdev); > - > - return 0; > } > > static const struct i2c_device_id ipmb_id[] = { > diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c > index ab19b4b3317e..25c010c9ec25 100644 > --- a/drivers/char/ipmi/ipmi_ipmb.c > +++ b/drivers/char/ipmi/ipmi_ipmb.c > @@ -424,7 +424,7 @@ static void ipmi_ipmb_request_events(void *send_info) > /* We don't fetch events here. */ > } > > -static int ipmi_ipmb_remove(struct i2c_client *client) > +static void ipmi_ipmb_remove(struct i2c_client *client) > { > struct ipmi_ipmb_dev *iidev = i2c_get_clientdata(client); > > @@ -438,8 +438,6 @@ static int ipmi_ipmb_remove(struct i2c_client *client) > ipmi_ipmb_stop_thread(iidev); > > ipmi_unregister_smi(iidev->intf); > - > - return 0; > } > > static int ipmi_ipmb_probe(struct i2c_client *client) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index fc742ee9c046..13da021e7c6b 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1281,13 +1281,13 @@ static void shutdown_ssif(void *send_info) > } > } > > -static int ssif_remove(struct i2c_client *client) > +static void ssif_remove(struct i2c_client *client) > { > struct ssif_info *ssif_info = i2c_get_clientdata(client); > struct ssif_addr_info *addr_info; > > if (!ssif_info) > - return 0; > + return; > > /* > * After this point, we won't deliver anything asychronously > @@ -1303,8 +1303,6 @@ static int ssif_remove(struct i2c_client *client) > } > > kfree(ssif_info); > - > - return 0; > } > > static int read_response(struct i2c_client *client, unsigned char *resp) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687352917; Tue, 5 Jul 2022 20:12:03 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id z7so9574863qko.8; Tue, 05 Jul 2022 13:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=jzyDqqOsmOiFQpBNDEIIiq2MN35QtJrUD2/ujzSWycMbbCOOa/kXWzucbOzXvgJPlM l41OpTnwJFtVKAh9ESeTZGx5QRNGnFLf7Ve6XK/dYXbRSWYolxdZFruwb2QvUjtDqKp3 XPq8C5Jcp4JG3opZdh2U+imHALhK3sBAHCCrGSqp8Vv6nsMRfMt39kYqHYOSFDIblB6A qByLsJ7MJ8hdI1n2d+9GcDpXsaJ8cJ751FUYmiFAN8pTN8GWtaPdCiQlJR4UCA74w7VK BYLuDVNV9YmL+YjlB3aU/m2FQ5afMCy9VI/vJGznIenuOAJI2wSPMGBH0t9pzT1ABtei oFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=VRB4jzbiyfT6+8QpG/VI1vp7kjlBK2dJydmI7Rw4VtpE5JfCX81lUn0ZFSf8RRWDQC Jg2z2I0Cc5j3nGHd3KuAatWtqdG29FJWQ1uZVz0YYHRaqhkuxrQhHKAan2xUmu8bNu1G MNJhmS4uG4mpk7AwOpBgohtBBCDqY9NqQeeuu0Zwv098jUt4t2QkwIfAHqBrsoOH3NhD 2x4cTTkvO9icmAis1Q4vYYkUP4HaPjxN6QYu+Gc8OBPQF00kIdeBULkeUH1fz2n+ijJI AXXXI1YpB2d1TEp4PhTADRnU+1q6V/cA0dhFR/NBAX408AvT0WYi95bgYoK+nYVypSXi lc3A== X-Gm-Message-State: AJIora/wpRvMKgGq7tjDtBzfjUdKm8orvckt2wHPSU4VRmpCgcCyrTHb NzG8HLE+1Zs8pEhaN8rv2Q== X-Google-Smtp-Source: AGRyM1v0OJ93Nu3s63zVNhYbXwTamj5LdNYK8gxlMvIKZ0kjVcSqwnmSr3p+XEHk7rqxFSougreCpA== X-Received: by 2002:a05:620a:385:b0:6af:1f2b:9168 with SMTP id q5-20020a05620a038500b006af1f2b9168mr24692503qkm.170.1657051922136; Tue, 05 Jul 2022 13:12:02 -0700 (PDT) Received: from serve.minyard.net ([47.184.144.75]) by smtp.gmail.com with ESMTPSA id r8-20020a05620a298800b006b4689e3425sm5643578qkp.129.2022.07.05.13.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 13:12:01 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:1895:1b49:2a68:29f7]) by serve.minyard.net (Postfix) with ESMTPSA id B3B861800BD; Tue, 5 Jul 2022 20:11:57 +0000 (UTC) Date: Tue, 5 Jul 2022 15:11:56 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Wolfram Sang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Sekhar Nori , Bartosz Golaszewski , Russell King , Scott Wood , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Robin van der Gracht , Miguel Ojeda , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Max Filippov , Michael Turquette , Stephen Boyd , Luca Ceresoli , Tudor Ambarus , Herbert Xu , "David S. Miller" , MyungJoo Ham , Chanwoo Choi , Michael Hennerich , Linus Walleij , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Benson Leung , Guenter Roeck , Phong LE , Adrien Grassein , Peter Senna Tschudin , Martin Donnelly , Martyn Welch , Douglas Anderson , Stefan Mavrodiev , Thierry Reding , Sam Ravnborg , Florian Fainelli , Broadcom internal kernel review list , Javier Martinez Canillas , Jiri Kosina , Benjamin Tissoires , Jean Delvare , George Joseph , Juerg Haefliger , Riku Voipio , Robert Marko , Luka Perkov , Marc Hulsman , Rudolf Marek , Peter Rosin , Jonathan Cameron , Lars-Peter Clausen , Dan Robertson , Rui Miguel Silva , Tomasz Duszynski , Kevin Tsai , Crt Mori , Dmitry Torokhov , Nick Dyer , Bastien Nocera , Hans de Goede , Maxime Coquelin , Alexandre Torgue , Sakari Ailus , Pavel Machek , Jan-Simon Moeller , Marek =?utf-8?B?QmVow7pu?= , Colin Leroy , Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Antti Palosaari , Jasmin Jessich , Matthias Schwarzott , Olli Salonen , Akihiro Tsukada , Kieran Bingham , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Martin Kepplinger , Ricardo Ribalda , Dave Stevenson , Leon Luo , Manivannan Sadhasivam , Bingbu Cao , "Paul J. Murphy" , Daniele Alessandrelli , Michael Tretter , Pengutronix Kernel Team , Kyungmin Park , Heungjun Kim , Ramesh Shanmugasundaram , Jacopo Mondi , Niklas =?utf-8?Q?S=C3=B6derlund?= , Jimmy Su , Arec Kao , "Lad, Prabhakar" , Shunqian Zheng , Steve Longerbeam , Chiranjeevi Rapolu , Daniel Scally , Wenyou Yang , Petr Cvek , Akinobu Mita , Sylwester Nawrocki , Benjamin Mugnier , Sylvain Petinot , Mats Randgaard , Tim Harvey , Matt Ranostay , Eduardo Valentin , "Daniel W. S. Almeida" , Lee Jones , Chen-Yu Tsai , Support Opensource , Robert Jones , Andy Shevchenko , Charles Keepax , Richard Fitzgerald , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Tony Lindgren , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , UNGLinuxDriver@microchip.com, George McCollister , Ido Schimmel , Petr Machata , Jeremy Kerr , Matt Johnston , Charles Gorand , Krzysztof Opasiak , Rob Herring , Frank Rowand , Mark Gross , Maximilian Luz , Corentin Chary , Pali =?utf-8?B?Um9ow6Fy?= , Sebastian Reichel , Tobias Schrammm , Liam Girdwood , Mark Brown , Alessandro Zummo , Jens Frederich , Jon Nettleton , Jiri Slaby , Felipe Balbi , Heikki Krogerus , Daniel Thompson , Jingoo Han , Helge Deller , Evgeniy Polyakov , Wim Van Sebroeck , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Johannes Berg , Jaroslav Kysela , Takashi Iwai , James Schulman , David Rhodes , Lucas Tanure , Nuno =?utf-8?B?U8Oh?= , Matthias Brugger , Oder Chiou , Fabio Estevam , Kevin Cernekee , Christophe Leroy , Maxime Ripard , Alvin =?utf-8?Q?=C5=A0ipraga?= , Lucas Stach , Jagan Teki , Biju Das , Thomas Zimmermann , Alex Deucher , Lyude Paul , Xin Ji , Hsin-Yi Wang , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Yang Li , Angela Czubak , Alistair Francis , Eddie James , Joel Stanley , Nathan Chancellor , Antoniu Miclaus , Alexandru Ardelean , Dmitry Rokosov , Srinivas Pandruvada , Stephan Gerhold , Miaoqian Lin , Gwendal Grignou , Yang Yingliang , Paul Cercueil , Daniel Palmer , Haibo Chen , Cai Huoqing , Marek Vasut , Jose Cazarin , Dan Carpenter , Jean-Baptiste Maneyrol , Michael Srba , Nikita Travkin , Maslov Dmitry , Jiri Valek - 2N , Arnaud Ferraris , Zheyu Ma , Marco Felsch , Oliver Graute , Zheng Yongjun , CGEL ZTE , Minghao Chi , Evgeny Novikov , Sean Young , Kirill Shilimanov , Moses Christopher Bollavarapu , Paul Kocialkowski , Janusz Krzysztofik , Dongliang Mu , Colin Ian King , lijian , Kees Cook , Yan Lei , Heiner Kallweit , Jonas Malaco , wengjianfeng , Rikard Falkeborn , Wei Yongjun , Tom Rix , Yizhuo , Martiros Shakhzadyan , Bjorn Andersson , Sven Peter , Alyssa Rosenzweig , Hector Martin , Saranya Gopal , Guido =?utf-8?Q?G=C3=BCnther?= , Sing-Han Chen , Wayne Chang , Geert Uytterhoeven , Alexey Dobriyan , Masahiro Yamada , Vincent Knecht , Stephen Kitt , Pierre-Louis Bossart , Alexey Khoroshilov , Randy Dunlap , Alejandro Tafalla , Vijendar Mukunda , Seven Lee , Mac Chiang , David Lin , Daniel Beer , Ricard Wanderlof , Simon Trimmer , Shengjiu Wang , Viorel Suman , Nicola Lunghi , Adam Ford , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705201156.GL908082@minyard.net> Reply-To: minyard@acm.org References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. For IPMI portions below: Acked-by: Corey Minyard > > static const struct i2c_device_id lcd2s_i2c_id[] = { > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index db40037eb347..a0e9e80d92ee 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -341,14 +341,12 @@ static int ipmb_probe(struct i2c_client *client) > return 0; > } > > -static int ipmb_remove(struct i2c_client *client) > +static void ipmb_remove(struct i2c_client *client) > { > struct ipmb_dev *ipmb_dev = i2c_get_clientdata(client); > > i2c_slave_unregister(client); > misc_deregister(&ipmb_dev->miscdev); > - > - return 0; > } > > static const struct i2c_device_id ipmb_id[] = { > diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c > index ab19b4b3317e..25c010c9ec25 100644 > --- a/drivers/char/ipmi/ipmi_ipmb.c > +++ b/drivers/char/ipmi/ipmi_ipmb.c > @@ -424,7 +424,7 @@ static void ipmi_ipmb_request_events(void *send_info) > /* We don't fetch events here. */ > } > > -static int ipmi_ipmb_remove(struct i2c_client *client) > +static void ipmi_ipmb_remove(struct i2c_client *client) > { > struct ipmi_ipmb_dev *iidev = i2c_get_clientdata(client); > > @@ -438,8 +438,6 @@ static int ipmi_ipmb_remove(struct i2c_client *client) > ipmi_ipmb_stop_thread(iidev); > > ipmi_unregister_smi(iidev->intf); > - > - return 0; > } > > static int ipmi_ipmb_probe(struct i2c_client *client) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index fc742ee9c046..13da021e7c6b 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1281,13 +1281,13 @@ static void shutdown_ssif(void *send_info) > } > } > > -static int ssif_remove(struct i2c_client *client) > +static void ssif_remove(struct i2c_client *client) > { > struct ssif_info *ssif_info = i2c_get_clientdata(client); > struct ssif_addr_info *addr_info; > > if (!ssif_info) > - return 0; > + return; > > /* > * After this point, we won't deliver anything asychronously > @@ -1303,8 +1303,6 @@ static int ssif_remove(struct i2c_client *client) > } > > kfree(ssif_info); > - > - return 0; > } > > static int read_response(struct i2c_client *client, unsigned char *resp) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F51AC43334 for ; Tue, 5 Jul 2022 20:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mf3NUmI9Q3Nm+ewU3S+Bt8PdT7xTf2/mVB42ftm4nGY=; b=tdtz740ptFtYW2 MBtRfZHUnGcNbjmm6XfK74JmOXM9nclWj1qqQZHUg8if1Dug5U1RQ9U+tGdx211eqi92UBIP01Xgt ytSpbSOsKXj2pQOTnEheZ0JS2S5ywsPVHzKfMw/7GU/4a5Lio3o6RCkXBgQbywcMGIQ4loWCJcEAs 0SAXWewnPtxTBb7M/z8l9bluDFlMU44yxNdN8rUnpoglQx1DN2hwurcL+HnaMC9DtA0kR32Mlq5Lj wtd+FqmIM4BeXiBj2A58BtOPHNUqPGZD5qHiIwepsVLDhWXkWJw6ekXBcXBiI4XNGG2GQvQJhrpJJ CP2ZdXOScnQ4g5g9ueiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8ou3-002Yfp-9d; Tue, 05 Jul 2022 20:12:11 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8otz-002Ydr-2X; Tue, 05 Jul 2022 20:12:08 +0000 Received: by mail-qk1-x72f.google.com with SMTP id n10so9575256qkn.10; Tue, 05 Jul 2022 13:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=jzyDqqOsmOiFQpBNDEIIiq2MN35QtJrUD2/ujzSWycMbbCOOa/kXWzucbOzXvgJPlM l41OpTnwJFtVKAh9ESeTZGx5QRNGnFLf7Ve6XK/dYXbRSWYolxdZFruwb2QvUjtDqKp3 XPq8C5Jcp4JG3opZdh2U+imHALhK3sBAHCCrGSqp8Vv6nsMRfMt39kYqHYOSFDIblB6A qByLsJ7MJ8hdI1n2d+9GcDpXsaJ8cJ751FUYmiFAN8pTN8GWtaPdCiQlJR4UCA74w7VK BYLuDVNV9YmL+YjlB3aU/m2FQ5afMCy9VI/vJGznIenuOAJI2wSPMGBH0t9pzT1ABtei oFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=E8yn0Hz9QxF3ZgyZtCdQJpYAzHWHrBQIxhZ6ttHjc84nP7gycMQ4oHLP4EbzWpnXJ/ hv09JXIFzCLZDkVL9eaOIu0oxzWAmNuTLLJQVVmbd6aKnxspVaau4B5Oj2VfgHeQDFoV lSypgvigq/jW1Dl5JJYD4PV4vxa3VaPaYe1wINItapFlLgA5V4uwta74Nsd3DxxhOd6a EPjH3mtmrS9neRO2BJwbTYVdPBneV/KDP5yS9PgFPiKTbyuh7RHF5whuXhLHztJvWKCb w6IPtdAlBW/SXoxIwT/A6kXYHMwI3LW5gKdU2Xj07b+60jbNnVFEAYl8JTAt6UgQJrFi EfZA== X-Gm-Message-State: AJIora8bv5T6tnIilvcwgNMdIpIBgL0SEGUNsuwYNaACQBhLpCBqADXa AXDmf6ZGpq20rgJ9S8qdMzRlmko3/NFC X-Google-Smtp-Source: AGRyM1v0OJ93Nu3s63zVNhYbXwTamj5LdNYK8gxlMvIKZ0kjVcSqwnmSr3p+XEHk7rqxFSougreCpA== X-Received: by 2002:a05:620a:385:b0:6af:1f2b:9168 with SMTP id q5-20020a05620a038500b006af1f2b9168mr24692503qkm.170.1657051922136; Tue, 05 Jul 2022 13:12:02 -0700 (PDT) Received: from serve.minyard.net ([47.184.144.75]) by smtp.gmail.com with ESMTPSA id r8-20020a05620a298800b006b4689e3425sm5643578qkp.129.2022.07.05.13.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 13:12:01 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:1895:1b49:2a68:29f7]) by serve.minyard.net (Postfix) with ESMTPSA id B3B861800BD; Tue, 5 Jul 2022 20:11:57 +0000 (UTC) Date: Tue, 5 Jul 2022 15:11:56 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Wolfram Sang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Sekhar Nori , Bartosz Golaszewski , Russell King , Scott Wood , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Robin van der Gracht , Miguel Ojeda , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Max Filippov , Michael Turquette , Stephen Boyd , Luca Ceresoli , Tudor Ambarus , Herbert Xu , "David S. Miller" , MyungJoo Ham , Chanwoo Choi , Michael Hennerich , Linus Walleij , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Benson Leung , Guenter Roeck , Phong LE , Adrien Grassein , Peter Senna Tschudin , Martin Donnelly , Martyn Welch , Douglas Anderson , Stefan Mavrodiev , Thierry Reding , Sam Ravnborg , Florian Fainelli , Broadcom internal kernel review list , Javier Martinez Canillas , Jiri Kosina , Benjamin Tissoires , Jean Delvare , George Joseph , Juerg Haefliger , Riku Voipio , Robert Marko , Luka Perkov , Marc Hulsman , Rudolf Marek , Peter Rosin , Jonathan Cameron , Lars-Peter Clausen , Dan Robertson , Rui Miguel Silva , Tomasz Duszynski , Kevin Tsai , Crt Mori , Dmitry Torokhov , Nick Dyer , Bastien Nocera , Hans de Goede , Maxime Coquelin , Alexandre Torgue , Sakari Ailus , Pavel Machek , Jan-Simon Moeller , Marek =?utf-8?B?QmVow7pu?= , Colin Leroy , Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Antti Palosaari , Jasmin Jessich , Matthias Schwarzott , Olli Salonen , Akihiro Tsukada , Kieran Bingham , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Martin Kepplinger , Ricardo Ribalda , Dave Stevenson , Leon Luo , Manivannan Sadhasivam , Bingbu Cao , "Paul J. Murphy" , Daniele Alessandrelli , Michael Tretter , Pengutronix Kernel Team , Kyungmin Park , Heungjun Kim , Ramesh Shanmugasundaram , Jacopo Mondi , Niklas =?utf-8?Q?S=C3=B6derlund?= , Jimmy Su , Arec Kao , "Lad, Prabhakar" , Shunqian Zheng , Steve Longerbeam , Chiranjeevi Rapolu , Daniel Scally , Wenyou Yang , Petr Cvek , Akinobu Mita , Sylwester Nawrocki , Benjamin Mugnier , Sylvain Petinot , Mats Randgaard , Tim Harvey , Matt Ranostay , Eduardo Valentin , "Daniel W. S. Almeida" , Lee Jones , Chen-Yu Tsai , Support Opensource , Robert Jones , Andy Shevchenko , Charles Keepax , Richard Fitzgerald , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Tony Lindgren , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , UNGLinuxDriver@microchip.com, George McCollister , Ido Schimmel , Petr Machata , Jeremy Kerr , Matt Johnston , Charles Gorand , Krzysztof Opasiak , Rob Herring , Frank Rowand , Mark Gross , Maximilian Luz , Corentin Chary , Pali =?utf-8?B?Um9ow6Fy?= , Sebastian Reichel , Tobias Schrammm , Liam Girdwood , Mark Brown , Alessandro Zummo , Jens Frederich , Jon Nettleton , Jiri Slaby , Felipe Balbi , Heikki Krogerus , Daniel Thompson , Jingoo Han , Helge Deller , Evgeniy Polyakov , Wim Van Sebroeck , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Johannes Berg , Jaroslav Kysela , Takashi Iwai , James Schulman , David Rhodes , Lucas Tanure , Nuno =?utf-8?B?U8Oh?= , Matthias Brugger , Oder Chiou , Fabio Estevam , Kevin Cernekee , Christophe Leroy , Maxime Ripard , Alvin =?utf-8?Q?=C5=A0ipraga?= , Lucas Stach , Jagan Teki , Biju Das , Thomas Zimmermann , Alex Deucher , Lyude Paul , Xin Ji , Hsin-Yi Wang , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Yang Li , Angela Czubak , Alistair Francis , Eddie James , Joel Stanley , Nathan Chancellor , Antoniu Miclaus , Alexandru Ardelean , Dmitry Rokosov , Srinivas Pandruvada , Stephan Gerhold , Miaoqian Lin , Gwendal Grignou , Yang Yingliang , Paul Cercueil , Daniel Palmer , Haibo Chen , Cai Huoqing , Marek Vasut , Jose Cazarin , Dan Carpenter , Jean-Baptiste Maneyrol , Michael Srba , Nikita Travkin , Maslov Dmitry , Jiri Valek - 2N , Arnaud Ferraris , Zheyu Ma , Marco Felsch , Oliver Graute , Zheng Yongjun , CGEL ZTE , Minghao Chi , Evgeny Novikov , Sean Young , Kirill Shilimanov , Moses Christopher Bollavarapu , Paul Kocialkowski , Janusz Krzysztofik , Dongliang Mu , Colin Ian King , lijian , Kees Cook , Yan Lei , Heiner Kallweit , Jonas Malaco , wengjianfeng , Rikard Falkeborn , Wei Yongjun , Tom Rix , Yizhuo , Martiros Shakhzadyan , Bjorn Andersson , Sven Peter , Alyssa Rosenzweig , Hector Martin , Saranya Gopal , Guido =?utf-8?Q?G=C3=BCnther?= , Sing-Han Chen , Wayne Chang , Geert Uytterhoeven , Alexey Dobriyan , Masahiro Yamada , Vincent Knecht , Stephen Kitt , Pierre-Louis Bossart , Alexey Khoroshilov , Randy Dunlap , Alejandro Tafalla , Vijendar Mukunda , Seven Lee , Mac Chiang , David Lin , Daniel Beer , Ricard Wanderlof , Simon Trimmer , Shengjiu Wang , Viorel Suman , Nicola Lunghi , Adam Ford , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705201156.GL908082@minyard.net> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_131207_179079_4D0653F0 X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjgsIDIwMjIgYXQgMDQ6MDM6MTJQTSArMDIwMCwgVXdlIEtsZWluZS1Lw7Zu aWcgd3JvdGU6Cj4gRnJvbTogVXdlIEtsZWluZS1Lw7ZuaWcgPHV3ZUBrbGVpbmUta29lbmlnLm9y Zz4KPiAKPiBUaGUgdmFsdWUgcmV0dXJuZWQgYnkgYW4gaTJjIGRyaXZlcidzIHJlbW92ZSBmdW5j dGlvbiBpcyBtb3N0bHkgaWdub3JlZC4KPiAoT25seSBhbiBlcnJvciBtZXNzYWdlIGlzIHByaW50 ZWQgaWYgdGhlIHZhbHVlIGlzIG5vbi16ZXJvIHRoYXQgdGhlCj4gZXJyb3IgaXMgaWdub3JlZC4p Cj4gCj4gU28gY2hhbmdlIHRoZSBwcm90b3R5cGUgb2YgdGhlIHJlbW92ZSBmdW5jdGlvbiB0byBy ZXR1cm4gbm8gdmFsdWUuIFRoaXMKPiB3YXkgZHJpdmVyIGF1dGhvcnMgYXJlIG5vdCB0ZW1wdGVk IHRvIGFzc3VtZSB0aGF0IHBhc3NpbmcgYW4gZXJyb3IgdG8KPiB0aGUgdXBwZXIgbGF5ZXIgaXMg YSBnb29kIGlkZWEuIEFsbCBkcml2ZXJzIGFyZSBhZGFwdGVkIGFjY29yZGluZ2x5Lgo+IFRoZXJl IGlzIG5vIGludGVuZGVkIGNoYW5nZSBvZiBiZWhhdmlvdXIsIGFsbCBjYWxsYmFja3Mgd2VyZSBw cmVwYXJlZCB0bwo+IHJldHVybiAwIGJlZm9yZS4KCkZvciBJUE1JIHBvcnRpb25zIGJlbG93OgoK QWNrZWQtYnk6IENvcmV5IE1pbnlhcmQgPGNuaW55YXJkQG12aXN0YS5jb20+Cgo+ICAKPiAgc3Rh dGljIGNvbnN0IHN0cnVjdCBpMmNfZGV2aWNlX2lkIGxjZDJzX2kyY19pZFtdID0gewo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2NoYXIvaXBtaS9pcG1iX2Rldl9pbnQuYyBiL2RyaXZlcnMvY2hhci9p cG1pL2lwbWJfZGV2X2ludC5jCj4gaW5kZXggZGI0MDAzN2ViMzQ3Li5hMGU5ZTgwZDkyZWUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9jaGFyL2lwbWkvaXBtYl9kZXZfaW50LmMKPiArKysgYi9kcml2 ZXJzL2NoYXIvaXBtaS9pcG1iX2Rldl9pbnQuYwo+IEBAIC0zNDEsMTQgKzM0MSwxMiBAQCBzdGF0 aWMgaW50IGlwbWJfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCkKPiAgCXJldHVybiAw Owo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGlwbWJfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpj bGllbnQpCj4gK3N0YXRpYyB2b2lkIGlwbWJfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGll bnQpCj4gIHsKPiAgCXN0cnVjdCBpcG1iX2RldiAqaXBtYl9kZXYgPSBpMmNfZ2V0X2NsaWVudGRh dGEoY2xpZW50KTsKPiAgCj4gIAlpMmNfc2xhdmVfdW5yZWdpc3RlcihjbGllbnQpOwo+ICAJbWlz Y19kZXJlZ2lzdGVyKCZpcG1iX2Rldi0+bWlzY2Rldik7Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gIH0K PiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaTJjX2RldmljZV9pZCBpcG1iX2lkW10gPSB7Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2hhci9pcG1pL2lwbWlfaXBtYi5jIGIvZHJpdmVycy9jaGFy L2lwbWkvaXBtaV9pcG1iLmMKPiBpbmRleCBhYjE5YjRiMzMxN2UuLjI1YzAxMGM5ZWMyNSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2NoYXIvaXBtaS9pcG1pX2lwbWIuYwo+ICsrKyBiL2RyaXZlcnMv Y2hhci9pcG1pL2lwbWlfaXBtYi5jCj4gQEAgLTQyNCw3ICs0MjQsNyBAQCBzdGF0aWMgdm9pZCBp cG1pX2lwbWJfcmVxdWVzdF9ldmVudHModm9pZCAqc2VuZF9pbmZvKQo+ICAJLyogV2UgZG9uJ3Qg ZmV0Y2ggZXZlbnRzIGhlcmUuICovCj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaXBtaV9pcG1iX3Jl bW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KQo+ICtzdGF0aWMgdm9pZCBpcG1pX2lwbWJf cmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCj4gIHsKPiAgCXN0cnVjdCBpcG1pX2lw bWJfZGV2ICppaWRldiA9IGkyY19nZXRfY2xpZW50ZGF0YShjbGllbnQpOwo+ICAKPiBAQCAtNDM4 LDggKzQzOCw2IEBAIHN0YXRpYyBpbnQgaXBtaV9pcG1iX3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVu dCAqY2xpZW50KQo+ICAJaXBtaV9pcG1iX3N0b3BfdGhyZWFkKGlpZGV2KTsKPiAgCj4gIAlpcG1p X3VucmVnaXN0ZXJfc21pKGlpZGV2LT5pbnRmKTsKPiAtCj4gLQlyZXR1cm4gMDsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBpcG1pX2lwbWJfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCkK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jaGFyL2lwbWkvaXBtaV9zc2lmLmMgYi9kcml2ZXJzL2No YXIvaXBtaS9pcG1pX3NzaWYuYwo+IGluZGV4IGZjNzQyZWU5YzA0Ni4uMTNkYTAyMWU3YzZiIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvY2hhci9pcG1pL2lwbWlfc3NpZi5jCj4gKysrIGIvZHJpdmVy cy9jaGFyL2lwbWkvaXBtaV9zc2lmLmMKPiBAQCAtMTI4MSwxMyArMTI4MSwxMyBAQCBzdGF0aWMg dm9pZCBzaHV0ZG93bl9zc2lmKHZvaWQgKnNlbmRfaW5mbykKPiAgCX0KPiAgfQo+ICAKPiAtc3Rh dGljIGludCBzc2lmX3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KQo+ICtzdGF0aWMg dm9pZCBzc2lmX3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KQo+ICB7Cj4gIAlzdHJ1 Y3Qgc3NpZl9pbmZvICpzc2lmX2luZm8gPSBpMmNfZ2V0X2NsaWVudGRhdGEoY2xpZW50KTsKPiAg CXN0cnVjdCBzc2lmX2FkZHJfaW5mbyAqYWRkcl9pbmZvOwo+ICAKPiAgCWlmICghc3NpZl9pbmZv KQo+IC0JCXJldHVybiAwOwo+ICsJCXJldHVybjsKPiAgCj4gIAkvKgo+ICAJICogQWZ0ZXIgdGhp cyBwb2ludCwgd2Ugd29uJ3QgZGVsaXZlciBhbnl0aGluZyBhc3ljaHJvbm91c2x5Cj4gQEAgLTEz MDMsOCArMTMwMyw2IEBAIHN0YXRpYyBpbnQgc3NpZl9yZW1vdmUoc3RydWN0IGkyY19jbGllbnQg KmNsaWVudCkKPiAgCX0KPiAgCj4gIAlrZnJlZShzc2lmX2luZm8pOwo+IC0KPiAtCXJldHVybiAw Owo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IHJlYWRfcmVzcG9uc2Uoc3RydWN0IGkyY19jbGllbnQg KmNsaWVudCwgdW5zaWduZWQgY2hhciAqcmVzcCkKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5n IGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1t dGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53456C43334 for ; Wed, 6 Jul 2022 07:41:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C22CE11238F; Wed, 6 Jul 2022 07:41:44 +0000 (UTC) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0173111AC8A for ; Tue, 5 Jul 2022 20:12:02 +0000 (UTC) Received: by mail-qt1-x832.google.com with SMTP id h19so15401151qtp.6 for ; Tue, 05 Jul 2022 13:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=jzyDqqOsmOiFQpBNDEIIiq2MN35QtJrUD2/ujzSWycMbbCOOa/kXWzucbOzXvgJPlM l41OpTnwJFtVKAh9ESeTZGx5QRNGnFLf7Ve6XK/dYXbRSWYolxdZFruwb2QvUjtDqKp3 XPq8C5Jcp4JG3opZdh2U+imHALhK3sBAHCCrGSqp8Vv6nsMRfMt39kYqHYOSFDIblB6A qByLsJ7MJ8hdI1n2d+9GcDpXsaJ8cJ751FUYmiFAN8pTN8GWtaPdCiQlJR4UCA74w7VK BYLuDVNV9YmL+YjlB3aU/m2FQ5afMCy9VI/vJGznIenuOAJI2wSPMGBH0t9pzT1ABtei oFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=DddiHlt6UfBl9qoZf8SE89FrVhrphQAoWjLjM57G9vg89/4usnXokhTmMGIu7d3X3U ahz4jXfbDMys8DaAwGG6s6xucNyMBhLJvUa8hT4QT9cb1DUAIXIYhiZdaojX01dRLOG2 em0JQLd1L5vTB2C8LUOCsZlNydQVmh1yGewA4SHW5cxddTUD3nJdGIsmaU3EAWQDuSz1 L4hrzKUhuR6tezGTrEUQ/FUjJpbjcojmBxYBam+9Z5ZmaJDup5agRjko+8tGmALrqB6s xCYVYujncwOmhojAeNFKlB8llUjeGeJOQA8+ZXbkCFTHoVb6dE7jOQMAFr8U7MAHxwpA 85Hg== X-Gm-Message-State: AJIora91nsBU3jeplH5YtPblRzvf/tP13GDHtFwW/6dcA6bl53ioTqjj 4TQDPfwucm8GVhILri7XIA== X-Google-Smtp-Source: AGRyM1vwyWfnyu4uTtqBiBsFZNRwslD8UO8gfwEOhJ2ajwove3iVeaLXkFdkCmQC6YgxpEm1JQDV1A== X-Received: by 2002:a05:622a:1449:b0:31b:eb3d:1eaf with SMTP id v9-20020a05622a144900b0031beb3d1eafmr29654149qtx.459.1657051921832; Tue, 05 Jul 2022 13:12:01 -0700 (PDT) Received: from serve.minyard.net ([47.184.144.75]) by smtp.gmail.com with ESMTPSA id m3-20020a05620a24c300b006b46a78bc0fsm5201397qkn.118.2022.07.05.13.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 13:12:00 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:1895:1b49:2a68:29f7]) by serve.minyard.net (Postfix) with ESMTPSA id B3B861800BD; Tue, 5 Jul 2022 20:11:57 +0000 (UTC) Date: Tue, 5 Jul 2022 15:11:56 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705201156.GL908082@minyard.net> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> X-Mailman-Approved-At: Wed, 06 Jul 2022 07:41:40 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: Andrew Lunn , Ricardo Ribalda , Jimmy Su , Sekhar Nori , Gwendal Grignou , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Minghao Chi , Pavel Machek , Miquel Raynal , Heikki Krogerus , Evgeniy Polyakov , Matt Johnston , Olli Salonen , Angela Czubak , Mauro Carvalho Chehab , Luka Perkov , Sean Young , Dave Stevenson , Michael Ellerman , Zheyu Ma , Javier Martinez Canillas , Christophe Leroy , Chanwoo Choi , linux-omap@vger.kernel.org, Wenyou Yang , Dongchun Zhu , Miaoqian Lin , Steve Longerbeam , Bingbu Cao , Shunqian Zheng , lijian , Dan Carpenter , Bartlomiej Zolnierkiewicz , Viorel Suman , Petr Machata , Guido =?utf-8?Q?G=C3=BCnther?= , Jean Delvare , linux-serial@vger.kernel.org, linux-pm@vger.kernel.org, linux-mtd@lists.infradead.org, Eddie James , Riku Voipio , James Schulman , Scott Wood , Cai Huoqing , Jonas Malaco , Hsin-Yi Wang , Haibo Chen , Petr Cvek , linux-leds@vger.kernel.org, Joe Tessler , Andrey Konovalov , Andy Shevchenko , Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Heungjun Kim , Hans Verkuil , David Lin , Vladimir Oltean , David Rhodes , Claudiu Beznea , Arnaud Ferraris , Jean-Baptiste Maneyrol , Alexandre Belloni , Dan Robertson , Martyn Welch , Jiri Slaby , devicetree@vger.kernel.org, David Airlie , Jon Nettleton , Srinivas Pandruvada , Marco Felsch , Wim Van Sebroeck , Sebastian Reichel , Max Filippov , "Lad, Prabhakar" , Thierry Reding , linux-i2c@vger.kernel.org, Martiros Shakhzadyan , Guenter Roeck , Matthias Schwarzott , Sylwester Nawrocki , Dmitry Rokosov , Marek =?utf-8?B?QmVow7pu?= , Saranya Gopal , Evgeny Novikov , Frank Rowand , Bartosz Golaszewski , Manivannan Sadhasivam , Pierre-Louis Bossart , Eric Dumazet , linux-clk@vger.kernel.org, Nathan Chancellor , alsa-devel@alsa-project.org, MyungJoo Ham , Charles Gorand , Jagan Teki , Vijendar Mukunda , Miguel Ojeda , Kyungmin Park , Tianshu Qiu , Martin Donnelly , Woojung Huh , Rudolf Marek , Charles Keepax , linux-watchdog@vger.kernel.org, Michael Hennerich , Ido Schimmel , acpi4asus-user@lists.sourceforge.net, Simon Trimmer , Ricard Wanderlof , Rikard Falkeborn , Alex Deucher , wengjianfeng , Jiri Valek - 2N , linux-rpi-kernel@lists.infradead.org, Biju Das , Wayne Chang , Chen-Yu Tsai , Sing-Han Chen , linux-arm-kernel@lists.infradead.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Hans de Goede , Stephen Boyd , Maslov Dmitry , linux-gpio@vger.kernel.org, Jens Frederich , Douglas Anderson , Peter Rosin , Wolfram Sang , Jarkko Sakkinen , linux-usb@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , CGEL ZTE , Colin Leroy , platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai , Pali =?utf-8?B?Um9ow6Fy?= , Jonathan Cameron , Heiner Kallweit , Arec Kao , Crt Mori , Jose Cazarin , Neil Armstrong , linux-iio@vger.kernel.org, Tom Rix , Michael Turquette , Peter Senna Tschudin , Benjamin Mugnier , Nuno =?utf-8?B?U8Oh?= , Jan-Simon Moeller , Wei Yongjun , Laurent Pinchart , Andrzej Hajda , Nikita Travkin , Jeremy Kerr , Jasmin Jessich , Sam Ravnborg , Kevin Cernekee , Alyssa Rosenzweig , linux-rtc@vger.kernel.org, Daniel Thompson , Florian Fainelli , Lucas Tanure , Stefan Mavrodiev , Masahiro Yamada , Sylvain Petinot , netdev@vger.kernel.org, Kieran Bingham , Jernej Skrabec , Xin Ji , Seven Lee , Matt Ranostay , Broadcom internal kernel review list , Adrien Grassein , Yang Yingliang , chrome-platform@lists.linux.dev, Mats Randgaard , Paolo Abeni , Alexey Dobriyan , Joel Stanley , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Kees Cook , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Yang Li , Jiri Kosina , Akinobu Mita , Mark Gross , Richard Fitzgerald , Mark Brown , linux-media@vger.kernel.org, Maxime Ripard , Sven Peter , Martin Kepplinger , openipmi-developer@lists.sourceforge.net, Robert Marko , "Daniel W. S. Almeida" , Chiranjeevi Rapolu , Alessandro Zummo , linux-hwmon@vger.kernel.org, Felipe Balbi , Stephan Gerhold , Support Opensource , Alexandru Ardelean , Dmitry Torokhov , Marc Hulsman , Corentin Chary , Stephen Kitt , Daniel Scally , linux-fbdev@vger.kernel.org, Andrey Ryabinin , Arnd Bergmann , Kirill Shilimanov , Sakari Ailus , patches@opensource.cirrus.com, Zheng Yongjun , Alejandro Tafalla , "David S. Miller" , Daniel Palmer , Hector Martin , Moses Christopher Bollavarapu , Vignesh Raghavendra , Nick Dyer , Greg Kroah-Hartman , Tony Lindgren , Alexandre Torgue , Takashi Iwai , Paul Cercueil , Mac Chiang , Antoniu Miclaus , Alexander Potapenko , Adam Ford , Peter Huewe , UNGLinuxDriver@microchip.com, Lee Jones , Alexey Khoroshilov , Marek Vasut , Paul Kocialkowski , Vincenzo Frascino , Eric Piel , Herbert Xu , Tobias Schrammm , Richard Weinberger , Tomasz Duszynski , Janusz Krzysztofik , Russell King , linux-pwm@vger.kernel.org, Jason Gunthorpe , Thomas Zimmermann , Bastien Nocera , Jingoo Han , Jakub Kicinski , Vivien Didelot , Yizhuo , Shawn Tu , Leon Luo , Yan Lei , Akihiro Tsukada , Tudor Ambarus , Oliver Graute , Alistair Francis , Dongliang Mu , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Eduardo Valentin , Rui Miguel Silva , Michael Srba , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , kasan-dev@googlegroups.com, "Paul J. Murphy" , Nicola Lunghi , Daniele Alessandrelli , Dmitry Vyukov , Ramesh Shanmugasundaram , Liam Girdwood , Juerg Haefliger , Oder Chiou , Shengjiu Wang , Nicolas Ferre , Robert Foss , Krzysztof Kozlowski , Alvin =?utf-8?Q?=C5=A0ipraga?= , Luca Ceresoli , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Johannes Berg , Colin Ian King , Maximilian Luz , Helge Deller , linux-staging@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. For IPMI portions below: Acked-by: Corey Minyard > > static const struct i2c_device_id lcd2s_i2c_id[] = { > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index db40037eb347..a0e9e80d92ee 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -341,14 +341,12 @@ static int ipmb_probe(struct i2c_client *client) > return 0; > } > > -static int ipmb_remove(struct i2c_client *client) > +static void ipmb_remove(struct i2c_client *client) > { > struct ipmb_dev *ipmb_dev = i2c_get_clientdata(client); > > i2c_slave_unregister(client); > misc_deregister(&ipmb_dev->miscdev); > - > - return 0; > } > > static const struct i2c_device_id ipmb_id[] = { > diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c > index ab19b4b3317e..25c010c9ec25 100644 > --- a/drivers/char/ipmi/ipmi_ipmb.c > +++ b/drivers/char/ipmi/ipmi_ipmb.c > @@ -424,7 +424,7 @@ static void ipmi_ipmb_request_events(void *send_info) > /* We don't fetch events here. */ > } > > -static int ipmi_ipmb_remove(struct i2c_client *client) > +static void ipmi_ipmb_remove(struct i2c_client *client) > { > struct ipmi_ipmb_dev *iidev = i2c_get_clientdata(client); > > @@ -438,8 +438,6 @@ static int ipmi_ipmb_remove(struct i2c_client *client) > ipmi_ipmb_stop_thread(iidev); > > ipmi_unregister_smi(iidev->intf); > - > - return 0; > } > > static int ipmi_ipmb_probe(struct i2c_client *client) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index fc742ee9c046..13da021e7c6b 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1281,13 +1281,13 @@ static void shutdown_ssif(void *send_info) > } > } > > -static int ssif_remove(struct i2c_client *client) > +static void ssif_remove(struct i2c_client *client) > { > struct ssif_info *ssif_info = i2c_get_clientdata(client); > struct ssif_addr_info *addr_info; > > if (!ssif_info) > - return 0; > + return; > > /* > * After this point, we won't deliver anything asychronously > @@ -1303,8 +1303,6 @@ static int ssif_remove(struct i2c_client *client) > } > > kfree(ssif_info); > - > - return 0; > } > > static int read_response(struct i2c_client *client, unsigned char *resp)