From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org
Subject: [PATCH 02/13] tracing/IB/hfi1: Use the new __vstring() helper
Date: Tue, 05 Jul 2022 18:44:55 -0400 [thread overview]
Message-ID: <20220705224749.239494531@goodmis.org> (raw)
In-Reply-To: 20220705224453.120955146@goodmis.org
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Instead of open coding a __dynamic_array() with a fixed length (which
defeats the purpose of the dynamic array in the first place). Use the new
__vstring() helper that will use a va_list and only write enough of the
string into the ring buffer that is needed.
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
drivers/infiniband/hw/hfi1/trace_dbg.h | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/trace_dbg.h b/drivers/infiniband/hw/hfi1/trace_dbg.h
index 707f1053f0b7..582b6f68df3d 100644
--- a/drivers/infiniband/hw/hfi1/trace_dbg.h
+++ b/drivers/infiniband/hw/hfi1/trace_dbg.h
@@ -26,14 +26,10 @@ DECLARE_EVENT_CLASS(hfi1_trace_template,
TP_PROTO(const char *function, struct va_format *vaf),
TP_ARGS(function, vaf),
TP_STRUCT__entry(__string(function, function)
- __dynamic_array(char, msg, MAX_MSG_LEN)
+ __vstring(msg, vaf->fmt, vaf->va)
),
TP_fast_assign(__assign_str(function, function);
- WARN_ON_ONCE(vsnprintf
- (__get_dynamic_array(msg),
- MAX_MSG_LEN, vaf->fmt,
- *vaf->va) >=
- MAX_MSG_LEN);
+ __assign_vstr(msg, vaf->fmt, vaf->va);
),
TP_printk("(%s) %s",
__get_str(function),
--
2.35.1
next prev parent reply other threads:[~2022-07-05 22:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 22:44 [PATCH 00/13] tracing/events: Add __vstring and __assign_vstr helpers Steven Rostedt
2022-07-05 22:44 ` [PATCH 01/13] tracing/events: Add __vstring() and __assign_vstr() helper macros Steven Rostedt
2022-07-07 1:35 ` Chunfeng Yun
2022-07-12 18:00 ` Steven Rostedt
2022-07-13 9:41 ` Chunfeng Yun
2022-07-15 21:42 ` [PATCH 01/13 v2] " Steven Rostedt
2022-07-15 21:44 ` Steven Rostedt
2022-07-05 22:44 ` Steven Rostedt [this message]
2022-07-06 4:20 ` [PATCH 02/13] tracing/IB/hfi1: Use the new __vstring() helper kernel test robot
2022-07-05 22:44 ` [PATCH 03/13] tracing/ath: " Steven Rostedt
2022-07-05 22:44 ` Steven Rostedt
2022-07-05 22:44 ` Steven Rostedt
2022-07-08 6:45 ` Kalle Valo
2022-07-08 6:45 ` Kalle Valo
2022-07-08 6:45 ` Kalle Valo
2022-07-05 22:44 ` [PATCH 04/13] tracing/brcm: " Steven Rostedt
2022-07-06 2:35 ` kernel test robot
2022-07-06 2:50 ` Steven Rostedt
2022-07-06 2:50 ` Steven Rostedt
2022-07-06 9:09 ` Arend Van Spriel
2022-07-06 9:09 ` Arend Van Spriel
2022-07-06 11:51 ` Chen, Rong A
2022-07-08 5:02 ` Kalle Valo
2022-07-05 22:44 ` [PATCH 05/13] tracing/iwlwifi: " Steven Rostedt
2022-07-08 5:03 ` Kalle Valo
2022-07-05 22:44 ` [PATCH 06/13] usb: chipidea: tracing: " Steven Rostedt
2022-07-05 22:45 ` [PATCH 07/13] xhci: " Steven Rostedt
2022-07-05 22:45 ` [PATCH 08/13] USB: mtu3: " Steven Rostedt
2022-07-05 22:45 ` Steven Rostedt
2022-07-06 4:30 ` kernel test robot
2022-07-06 10:23 ` kernel test robot
2022-07-06 10:23 ` kernel test robot
2022-07-14 13:38 ` [PATCH 08/13 v2] " Steven Rostedt
2022-07-14 13:38 ` Steven Rostedt
2022-07-14 13:45 ` Greg Kroah-Hartman
2022-07-14 13:45 ` Greg Kroah-Hartman
2022-07-14 14:35 ` Steven Rostedt
2022-07-14 14:35 ` Steven Rostedt
2022-07-05 22:45 ` [PATCH 09/13] usb: musb: " Steven Rostedt
2022-07-05 22:45 ` [PATCH 10/13] scsi: iscsi: " Steven Rostedt
2022-07-05 22:45 ` [PATCH 11/13] scsi: qla2xxx: " Steven Rostedt
2022-07-05 22:45 ` [PATCH 12/13] batman-adv: " Steven Rostedt
2022-07-05 22:45 ` [PATCH 13/13] mac80211: " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705224749.239494531@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.