From: "Marek Behún" <kabel@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] [RFT] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding
Date: Wed, 6 Jul 2022 13:15:07 +0200 [thread overview]
Message-ID: <20220706131507.353f0bed@thinkpad> (raw)
In-Reply-To: <20220705155929.25565-1-pali@kernel.org>
On Tue, 5 Jul 2022 17:59:28 +0200
Pali Rohár <pali@kernel.org> wrote:
> +examples:
> + - |
> + #include <dt-bindings/leds/common.h>
> +
> + cpld@3,0 {
The generic node name should be just "bus". That it is a CPLD
implementation should come from compatible string.
This is similar to how we have generic names like "led-controller",
"switch", "ethernet-phy", ...
Pali, I can take over this and get it merged if you are getting
frustrated here.
Marek
next prev parent reply other threads:[~2022-07-06 11:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 0:04 [PATCH 1/2] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Pali Rohár
2022-07-05 0:04 ` [PATCH 2/2] leds: Add support for Turris 1.x LEDs Pali Rohár
2022-07-05 10:37 ` Marek Behún
2022-07-05 10:56 ` Pali Rohár
2022-07-05 11:52 ` Marek Behún
2022-07-05 12:22 ` Pali Rohár
2022-07-05 12:30 ` Marek Behún
2022-07-05 12:32 ` Pali Rohár
2022-07-05 12:38 ` Marek Behún
2022-07-05 11:36 ` [PATCH 1/2] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Krzysztof Kozlowski
2022-07-05 11:42 ` Pali Rohár
2022-07-05 11:51 ` Krzysztof Kozlowski
2022-07-05 12:15 ` Pali Rohár
2022-07-05 12:55 ` Krzysztof Kozlowski
2022-07-05 13:05 ` Pali Rohár
2022-07-05 13:07 ` Krzysztof Kozlowski
2022-07-05 11:53 ` Marek Behún
2022-07-05 13:54 ` Rob Herring
2022-07-05 15:59 ` [PATCH v2 1/2] [RFT] " Pali Rohár
2022-07-05 15:59 ` [PATCH v2 2/2] leds: Add support for Turris 1.x LEDs Pali Rohár
2022-07-05 17:30 ` Marek Behún
2022-07-05 18:40 ` Andy Shevchenko
2022-07-05 18:46 ` Pali Rohár
2022-07-05 18:58 ` Andy Shevchenko
2022-11-02 0:25 ` Pali Rohár
2022-07-05 17:51 ` [PATCH v2 1/2] [RFT] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Krzysztof Kozlowski
2022-07-05 19:18 ` Rob Herring
2022-07-06 11:15 ` Marek Behún [this message]
2022-07-06 11:19 ` Pali Rohár
2022-07-06 15:27 ` Marek Behún
2022-07-06 15:36 ` Krzysztof Kozlowski
2022-07-06 16:43 ` Marek Behún
2022-07-06 18:16 ` Krzysztof Kozlowski
2022-07-08 16:05 ` Pali Rohár
2022-07-08 16:29 ` Marek Behún
2022-07-12 21:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706131507.353f0bed@thinkpad \
--to=kabel@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pali@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.