From: Jakub Kicinski <kuba@kernel.org>
To: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
Cc: chris.snook@gmail.com, davem@davemloft.net, edumazet@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ag71xx: switch to napi_build_skb() to reuse skbuff_heads
Date: Wed, 6 Jul 2022 19:52:13 -0700 [thread overview]
Message-ID: <20220706195213.6b751af8@kernel.org> (raw)
In-Reply-To: <20220705004434.1453-1-liew.s.piaw@gmail.com>
On Tue, 5 Jul 2022 08:44:34 +0800 Sieng-Piaw Liew wrote:
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -825,7 +825,7 @@ static int ag71xx_tx_packets(struct ag71xx *ag, bool flush)
> if (!skb)
> continue;
>
> - dev_kfree_skb_any(skb);
> + napi_consume_skb(skb, !flush);
!flush is not sufficient here, napi can be called with a budget of 0.
next prev parent reply other threads:[~2022-07-07 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 0:44 [PATCH] net: ag71xx: switch to napi_build_skb() to reuse skbuff_heads Sieng-Piaw Liew
2022-07-07 2:52 ` Jakub Kicinski [this message]
2022-07-07 14:10 ` [PATCH net-next v2] " Sieng-Piaw Liew
2022-07-08 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706195213.6b751af8@kernel.org \
--to=kuba@kernel.org \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=liew.s.piaw@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.