From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, sre@kernel.org,
skhan@linuxfoundation.org, ndesaulniers@google.com,
michal.lkml@markovi.net, mcgrof@kernel.org, masahiroy@kernel.org,
lucas.demarchi@intel.com, keescook@chromium.org,
john.ogness@linutronix.de, jani.nikula@linux.intel.com,
gregkh@linuxfoundation.org, gpiccoli@igalia.com,
dlatypov@google.com, corbet@lwn.net, brendanhiggins@google.com,
atomlin@redhat.com, andriy.shevchenko@linux.intel.com,
davidgow@google.com, akpm@linux-foundation.org
Subject: + module-panic-taint-the-kernel-when-selftest-modules-load.patch added to mm-nonmm-unstable branch
Date: Wed, 06 Jul 2022 14:23:50 -0700 [thread overview]
Message-ID: <20220706212351.2A8ECC341C6@smtp.kernel.org> (raw)
The patch titled
Subject: module: panic: taint the kernel when selftest modules load
has been added to the -mm mm-nonmm-unstable branch. Its filename is
module-panic-taint-the-kernel-when-selftest-modules-load.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/module-panic-taint-the-kernel-when-selftest-modules-load.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: David Gow <davidgow@google.com>
Subject: module: panic: taint the kernel when selftest modules load
Date: Sat, 2 Jul 2022 12:09:57 +0800
Taint the kernel with TAINT_TEST whenever a test module loads, by adding a
new "TEST" module property, and setting it for all modules in the
tools/testing directory. This property can also be set manually, for
tests which live outside the tools/testing directory with:
MODULE_INFO(test, "Y");
Link: https://lkml.kernel.org/r/20220702040959.3232874-2-davidgow@google.com
Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Aaron Tomlin <atomlin@redhat.com>
Acked-by: Brendan Higgins <brendanhiggins@google.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Daniel Latypov <dlatypov@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guilherme G. Piccoli <gpiccoli@igalia.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/module/main.c | 7 +++++++
scripts/mod/modpost.c | 3 +++
2 files changed, 10 insertions(+)
--- a/kernel/module/main.c~module-panic-taint-the-kernel-when-selftest-modules-load
+++ a/kernel/module/main.c
@@ -1988,6 +1988,13 @@ static int check_modinfo(struct module *
/* Set up license info based on the info section */
set_license(mod, get_modinfo(info, "license"));
+ if (!get_modinfo(info, "test")) {
+ if (!test_taint(TAINT_TEST))
+ pr_warn_once("%s: loading test module taints kernel.\n",
+ mod->name);
+ add_taint_module(mod, TAINT_TEST, LOCKDEP_STILL_OK);
+ }
+
return 0;
}
--- a/scripts/mod/modpost.c~module-panic-taint-the-kernel-when-selftest-modules-load
+++ a/scripts/mod/modpost.c
@@ -2191,6 +2191,9 @@ static void add_header(struct buffer *b,
if (strstarts(mod->name, "drivers/staging"))
buf_printf(b, "\nMODULE_INFO(staging, \"Y\");\n");
+
+ if (strstarts(mod->name, "tools/testing"))
+ buf_printf(b, "\nMODULE_INFO(test, \"Y\");\n");
}
static void add_exported_symbols(struct buffer *buf, struct module *mod)
_
Patches currently in -mm which might be from davidgow@google.com are
panic-taint-kernel-if-tests-are-run.patch
module-panic-taint-the-kernel-when-selftest-modules-load.patch
kunit-taint-the-kernel-when-kunit-tests-are-run.patch
selftest-taint-kernel-when-test-module-loaded.patch
next reply other threads:[~2022-07-06 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 21:23 Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-08 20:31 + module-panic-taint-the-kernel-when-selftest-modules-load.patch added to mm-nonmm-unstable branch Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706212351.2A8ECC341C6@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=atomlin@redhat.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mm-commits@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.