Re: [PATCH] btrfs: remove the inode cache check at btrfs_is_free_space_inode()

[David Sterba <dsterba@suse.cz>]

On Wed, Jul 06, 2022 at 11:14:23AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The inode cache feature was removed in kernel 5.11, and we no longer have
> any code that reads from or writes to inode caches. We may still mount a
> filesystem that has inode caches, but they are ignored.
> 
> Remove the check for an inode cache from btrfs_is_free_space_inode(),
> since we no longer have code to trigger reads from an inode cache or
> writes to an inode cache. The check at send.c is still needed, because
> in case we find a filesystem with an inode cache, we must ignore it.
> Also leave the checks at tree-checker.c, as they are sanity checks.
> 
> This eliminates a dead branch and reduces the amount of code since it's
> in an inline function.
> 
> Before:
> 
> $ size fs/btrfs/btrfs.ko
>    text	   data	    bss	    dec	    hex	filename
> 1620662	 189240	  29032	1838934	 1c0f56	fs/btrfs/btrfs.ko
> 
> After:
> 
> $ size fs/btrfs/btrfs.ko
>    text	   data	    bss	    dec	    hex	filename
> 1620502	 189240	  29032	1838774	 1c0eb6	fs/btrfs/btrfs.ko
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Added to misc-next, thanks.