From: Jakub Kicinski <kuba@kernel.org>
To: Maksym Glubokiy <maksym.glubokiy@plvision.eu>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: extract port range fields from fl_flow_key
Date: Thu, 7 Jul 2022 17:56:27 -0700 [thread overview]
Message-ID: <20220707175627.7c6fc403@kernel.org> (raw)
In-Reply-To: <20220707083539.171242-1-maksym.glubokiy@plvision.eu>
On Thu, 7 Jul 2022 11:35:38 +0300 Maksym Glubokiy wrote:
> +/**
> + * flow_dissector_key_ports_range:
> + * tp: port number from packet
> + * tp_min: min port number in range
> + * tp_max: max port number in range
> + */
This is not valid kdoc, please see
Documentation/doc-guide/kernel-doc.rst
> +struct flow_dissector_key_ports_range {
> + union {
> + struct flow_dissector_key_ports tp;
> + struct {
> + struct flow_dissector_key_ports tp_min;
> + struct flow_dissector_key_ports tp_max;
> + };
> + };
> +};
prev parent reply other threads:[~2022-07-08 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 8:35 [PATCH net-next 1/2] net: extract port range fields from fl_flow_key Maksym Glubokiy
2022-07-07 8:35 ` [PATCH net-next 2/2] net: prestera: add support for port range filters Maksym Glubokiy
2022-07-08 0:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707175627.7c6fc403@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=maksym.glubokiy@plvision.eu \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=volodymyr.mytnyk@plvision.eu \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.