All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beau Belgrave <beaub@linux.microsoft.com>
To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com
Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 1/7] tracing/user_events: Remove BROKEN and restore user_events.h location
Date: Thu,  7 Jul 2022 14:58:22 -0700	[thread overview]
Message-ID: <20220707215828.2021-2-beaub@linux.microsoft.com> (raw)
In-Reply-To: <20220707215828.2021-1-beaub@linux.microsoft.com>

After having discussions and addressing the ABI issues user_events can
be now marked as working and used by others.

As part of the BROKEN status, user_events.h was moved from its original
uapi location to the kernel location. This needs to be moved back so
it can be used by others.

Link: https://lore.kernel.org/all/20220330155835.5e1f6669@gandalf.local.home
Link: https://lkml.kernel.org/r/20220330201755.29319-1-mathieu.desnoyers@efficios.com
Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/
Link: https://lore.kernel.org/all/1651771383.54437.1652370439159.JavaMail.zimbra@efficios.com/

Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
---
 include/{ => uapi}/linux/user_events.h | 0
 kernel/trace/Kconfig                   | 1 -
 kernel/trace/trace_events_user.c       | 5 -----
 3 files changed, 6 deletions(-)
 rename include/{ => uapi}/linux/user_events.h (100%)

diff --git a/include/linux/user_events.h b/include/uapi/linux/user_events.h
similarity index 100%
rename from include/linux/user_events.h
rename to include/uapi/linux/user_events.h
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 2c43e327a619..9bb54c0b3b2d 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -767,7 +767,6 @@ config USER_EVENTS
 	bool "User trace events"
 	select TRACING
 	select DYNAMIC_EVENTS
-	depends on BROKEN || COMPILE_TEST # API needs to be straighten out
 	help
 	  User trace events are user-defined trace events that
 	  can be used like an existing kernel trace event.  User trace
diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 4afc41e321ac..7bff4c8b90f2 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -19,12 +19,7 @@
 #include <linux/tracefs.h>
 #include <linux/types.h>
 #include <linux/uaccess.h>
-/* Reminder to move to uapi when everything works */
-#ifdef CONFIG_COMPILE_TEST
-#include <linux/user_events.h>
-#else
 #include <uapi/linux/user_events.h>
-#endif
 #include "trace.h"
 #include "trace_dynevent.h"
 
-- 
2.25.1


  reply	other threads:[~2022-07-07 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 21:58 [RFC PATCH 0/7] tracing: Add tracing namespace API for user Beau Belgrave
2022-07-07 21:58 ` Beau Belgrave [this message]
2022-07-07 21:58 ` [RFC PATCH 2/7] tracing: Add namespace instance directory to tracefs Beau Belgrave
2022-07-07 21:58 ` [RFC PATCH 3/7] tracing: Add tracing namespace API for systems to register with Beau Belgrave
2022-07-07 21:58 ` [RFC PATCH 4/7] tracing/user_events: Move pages/locks into groups to prepare for namespaces Beau Belgrave
2022-07-07 21:58 ` [RFC PATCH 5/7] tracing/user_events: Register with trace namespace API Beau Belgrave
2022-07-07 21:58 ` [RFC PATCH 6/7] tracing/user_events: Enable setting event limit within namespace Beau Belgrave
2022-07-07 21:58 ` [RFC PATCH 7/7] tracing/user_events: Add self-test for namespace integration Beau Belgrave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707215828.2021-2-beaub@linux.microsoft.com \
    --to=beaub@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.