From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, borisp@nvidia.com,
john.fastabend@gmail.com, maximmi@nvidia.com, tariqt@nvidia.com,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 5/6] tls: create an internal header
Date: Fri, 8 Jul 2022 00:54:25 +0800 [thread overview]
Message-ID: <202207080041.YiP2JbIW-lkp@intel.com> (raw)
In-Reply-To: <20220707013510.1372695-6-kuba@kernel.org>
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/tls-pad-strparser-internal-header-decrypt_ctx-etc/20220707-120420
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cd355d0bc60df51266d228c0f69570cdcfa1e6ba
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220708/202207080041.YiP2JbIW-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/4088937ef16f0f7a85bc39bb89ab75b33d5e8774
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jakub-Kicinski/tls-pad-strparser-internal-header-decrypt_ctx-etc/20220707-120420
git checkout 4088937ef16f0f7a85bc39bb89ab75b33d5e8774
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/fungible/funeth/funeth_tx.c: In function 'fun_tls_tx':
>> drivers/net/ethernet/fungible/funeth/funeth_tx.c:99:25: error: implicit declaration of function 'tls_offload_tx_resync_request'; did you mean 'tls_offload_rx_resync_request'? [-Werror=implicit-function-declaration]
99 | tls_offload_tx_resync_request(skb->sk, seq,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| tls_offload_rx_resync_request
cc1: some warnings being treated as errors
--
drivers/net/ethernet/netronome/nfp/nfp_net_common.c: In function 'nfp_net_tls_tx':
>> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:636:25: error: implicit declaration of function 'tls_offload_tx_resync_request'; did you mean 'tls_offload_rx_resync_request'? [-Werror=implicit-function-declaration]
636 | tls_offload_tx_resync_request(nskb->sk, seq,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| tls_offload_rx_resync_request
cc1: some warnings being treated as errors
vim +99 drivers/net/ethernet/fungible/funeth/funeth_tx.c
db37bc177dae89c Dimitris Michailidis 2022-02-24 78
db37bc177dae89c Dimitris Michailidis 2022-02-24 79 static struct sk_buff *fun_tls_tx(struct sk_buff *skb, struct funeth_txq *q,
db37bc177dae89c Dimitris Michailidis 2022-02-24 80 unsigned int *tls_len)
db37bc177dae89c Dimitris Michailidis 2022-02-24 81 {
b23f9239195a1af Dimitris Michailidis 2022-03-08 82 #if IS_ENABLED(CONFIG_TLS_DEVICE)
db37bc177dae89c Dimitris Michailidis 2022-02-24 83 const struct fun_ktls_tx_ctx *tls_ctx;
db37bc177dae89c Dimitris Michailidis 2022-02-24 84 u32 datalen, seq;
db37bc177dae89c Dimitris Michailidis 2022-02-24 85
504148fedb85429 Eric Dumazet 2022-06-30 86 datalen = skb->len - skb_tcp_all_headers(skb);
db37bc177dae89c Dimitris Michailidis 2022-02-24 87 if (!datalen)
db37bc177dae89c Dimitris Michailidis 2022-02-24 88 return skb;
db37bc177dae89c Dimitris Michailidis 2022-02-24 89
db37bc177dae89c Dimitris Michailidis 2022-02-24 90 if (likely(!tls_offload_tx_resync_pending(skb->sk))) {
db37bc177dae89c Dimitris Michailidis 2022-02-24 91 seq = ntohl(tcp_hdr(skb)->seq);
db37bc177dae89c Dimitris Michailidis 2022-02-24 92 tls_ctx = tls_driver_ctx(skb->sk, TLS_OFFLOAD_CTX_DIR_TX);
db37bc177dae89c Dimitris Michailidis 2022-02-24 93
db37bc177dae89c Dimitris Michailidis 2022-02-24 94 if (likely(tls_ctx->next_seq == seq)) {
db37bc177dae89c Dimitris Michailidis 2022-02-24 95 *tls_len = datalen;
db37bc177dae89c Dimitris Michailidis 2022-02-24 96 return skb;
db37bc177dae89c Dimitris Michailidis 2022-02-24 97 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 98 if (seq - tls_ctx->next_seq < U32_MAX / 4) {
db37bc177dae89c Dimitris Michailidis 2022-02-24 @99 tls_offload_tx_resync_request(skb->sk, seq,
db37bc177dae89c Dimitris Michailidis 2022-02-24 100 tls_ctx->next_seq);
db37bc177dae89c Dimitris Michailidis 2022-02-24 101 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 102 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 103
db37bc177dae89c Dimitris Michailidis 2022-02-24 104 FUN_QSTAT_INC(q, tx_tls_fallback);
db37bc177dae89c Dimitris Michailidis 2022-02-24 105 skb = tls_encrypt_skb(skb);
db37bc177dae89c Dimitris Michailidis 2022-02-24 106 if (!skb)
db37bc177dae89c Dimitris Michailidis 2022-02-24 107 FUN_QSTAT_INC(q, tx_tls_drops);
db37bc177dae89c Dimitris Michailidis 2022-02-24 108
db37bc177dae89c Dimitris Michailidis 2022-02-24 109 return skb;
b23f9239195a1af Dimitris Michailidis 2022-03-08 110 #else
b23f9239195a1af Dimitris Michailidis 2022-03-08 111 return NULL;
db37bc177dae89c Dimitris Michailidis 2022-02-24 112 #endif
b23f9239195a1af Dimitris Michailidis 2022-03-08 113 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 114
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-07 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 1:35 [PATCH net-next 0/6] tls: pad strparser, internal header, decrypt_ctx etc Jakub Kicinski
2022-07-07 1:35 ` [PATCH net-next 1/6] strparser: pad sk_skb_cb to avoid straddling cachelines Jakub Kicinski
2022-07-07 1:35 ` [PATCH net-next 2/6] tls: rx: always allocate max possible aad size for decrypt Jakub Kicinski
2022-07-07 1:35 ` [PATCH net-next 3/6] tls: rx: wrap decrypt params in a struct Jakub Kicinski
2022-07-07 1:35 ` [PATCH net-next 4/6] tls: rx: coalesce exit paths in tls_decrypt_sg() Jakub Kicinski
2022-07-07 1:35 ` [PATCH net-next 5/6] tls: create an internal header Jakub Kicinski
2022-07-07 16:21 ` kernel test robot
2022-07-07 16:54 ` kernel test robot [this message]
2022-07-07 1:35 ` [PATCH net-next 6/6] tls: rx: make tls_wait_data() return an recvmsg retcode Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207080041.YiP2JbIW-lkp@intel.com \
--to=lkp@intel.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.