From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Yu Zhao <yuzhao@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
mm-commits@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzju@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Minchan Kim <minchan@kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
kernel test robot <lkp@intel.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: + mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch added to mm-unstable branch
Date: Fri, 8 Jul 2022 10:41:06 +0300 [thread overview]
Message-ID: <20220708074106.GI2316@kadam> (raw)
In-Reply-To: <44ae6dd9-c290-ae4a-15e8-593a9cb587ad@suse.cz>
On Fri, Jul 08, 2022 at 12:21:45AM +0200, Vlastimil Babka wrote:
> >> > ------------------------------------------------------
> >> > From: Andrew Morton <akpm@linux-foundation.org>
> >> > Subject: mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix
> >> > Date: Thu Jul 7 01:06:35 PM PDT 2022
> >> >
> >> > add missing local_unlock_irqrestore() on contention path
> >>
> >> Doh, that's true and something to fix, although patch 7 did remove the bug
> >> later in the same series so that wouldn't explain the lkp report for patch
> >> 7. The reason lkp test robot complained was AFAICS that it was testing v4,
> >> as I just replied there.
> >
> > Sorry I didn't bother to reply until now: it did test v5, at this
> > commit, not the whole series.
>
> I meant this report that appears to be for v4 (full series including patch 7):
> https://lore.kernel.org/all/YsFk%2FqU+QtWun04h@xsang-OptiPlex-9020/
> That reported a bug due to missing unpin that was previously reported for v4
> and fixed in v5.
>
> I'm not aware of a lkp report for v5 (found only Dan's) but yeah, hitting
> the (similar but not identical) bug fixed by this -fix would indeed be
> possible in v5 if patch 7 was not applied.
My report is the LKP report?
Some of the Smatch warnings from LKP get sent to me and then I look them
over and either delete them or hit forward. I don't have visibility
into the LKP process more than just looking over the warnings so I can't
say how it picks which patches to test off the mailing list.
regards,
dan carpenter
next prev parent reply other threads:[~2022-07-08 7:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 20:09 + mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch added to mm-unstable branch Andrew Morton
2022-07-07 21:58 ` Vlastimil Babka
2022-07-07 22:09 ` Yu Zhao
2022-07-07 22:21 ` Vlastimil Babka
2022-07-08 0:20 ` Andrew Morton
2022-07-08 0:22 ` Hugh Dickins
2022-07-08 0:35 ` Yu Zhao
2022-07-08 0:52 ` Andrew Morton
2022-07-08 0:58 ` Yu Zhao
2022-07-08 0:40 ` Andrew Morton
2022-07-08 7:41 ` Dan Carpenter [this message]
2022-07-08 9:04 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708074106.GI2316@kadam \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=vbabka@suse.cz \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.