Re: [PATCH 1/8] xfs: AIL doesn't need manual pushing

[kernel test robot <lkp@intel.com>]

Hi Dave,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Chinner/xfs-byte-base-grant-head-reservation-tracking/20220708-095642
base:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
config: parisc-randconfig-r014-20220707 (https://download.01.org/0day-ci/archive/20220708/202207081512.ZDQWNpvY-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/287b7d8ee5bd281f989fd89c40bd40d43244a3d7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dave-Chinner/xfs-byte-base-grant-head-reservation-tracking/20220708-095642
        git checkout 287b7d8ee5bd281f989fd89c40bd40d43244a3d7
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/i2c/busses/ fs/xfs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/xfs/xfs_log.c: In function 'xlog_grant_head_wake':
>> fs/xfs/xfs_log.c:237:33: warning: variable 'woken_task' set but not used [-Wunused-but-set-variable]
     237 |         bool                    woken_task = false;
         |                                 ^~~~~~~~~~


vim +/woken_task +237 fs/xfs/xfs_log.c

9f9c19ec1a59422 Christoph Hellwig 2011-11-28  228  
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  229  STATIC bool
e179840d74606ab Christoph Hellwig 2012-02-20  230  xlog_grant_head_wake(
ad223e6030be017 Mark Tinguely     2012-06-14  231  	struct xlog		*log,
e179840d74606ab Christoph Hellwig 2012-02-20  232  	struct xlog_grant_head	*head,
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  233  	int			*free_bytes)
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  234  {
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  235  	struct xlog_ticket	*tic;
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  236  	int			need_bytes;
7c107afb871a031 Dave Chinner      2019-09-05 @237  	bool			woken_task = false;
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  238  
e179840d74606ab Christoph Hellwig 2012-02-20  239  	list_for_each_entry(tic, &head->waiters, t_queue) {
e179840d74606ab Christoph Hellwig 2012-02-20  240  		need_bytes = xlog_ticket_reservation(log, head, tic);
287b7d8ee5bd281 Dave Chinner      2022-07-08  241  		if (*free_bytes < need_bytes)
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  242  			return false;
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  243  
e179840d74606ab Christoph Hellwig 2012-02-20  244  		*free_bytes -= need_bytes;
e179840d74606ab Christoph Hellwig 2012-02-20  245  		trace_xfs_log_grant_wake_up(log, tic);
14a7235fba4302a Christoph Hellwig 2012-02-20  246  		wake_up_process(tic->t_task);
7c107afb871a031 Dave Chinner      2019-09-05  247  		woken_task = true;
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  248  	}
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  249  
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  250  	return true;
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  251  }
9f9c19ec1a59422 Christoph Hellwig 2011-11-28  252  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp