From: Paulo Neves <ptsneves@gmail.com>
To: bitbake-devel@lists.openembedded.org
Cc: Paulo Neves <ptsneves@gmail.com>
Subject: [PATCH 2/2] fetch: bb.fatal when trying to checksum non-existing files.
Date: Fri, 8 Jul 2022 22:54:07 +0200 [thread overview]
Message-ID: <20220708205407.1680137-2-ptsneves@gmail.com> (raw)
In-Reply-To: <20220708205407.1680137-1-ptsneves@gmail.com>
If the local fetcher was not able to find the file anywhere but it
was included in the SRC_URI for checksumming just make it a fatal
error.
---
lib/bb/fetch2/__init__.py | 2 +-
lib/bb/tests/fetch.py | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index 5f05278a..8184b55e 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -1237,7 +1237,7 @@ def get_checksum_file_list(d):
" This means there is no way to get the file except for an orphaned copy"
" in DL_DIR.") % (d.getVar('PN'), os.path.basename(f)))
else:
- bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('PN'), os.path.basename(f)))
+ bb.fatal("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('PN'), os.path.basename(f)))
filelist.append(f + ":" + str(os.path.exists(f)))
return " ".join(filelist)
diff --git a/lib/bb/tests/fetch.py b/lib/bb/tests/fetch.py
index 3ebd9fd7..5b577b06 100644
--- a/lib/bb/tests/fetch.py
+++ b/lib/bb/tests/fetch.py
@@ -700,6 +700,11 @@ class FetcherLocalTest(FetcherTest):
with self.assertRaises(bb.BBHandledException):
bb.fetch.get_checksum_file_list(self.d)
+ def test_local_checksum_fails_no_file(self):
+ self.d.setVar("SRC_URI", "file://404")
+ with self.assertRaises(bb.BBHandledException):
+ bb.fetch.get_checksum_file_list(self.d)
+
def test_local(self):
tree = self.fetchUnpack(['file://a', 'file://dir/c'])
self.assertEqual(tree, ['a', 'dir/c'])
--
2.25.1
next prev parent reply other threads:[~2022-07-08 20:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 20:54 [PATCH 1/2] fetch2: local files only in DL_DIR becomes fatal error Paulo Neves
2022-07-08 20:54 ` Paulo Neves [this message]
2022-07-13 9:48 ` [bitbake-devel] [PATCH 2/2] fetch: bb.fatal when trying to checksum non-existing files Alexandre Belloni
2022-07-13 10:10 ` Paulo Neves
2022-07-13 12:28 ` Richard Purdie
2022-07-26 4:09 ` Patrick Williams
2022-07-26 5:35 ` [bitbake-devel] " Alexander Kanavin
2022-07-26 15:57 ` Patrick Williams
2022-07-27 12:00 ` Alexander Kanavin
2022-07-27 14:50 ` Quentin Schulz
2022-07-27 19:16 ` Patrick Williams
2022-07-26 6:39 ` Richard Purdie
2022-07-26 7:01 ` Paulo Neves
2022-07-26 16:01 ` Patrick Williams
2022-07-09 6:52 ` [bitbake-devel] [PATCH 1/2] fetch2: local files only in DL_DIR becomes fatal error Richard Purdie
2022-07-09 7:19 ` Paulo Neves
[not found] ` <a7dffab1-9b0c-fab8-a538-81c3d0065834@gmail.com>
2022-07-09 13:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708205407.1680137-2-ptsneves@gmail.com \
--to=ptsneves@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.