Re: [PATCH v4 03/69] drm/encoder: Introduce drmm_encoder_init

[kernel test robot <lkp@intel.com>]

Hi Maxime,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v5.19-rc5 next-20220708]
[cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next anholt/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-vc4-Fix-hotplug-for-vc4/20220708-181702
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-defconfig (https://download.01.org/0day-ci/archive/20220708/202207082243.30UtKZMS-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/02fc9586cd9ab6a11b41230834118acd02445e31
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Maxime-Ripard/drm-vc4-Fix-hotplug-for-vc4/20220708-181702
        git checkout 02fc9586cd9ab6a11b41230834118acd02445e31
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/drm_encoder.c: In function '__drmm_encoder_init':
>> drivers/gpu/drm/drm_encoder.c:228:9: warning: function '__drmm_encoder_init' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     228 |         ret = __drm_encoder_init(dev, encoder, funcs, encoder_type, name, args);
         |         ^~~


vim +228 drivers/gpu/drm/drm_encoder.c

   215	
   216	static int __drmm_encoder_init(struct drm_device *dev,
   217				       struct drm_encoder *encoder,
   218				       const struct drm_encoder_funcs *funcs,
   219				       int encoder_type,
   220				       const char *name,
   221				       va_list args)
   222	{
   223		int ret;
   224	
   225		if (drm_WARN_ON(dev, funcs && funcs->destroy))
   226			return -EINVAL;
   227	
 > 228		ret = __drm_encoder_init(dev, encoder, funcs, encoder_type, name, args);
   229		if (ret)
   230			return ret;
   231	
   232		ret = drmm_add_action_or_reset(dev, drmm_encoder_alloc_release, encoder);
   233		if (ret)
   234			return ret;
   235	
   236		return 0;
   237	}
   238	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp