All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Troy Kisky <troy.kisky@boundarydevices.com>,
	Joe Hershberger <joe.hershberger@ni.com>,
	Wolfgang Denk <wd@denx.de>, Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: [PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig
Date: Sun, 10 Jul 2022 13:42:56 +0200	[thread overview]
Message-ID: <20220710114256.27322-2-pali@kernel.org> (raw)
In-Reply-To: <20220710114256.27322-1-pali@kernel.org>

CONFIG_PREBOOT just cause putting "preboot=CONFIG_PREBOOT" into env list.
Value CONFIG_PREBOOT="run preboot" in defconfig is just nonsense and does
not do anything useful (it is infinite recursion). Config file for this
board already contains default preboot= env variable with correct value,
which has higher priority than CONFIG_PREBOOT and this is reason why
nonsense CONFIG_PREBOOT is ignored.

Remove nonsense and unused CONFIG_PREBOOT from nokia_rx51_defconfig file.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 configs/nokia_rx51_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig
index 309cf28269c1..46b794f168d9 100644
--- a/configs/nokia_rx51_defconfig
+++ b/configs/nokia_rx51_defconfig
@@ -24,7 +24,6 @@ CONFIG_AUTOBOOT_MENU_SHOW=y
 CONFIG_USE_BOOTCOMMAND=y
 CONFIG_BOOTCOMMAND="run sdboot;run emmcboot;run attachboot;echo"
 CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="run preboot"
 # CONFIG_SYS_DEVICE_NULLDEV is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_SYS_PROMPT="Nokia RX-51 # "
-- 
2.20.1


  reply	other threads:[~2022-07-10 11:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 11:42 [PATCH 1/2] Fix usage of CONFIG_PREBOOT Pali Rohár
2022-07-10 11:42 ` Pali Rohár [this message]
2022-07-11 23:23   ` [PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig Tom Rini
2022-07-12  8:11     ` Pali Rohár
2022-07-12 21:39       ` Tom Rini
2022-07-12 21:52         ` Pali Rohár
2022-07-12 22:58           ` Tom Rini
2022-07-12 23:11             ` Pali Rohár
2022-07-12 23:15               ` Tom Rini
2022-07-13  8:36                 ` Pali Rohár
2022-07-25 21:21   ` Tom Rini
2022-07-27 18:34     ` Pali Rohár
2022-07-27 18:48       ` Tom Rini
2022-07-27 18:52         ` Pali Rohár
2022-07-27 18:58           ` Tom Rini
2022-07-27 19:01             ` Pali Rohár
2022-07-27 19:08               ` Tom Rini
2022-10-09 13:03                 ` Pali Rohár
2022-11-01 22:58                   ` Pali Rohár
2022-11-01 23:29                     ` Tom Rini
2022-11-20 16:37                       ` Pali Rohár
2022-07-12 10:58 ` [PATCH 1/2] Fix usage of CONFIG_PREBOOT Simon Glass
2022-07-12 11:18   ` Pali Rohár
2022-11-21 17:33 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220710114256.27322-2-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=joe.hershberger@ni.com \
    --cc=sjg@chromium.org \
    --cc=troy.kisky@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.