From: Jason Gunthorpe <jgg@nvidia.com>
To: Shiraz Saleem <shiraz.saleem@intel.com>
Cc: linux-rdma@vger.kernel.org, Mustafa Ismail <mustafa.ismail@intel.com>
Subject: Re: [PATCH for-rc] RDMA/irdma: Fix sleep from invalid context BUG
Date: Mon, 11 Jul 2022 03:13:58 -0300 [thread overview]
Message-ID: <20220711061358.GB56430@nvidia.com> (raw)
In-Reply-To: <20220705230837.294-2-shiraz.saleem@intel.com>
On Tue, Jul 05, 2022 at 06:08:37PM -0500, Shiraz Saleem wrote:
> From: Mustafa Ismail <mustafa.ismail@intel.com>
>
> Taking the qos_mutex to process RoCEv2 QP's on netdev events causes a
> kernel splat.
>
> Fix this by removing the handling for RoCEv2 in
> irdma_cm_teardown_connections that uses the mutex. This handling is only
> needed for iWARP to avoid having connections established while the link
> is down or having connections remain functional after the IP address is
> removed.
>
> BUG: sleeping function called from invalid context at kernel/locking/mutex.
> Call Trace:
> kernel: dump_stack+0x66/0x90
> kernel: ___might_sleep.cold.92+0x8d/0x9a
> kernel: mutex_lock+0x1c/0x40
> kernel: irdma_cm_teardown_connections+0x28e/0x4d0 [irdma]
> kernel: ? check_preempt_curr+0x7a/0x90
> kernel: ? select_idle_sibling+0x22/0x3c0
> kernel: ? select_task_rq_fair+0x94c/0xc90
> kernel: ? irdma_exec_cqp_cmd+0xc27/0x17c0 [irdma]
> kernel: ? __wake_up_common+0x7a/0x190
> kernel: irdma_if_notify+0x3cc/0x450 [irdma]
> kernel: ? sched_clock_cpu+0xc/0xb0
> kernel: irdma_inet6addr_event+0xc6/0x150 [irdma]
>
> Fixes: 146b9756f14c ("RDMA/irdma: Add connection manager")
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/cm.c | 50 ----------------------------------------
> 1 file changed, 50 deletions(-)
Applied to for-rc, thanks
Jason
next prev parent reply other threads:[~2022-07-11 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 23:08 [PATCH for-rc] RDMA/irdma: Do not advertise 1GB page size for x722 Shiraz Saleem
2022-07-05 23:08 ` [PATCH for-rc] RDMA/irdma: Fix sleep from invalid context BUG Shiraz Saleem
2022-07-11 6:13 ` Jason Gunthorpe [this message]
2022-07-11 6:13 ` [PATCH for-rc] RDMA/irdma: Do not advertise 1GB page size for x722 Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711061358.GB56430@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.