Re: [PATCH v4 2/2] add tas2780

[Rob Herring <robh@kernel.org>]

On Thu, Jul 07, 2022 at 08:33:43PM +0800, Raphael-Xu wrote:
> add tas2780.yaml

I see this is already in linux-next, and it has a warning:

Documentation/devicetree/bindings/sound/tas2780.example.dtb: codec@38: 'shutdown-gpios' does not match any of the regexes: 'pinctrl-[0-9]+'
	From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/tas2780.yaml

Please send a fix for this and the comments below.

No checks ran and no review happened because the DT list was not Cc'ed. 
Please use get_maintainers.pl for where to send patches.

Also the subjects need some work. Use 'git log --oneline <path>' for a 
idea of what the subject should start with. I imagine Mark fixed it for 
you.

> 
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
>  .../devicetree/bindings/sound/tas2780.yaml    | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/tas2780.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas2780.yaml b/Documentation/devicetree/bindings/sound/tas2780.yaml
> new file mode 100644
> index 000000000000..5a0de0995066
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tas2780.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2020-2022 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/sound/tas2780.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Texas Instruments TAS2780 Smart PA
> +
> +maintainers:
> +  - Raphael Xu <raphael-xu@ti.com>
> +
> +description: |
> +  The TAS2780 is a mono, digital input Class-D audio amplifier optimized for
> +  efficiently driving high peak power into small loudspeakers.
> +  Integrated speaker voltage and current sense provides for
> +  real time monitoring of loudspeaker behavior.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tas2780
> +
> +  reg:
> +    maxItems: 1
> +    description: |
> +       I2C address of the device can be between 0x38 to 0x45.

Can be constraints instead:

items:
  - items:
      - minimum: 0x38
        maximum: 0x45

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: GPIO used to reset the device.
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ti,imon-slot-no:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TDM TX current sense time slot.

constraints? 0 - 2^32 is valid?

> +
> +  ti,vmon-slot-no:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TDM TX voltage sense time slot.
> +
> +  '#sound-dai-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +   #include <dt-bindings/gpio/gpio.h>
> +   i2c0 {
> +     #address-cells = <1>;
> +     #size-cells = <0>;
> +     codec: codec@38 {
> +       compatible = "ti,tas2780";
> +       reg = <0x38>;
> +       #sound-dai-cells = <1>;
> +       interrupt-parent = <&gpio1>;
> +       interrupts = <14>;
> +       reset-gpios = <&gpio1 15 0>;
> +       shutdown-gpios = <&gpio1 15 0>;
> +       ti,imon-slot-no = <0>;
> +       ti,vmon-slot-no = <2>;
> +     };
> +   };
> +
> +...
> -- 
> 2.35.1
> 
> 
>