From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 12 Jul 2022 06:57:19 +0200 Subject: [Cluster-devel] [PATCH 2/4] gfs2: remove ->writepage In-Reply-To: References: <20220711041459.1062583-1-hch@lst.de> <20220711041459.1062583-3-hch@lst.de> Message-ID: <20220712045719.GA4705@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jul 12, 2022 at 01:22:48AM +0200, Andreas Gr?nbacher wrote: > It should be possible to remove the .writepage operation in > gfs2_jdata_aops as well, but I must be overlooking something because > that actually breaks things. We'll need to wire up ->migratepage for it first to not lose any memory migration functinality. But yes, the plan is to eventually kill off ->writepage. If I can get you to look into gfs2_jdata_aops, gfs2_meta_aops and gfs2_rgrp_aops, that would be awesome. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF582C43334 for ; Tue, 12 Jul 2022 04:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiGLE5Y (ORCPT ); Tue, 12 Jul 2022 00:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbiGLE5Y (ORCPT ); Tue, 12 Jul 2022 00:57:24 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 050387D7B4; Mon, 11 Jul 2022 21:57:22 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 38CBF68AA6; Tue, 12 Jul 2022 06:57:19 +0200 (CEST) Date: Tue, 12 Jul 2022 06:57:19 +0200 From: Christoph Hellwig To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= Cc: Christoph Hellwig , Bob Peterson , Andreas Gruenbacher , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , cluster-devel , linux-xfs , Linux FS-devel Mailing List Subject: Re: [PATCH 2/4] gfs2: remove ->writepage Message-ID: <20220712045719.GA4705@lst.de> References: <20220711041459.1062583-1-hch@lst.de> <20220711041459.1062583-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Jul 12, 2022 at 01:22:48AM +0200, Andreas Grünbacher wrote: > It should be possible to remove the .writepage operation in > gfs2_jdata_aops as well, but I must be overlooking something because > that actually breaks things. We'll need to wire up ->migratepage for it first to not lose any memory migration functinality. But yes, the plan is to eventually kill off ->writepage. If I can get you to look into gfs2_jdata_aops, gfs2_meta_aops and gfs2_rgrp_aops, that would be awesome.