From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0563CC433EF for ; Tue, 12 Jul 2022 12:30:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 71AB260EC8; Tue, 12 Jul 2022 12:30:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 71AB260EC8 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PWFn4lTd X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89tOKrFRMpDp; Tue, 12 Jul 2022 12:30:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id E6DE860A6B; Tue, 12 Jul 2022 12:30:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E6DE860A6B Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AB244C0033; Tue, 12 Jul 2022 12:30:39 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 02C16C002D for ; Tue, 12 Jul 2022 12:30:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D080860BFB for ; Tue, 12 Jul 2022 12:30:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D080860BFB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WynzmugjUuGt for ; Tue, 12 Jul 2022 12:30:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BB1B060A6B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id BB1B060A6B for ; Tue, 12 Jul 2022 12:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657629034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ozgUhvIWKASvsf5a+WUmynagIG9hnmSOEkRHQEhJ0I=; b=PWFn4lTdzz3jW2FJ7ylmabNyNr6rmAG6nXvDRHOXYie1XziDK0KjJrb+jrwyCbpIG4Mtpw Ro0+cYIzqUfiIfD7HZv3jitZNLZaxATk0gOEX0r2cT/iqe8IFFPzJEgyE33O9+dUyzC5R4 mqNpvTyYA9QL+ADvw8DfCN2qwFQUwvE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-414-eSXD1qowP0So1wWOtkQzBA-1; Tue, 12 Jul 2022 08:30:32 -0400 X-MC-Unique: eSXD1qowP0So1wWOtkQzBA-1 Received: by mail-wm1-f69.google.com with SMTP id bg6-20020a05600c3c8600b003a03d5d19e4so3703233wmb.1 for ; Tue, 12 Jul 2022 05:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8ozgUhvIWKASvsf5a+WUmynagIG9hnmSOEkRHQEhJ0I=; b=F5mTDC+AxLCO7TMqQFvN4N39If9+B8TTC4M78DOC6Cl4z/mS9/PCVntz+8kxzBjWiI BWSU2iGJ+XbE8islDxvZWlnlNhgQsONCzrAXiTqNXe0ernZYyPmBg5dy78u/NtoBcyld ZW604D5PovP8z3gbi10dl8T9L/aolusEzjJC5KfDo+Fe6i/JOwDRVVhsHpwfugSZ6C+y 3TPoNxMU9PVJ0femi9hpnEXJsjGikxiQARg9hQDxenbPclLTvoc49WPgTJppSzVcpoK8 l0VOPHLZdzFQ7k5m/gtcfKL2iGuYBzry26p8MEiGAvX+1Y2COyDEpKtxJRRgBt3KdSi0 nzFQ== X-Gm-Message-State: AJIora9R5GTdUQHY8IVn0oFoyp+l/unLRDZ4cgpCLNFsnka9YJK96WkS RbacKq7b8zTwzyY3zIvJjp97t2f7VxJtC5Q9T3/cy4CitH2zlPsVj6eiIFwwrHOsXY2eNhEQOVR pbQsi7hKNxkl3FKSCFcSkCNTYNcuXnL+Fqc2jE9ilrw== X-Received: by 2002:adf:c6c1:0:b0:21d:976e:6e87 with SMTP id c1-20020adfc6c1000000b0021d976e6e87mr15888244wrh.140.1657629031445; Tue, 12 Jul 2022 05:30:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tWGX4QWbrSslFM8amOOZY3A7QRzMxODKWapi8+CUV0gLy4qUHfsp5AT5HZp7ImMobcuttpmA== X-Received: by 2002:adf:c6c1:0:b0:21d:976e:6e87 with SMTP id c1-20020adfc6c1000000b0021d976e6e87mr15888222wrh.140.1657629031178; Tue, 12 Jul 2022 05:30:31 -0700 (PDT) Received: from redhat.com ([2.52.24.42]) by smtp.gmail.com with ESMTPSA id k1-20020a05600c0b4100b003a2d45472b6sm12627225wmr.28.2022.07.12.05.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 05:30:30 -0700 (PDT) Date: Tue, 12 Jul 2022 08:30:27 -0400 From: "Michael S. Tsirkin" To: Peng Fan Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef Message-ID: <20220712083021-mutt-send-email-mst@kernel.org> References: <20220411014039.3368218-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: linux-kernel , virtualization X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" V2lsbCBkby4KCk9uIFR1ZSwgSnVsIDEyLCAyMDIyIGF0IDA0OjU5OjQ0QU0gKzAwMDAsIFBlbmcg RmFuIHdyb3RlOgo+ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gdG9vbHMvdmlydGlvOiBkcm9wIHBo eXNfYWRkcl90IHR5cGVkZWYKPiAKPiBXb3VsZCBhbnlvbmUgcGljayB1cCB0aGlzIHBhdGNoPyBP ciBhbnkgY29tbWVudHM/Cj4gCj4gVGhhbmtzLAo+IFBlbmcuCj4gCj4gPiAKPiA+IE9uIE1vbiwg QXByIDExLCAyMDIyIGF0IDk6MzkgQU0gUGVuZyBGYW4gKE9TUykgPHBlbmcuZmFuQG9zcy5ueHAu Y29tPgo+ID4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEZyb206IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAu Y29tPgo+ID4gPgo+ID4gPiBXaXRoIGNvbW1pdCA4ODRlZTFlNTg1Y2EgKCJ0b29scy9pbmNsdWRl OiBBZGQgcGh5c19hZGRyX3QgdG8KPiA+ID4gdHlwZXMuaCIpLAo+ID4gPgo+ID4gPiBXaGVuIGJ1 aWxkaW5nIHZpcnRpbyB0b29scywgdGhlcmUgaXMgYSB0eXBlIGNvbmZpY3RpbmcgZXJyb3I6Cj4g PiA+Cj4gPiA+ICIKPiA+ID4gLi9saW51eC9rZXJuZWwuaDozMjoyODogZXJyb3I6IGNvbmZsaWN0 aW5nIHR5cGVzIGZvciDigJhwaHlzX2FkZHJfdOKAmQo+ID4gPiAgICAzMiB8IHR5cGVkZWYgdW5z aWduZWQgbG9uZyBsb25nIHBoeXNfYWRkcl90Owo+ID4gPiAgICAgICB8ICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF5+fn5+fn5+fn5+Cj4gPiA+IEluIGZpbGUgaW5jbHVkZWQgZnJvbSAvdXNy L2luY2x1ZGUvbGludXgvdmlydGlvX2Jsay5oOjI4LAo+ID4gPiAgICAgICAgICAgICAgICAgIGZy b20gdmlydGlvLWl2c2htZW0tYmxvY2suYzoyOToKPiA+ID4gLi4vaW5jbHVkZS9saW51eC90eXBl cy5oOjY5OjEzOiBub3RlOiBwcmV2aW91cyBkZWNsYXJhdGlvbiBvZiDigJhwaHlzX2FkZHJfdOKA mQo+ID4gd2FzIGhlcmUKPiA+ID4gICAgNjkgfCB0eXBlZGVmIHUzMiBwaHlzX2FkZHJfdDsKPiA+ ID4gICAgICAgfCAgICAgICAgICAgICBefn5+fn5+fn5+fgo+ID4gPiAiCj4gPiA+Cj4gPiA+IExl dCdzIGRyb3AgdGhlIHR5cGVkZWYgaW4gdG9vbHMvdmlydGlvL2xpbnV4L2tlcm5lbC5oCj4gPiA+ Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29tPgo+ID4gCj4g PiBBY2tlZC1ieTogSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KPiA+IAo+ID4gPiAt LS0KPiA+ID4gIHRvb2xzL3ZpcnRpby9saW51eC9rZXJuZWwuaCB8IDEgLQo+ID4gPiAgMSBmaWxl IGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL3Rvb2xzL3Zp cnRpby9saW51eC9rZXJuZWwuaCBiL3Rvb2xzL3ZpcnRpby9saW51eC9rZXJuZWwuaAo+ID4gPiBp bmRleCAwYjQ5MzU0MmU2MWEuLjFkMzI0OGUzZjI3MCAxMDA2NDQKPiA+ID4gLS0tIGEvdG9vbHMv dmlydGlvL2xpbnV4L2tlcm5lbC5oCj4gPiA+ICsrKyBiL3Rvb2xzL3ZpcnRpby9saW51eC9rZXJu ZWwuaAo+ID4gPiBAQCAtMjksNyArMjksNiBAQAo+ID4gPiAgI2RlZmluZSBSRUFEICAgICAgICAg ICAgICAgICAgICAwCj4gPiA+ICAjZGVmaW5lIFdSSVRFICAgICAgICAgICAgICAgICAgIDEKPiA+ ID4KPiA+ID4gLXR5cGVkZWYgdW5zaWduZWQgbG9uZyBsb25nIHBoeXNfYWRkcl90OyAgdHlwZWRl ZiB1bnNpZ25lZCBsb25nIGxvbmcKPiA+ID4gZG1hX2FkZHJfdDsgIHR5cGVkZWYgc2l6ZV90IF9f a2VybmVsX3NpemVfdDsgIHR5cGVkZWYgdW5zaWduZWQgaW50Cj4gPiA+IF9fd3N1bTsKPiA+ID4g LS0KPiA+ID4gMi4yNS4xCj4gPiA+Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRp b25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRp b24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCA6C43334 for ; Tue, 12 Jul 2022 12:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbiGLMak (ORCPT ); Tue, 12 Jul 2022 08:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbiGLMag (ORCPT ); Tue, 12 Jul 2022 08:30:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8C4B22E6A5 for ; Tue, 12 Jul 2022 05:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657629034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ozgUhvIWKASvsf5a+WUmynagIG9hnmSOEkRHQEhJ0I=; b=PWFn4lTdzz3jW2FJ7ylmabNyNr6rmAG6nXvDRHOXYie1XziDK0KjJrb+jrwyCbpIG4Mtpw Ro0+cYIzqUfiIfD7HZv3jitZNLZaxATk0gOEX0r2cT/iqe8IFFPzJEgyE33O9+dUyzC5R4 mqNpvTyYA9QL+ADvw8DfCN2qwFQUwvE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-oSLTrZLvMt-_wvCVmOi4Og-1; Tue, 12 Jul 2022 08:30:33 -0400 X-MC-Unique: oSLTrZLvMt-_wvCVmOi4Og-1 Received: by mail-wr1-f70.google.com with SMTP id q12-20020adfab0c000000b0021d6dcb51e8so1364459wrc.13 for ; Tue, 12 Jul 2022 05:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8ozgUhvIWKASvsf5a+WUmynagIG9hnmSOEkRHQEhJ0I=; b=BmeC43rru6yynW6bCGh0a5hplXa9AJPVl1ue0NG7v/GI73nTmzMAxpddtyZXCR2sci 4kO1ivUxff4jV1tL2qzUbB1FQiRxRHHJ4x6zCc4zPtWdQEgTmBVbUkItgdNRofN9gmQT ylekWXeT8sJVFNr9pl8G509J5ClHRNoWLaG/6I3Qf8wcm++NE71MXwViSm7EyrcUPuWz g5Pbx5U59tGKFNj4yNgM0kMBk8H8vq7cYmdH7WDPm1zPWSGeBY9QAleRgoY+M23KAsEN m0TTIWom+FvpDmW5ftNiW6tFDmb5GW2PltvIssmNHQ48kp8nqzVNNchz35seNW04Purt SJ0w== X-Gm-Message-State: AJIora/0zU74XIfOeMGe6M9t8x9cYdVyTBMinlzlIS/cqEAUyKiBmLUo D0mHJsh2KsS2yBrD6WRc8Jr1gO9usv1GI1ynQXCLMcMzvLCZmXnS2U96Nm4ZDBWy30d3H5vAEtC l9tCI0y8hV5dLzj5fJcXZaCcE X-Received: by 2002:adf:c6c1:0:b0:21d:976e:6e87 with SMTP id c1-20020adfc6c1000000b0021d976e6e87mr15888245wrh.140.1657629031445; Tue, 12 Jul 2022 05:30:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tWGX4QWbrSslFM8amOOZY3A7QRzMxODKWapi8+CUV0gLy4qUHfsp5AT5HZp7ImMobcuttpmA== X-Received: by 2002:adf:c6c1:0:b0:21d:976e:6e87 with SMTP id c1-20020adfc6c1000000b0021d976e6e87mr15888222wrh.140.1657629031178; Tue, 12 Jul 2022 05:30:31 -0700 (PDT) Received: from redhat.com ([2.52.24.42]) by smtp.gmail.com with ESMTPSA id k1-20020a05600c0b4100b003a2d45472b6sm12627225wmr.28.2022.07.12.05.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 05:30:30 -0700 (PDT) Date: Tue, 12 Jul 2022 08:30:27 -0400 From: "Michael S. Tsirkin" To: Peng Fan Cc: Jason Wang , virtualization , linux-kernel Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef Message-ID: <20220712083021-mutt-send-email-mst@kernel.org> References: <20220411014039.3368218-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will do. On Tue, Jul 12, 2022 at 04:59:44AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef > > Would anyone pick up this patch? Or any comments? > > Thanks, > Peng. > > > > > On Mon, Apr 11, 2022 at 9:39 AM Peng Fan (OSS) > > wrote: > > > > > > From: Peng Fan > > > > > > With commit 884ee1e585ca ("tools/include: Add phys_addr_t to > > > types.h"), > > > > > > When building virtio tools, there is a type conficting error: > > > > > > " > > > ./linux/kernel.h:32:28: error: conflicting types for ‘phys_addr_t’ > > > 32 | typedef unsigned long long phys_addr_t; > > > | ^~~~~~~~~~~ > > > In file included from /usr/include/linux/virtio_blk.h:28, > > > from virtio-ivshmem-block.c:29: > > > ../include/linux/types.h:69:13: note: previous declaration of ‘phys_addr_t’ > > was here > > > 69 | typedef u32 phys_addr_t; > > > | ^~~~~~~~~~~ > > > " > > > > > > Let's drop the typedef in tools/virtio/linux/kernel.h > > > > > > Signed-off-by: Peng Fan > > > > Acked-by: Jason Wang > > > > > --- > > > tools/virtio/linux/kernel.h | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h > > > index 0b493542e61a..1d3248e3f270 100644 > > > --- a/tools/virtio/linux/kernel.h > > > +++ b/tools/virtio/linux/kernel.h > > > @@ -29,7 +29,6 @@ > > > #define READ 0 > > > #define WRITE 1 > > > > > > -typedef unsigned long long phys_addr_t; typedef unsigned long long > > > dma_addr_t; typedef size_t __kernel_size_t; typedef unsigned int > > > __wsum; > > > -- > > > 2.25.1 > > > >