From: "Marek Behún" <kabel@kernel.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
T Karthik Reddy <t.karthik.reddy@xilinx.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
Michal Simek <michal.simek@amd.com>,
Nate Drude <nate.d@variscite.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] net: phy: possible NULL dereference in fixed_phy_create()
Date: Tue, 12 Jul 2022 12:49:27 +0200 [thread overview]
Message-ID: <20220712124927.55bb49bf@thinkpad> (raw)
In-Reply-To: <20220711174013.116975-1-heinrich.schuchardt@canonical.com>
On Mon, 11 Jul 2022 19:40:13 +0200
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> We check if phydev is NULL. Only but if it is non-NULL we set one
> component of phydev. But even if it is NULL we set another. We should not
> dereference NULL in either case.
>
> Fixes: e24b58f5ed4f ("net: phy: don't require PHY interface mode during PHY creation")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2022-07-12 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 17:40 [PATCH 1/1] net: phy: possible NULL dereference in fixed_phy_create() Heinrich Schuchardt
2022-07-12 10:49 ` Marek Behún [this message]
2022-08-08 19:08 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712124927.55bb49bf@thinkpad \
--to=kabel@kernel.org \
--cc=ariel.dalessandro@collabora.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=joe.hershberger@ni.com \
--cc=michal.simek@amd.com \
--cc=nate.d@variscite.com \
--cc=rfried.dev@gmail.com \
--cc=t.karthik.reddy@xilinx.com \
--cc=u-boot@lists.denx.de \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.