From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2708BC43334 for ; Tue, 12 Jul 2022 18:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233395AbiGLSGo (ORCPT ); Tue, 12 Jul 2022 14:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbiGLSGm (ORCPT ); Tue, 12 Jul 2022 14:06:42 -0400 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 878DCAE553; Tue, 12 Jul 2022 11:06:36 -0700 (PDT) Received: by mail-il1-f177.google.com with SMTP id a20so5321208ilk.9; Tue, 12 Jul 2022 11:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YtzP7I40RQyEUjKbXHB73J4wJHJ46s1Pzo+UKJfysDc=; b=50V9cYcO9thGrAX5MUBBL5TTQfHJW20x4pvbSIrcJuQfwnWNPJEpl14/9aPDo1/yNH 4nu6rTI2EyeJk3jO+SDn+NrbA0pS2m29ieOCzhxbNDqlTObzXDx7o2ulVu8P1aFJjHpU NDQ3WW1dhOnE1Z1Syd5Ic5zylwS0sgrg72aPSdCpa51E+5yKhLsJ2WFUFwi7SjDK8doE i82jl4mb+F0Y1MpvOIt9iy3rk8S5Z90ZCka6SkiinzuRSKaUFA35qQDVnMORLX9tE5eL w1UxstMGv7J1uUJcnEf4HH+jaNtVCdEROYRs/ZBtnNRWaSSVjN/RlP5Q+wrv2DjLMXjB n12Q== X-Gm-Message-State: AJIora8x8LhOYdYYjyDvV15wjZaOWO5O0xEwEmg4hJAX2z6unW1+gLWG k9NIYlD7VVNHX011LAruNA== X-Google-Smtp-Source: AGRyM1uQj9XqR1H/j1xEWpea/Q+tQa2PKHOSbgCLwSEg/z123utZodWxiVGVv4vw8BKVxtlj/J0DYg== X-Received: by 2002:a05:6e02:154d:b0:2dc:6324:e1be with SMTP id j13-20020a056e02154d00b002dc6324e1bemr11287953ilu.47.1657649195773; Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id cq7-20020a056638478700b0033f21999e6csm4389983jab.90.2022.07.12.11.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: (nullmailer pid 2112717 invoked by uid 1000); Tue, 12 Jul 2022 18:06:32 -0000 Date: Tue, 12 Jul 2022 12:06:32 -0600 From: Rob Herring To: Rex-BC Chen Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, mripard@kernel.org, tzimmermann@suse.de, matthias.bgg@gmail.com, deller@gmx.de, airlied@linux.ie, msp@baylibre.com, granquet@baylibre.com, jitao.shi@mediatek.com, wenst@chromium.org, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, liangxu.xu@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v13 01/10] dt-bindings: mediatek,dp: Add Display Port binding Message-ID: <20220712180632.GH1823936-robh@kernel.org> References: <20220701062808.18596-1-rex-bc.chen@mediatek.com> <20220701062808.18596-2-rex-bc.chen@mediatek.com> <20220701202914.GA1457156-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Jul 05, 2022 at 05:40:27PM +0800, Rex-BC Chen wrote: > On Fri, 2022-07-01 at 14:29 -0600, Rob Herring wrote: > > On Fri, Jul 01, 2022 at 02:27:59PM +0800, Bo-Chen Chen wrote: > > > From: Markus Schneider-Pargmann > > > > > > This controller is present on several mediatek hardware. Currently > > > mt8195 and mt8395 have this controller without a functional > > > difference, > > > so only one compatible field is added. > > > > > > The controller can have two forms, as a normal display port and as > > > an > > > embedded display port. > > > > I'm sure you answered this before, but I'll keep asking until the > > information is contained within this patch. Otherwise, I won't > > remember. > > Is there a h/w difference in the 2 blocks? Different registers? Why > > can't you just look at what the output is connected to? > > > > Hello Rob, > > Thanks for your review. > Yes, it's two different hw for edp and dp and they have different > registers base address. Multiple instances *always* have different base addresses. That's not a difference. I probably asked before on what the difference is between edp and dp variants if anything? If the blocks have some difference then, different compatibles makes sense. But you need to explain the difference or I'll just be asking again... Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B28BC43334 for ; Tue, 12 Jul 2022 18:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3j/74kyLZk3n60uoPDOt4v2Mf5Ry5RmOl/ZhDyesWoM=; b=No8lm+gNEasfK1 KVo3kOIJlUmoNJJtyVghmDWnA86J42eFGp0JuqdyJjYexv53eFqUjHiEgeJB4gapVwXNsVFx1HKGm r/WLSnAiEnuMkp8HRuB/xuaQgx7u1+fUCpc4uzgfOAvt4OooA9mwzY1F5fzlu883cMWUF8gmvgr18 u/g//wARgWJS20v2hayw8NUsPqG6w489VWedvJuSYUUPPXg+tFU5U4k1PtFqporLXqHps4sGtI9uh wgdR990mHj0xuJr61ppyCLvZzL6W1+Je1pF9l4brC5x5hUdhwY7EBH57QH6RObAAoRnEZZ7xN3103 I6c22rICMgAaRaS466Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBKHQ-00Db0k-Qb; Tue, 12 Jul 2022 18:06:40 +0000 Received: from mail-il1-f176.google.com ([209.85.166.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBKHN-00DazQ-04; Tue, 12 Jul 2022 18:06:38 +0000 Received: by mail-il1-f176.google.com with SMTP id p13so5351997ilq.0; Tue, 12 Jul 2022 11:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YtzP7I40RQyEUjKbXHB73J4wJHJ46s1Pzo+UKJfysDc=; b=qrPQiVC+CnSRdGrZFCAaOyHgeOPwrqwFVfNRQtqMAI5+yTptz2Rt+v4aTuQCPjJUvp D4eOwsbikPD/e6nM8wY7sTtfwlMjeJgP5hzz00IITmNDzDlqweNEodg62lpVDxS65weo xECd3vNxWVu1IgQ1fym0EWFu/BY9rVlxbQnYS+fDsYJrKPUz3nwPlhSKuayP7o29bvf7 clWkxdfy5e28i2Cof0EbMDnwHLDkoHDZsabfaoRQmdTo9Iv1nPFA25JwJXHzWwFXQXAn REym8TaUjju7Z8WJiWOhUHze2H6A8rItm6OpQ9lnlBkOUgF9y2OItaintHg8kOZ85ltF wzaA== X-Gm-Message-State: AJIora87HoXJ+G0qVMp96cx08nH+wbW/9LpNfyFHJBgljIX8Wj4rQVYb iPYrf5rjUGY66z9Q6LD7dA== X-Google-Smtp-Source: AGRyM1uQj9XqR1H/j1xEWpea/Q+tQa2PKHOSbgCLwSEg/z123utZodWxiVGVv4vw8BKVxtlj/J0DYg== X-Received: by 2002:a05:6e02:154d:b0:2dc:6324:e1be with SMTP id j13-20020a056e02154d00b002dc6324e1bemr11287953ilu.47.1657649195773; Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id cq7-20020a056638478700b0033f21999e6csm4389983jab.90.2022.07.12.11.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: (nullmailer pid 2112717 invoked by uid 1000); Tue, 12 Jul 2022 18:06:32 -0000 Date: Tue, 12 Jul 2022 12:06:32 -0600 From: Rob Herring To: Rex-BC Chen Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, mripard@kernel.org, tzimmermann@suse.de, matthias.bgg@gmail.com, deller@gmx.de, airlied@linux.ie, msp@baylibre.com, granquet@baylibre.com, jitao.shi@mediatek.com, wenst@chromium.org, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, liangxu.xu@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v13 01/10] dt-bindings: mediatek,dp: Add Display Port binding Message-ID: <20220712180632.GH1823936-robh@kernel.org> References: <20220701062808.18596-1-rex-bc.chen@mediatek.com> <20220701062808.18596-2-rex-bc.chen@mediatek.com> <20220701202914.GA1457156-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_110637_053838_EAC8C663 X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 05, 2022 at 05:40:27PM +0800, Rex-BC Chen wrote: > On Fri, 2022-07-01 at 14:29 -0600, Rob Herring wrote: > > On Fri, Jul 01, 2022 at 02:27:59PM +0800, Bo-Chen Chen wrote: > > > From: Markus Schneider-Pargmann > > > > > > This controller is present on several mediatek hardware. Currently > > > mt8195 and mt8395 have this controller without a functional > > > difference, > > > so only one compatible field is added. > > > > > > The controller can have two forms, as a normal display port and as > > > an > > > embedded display port. > > > > I'm sure you answered this before, but I'll keep asking until the > > information is contained within this patch. Otherwise, I won't > > remember. > > Is there a h/w difference in the 2 blocks? Different registers? Why > > can't you just look at what the output is connected to? > > > > Hello Rob, > > Thanks for your review. > Yes, it's two different hw for edp and dp and they have different > registers base address. Multiple instances *always* have different base addresses. That's not a difference. I probably asked before on what the difference is between edp and dp variants if anything? If the blocks have some difference then, different compatibles makes sense. But you need to explain the difference or I'll just be asking again... Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 806CEC433EF for ; Tue, 12 Jul 2022 18:06:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E25FE95A19; Tue, 12 Jul 2022 18:06:37 +0000 (UTC) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B24095A17 for ; Tue, 12 Jul 2022 18:06:36 +0000 (UTC) Received: by mail-il1-f175.google.com with SMTP id d4so4087994ilc.8 for ; Tue, 12 Jul 2022 11:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YtzP7I40RQyEUjKbXHB73J4wJHJ46s1Pzo+UKJfysDc=; b=gKyujzPiMib4QpZz5P6ENJ/XtcXOdSjN06XstK5OI+x27vhQgM6uBZCNYujbk0KLby Mc0555LKDYc7Cmlcs8zMEan1Dwr/PAhe5Z/zj6KFX3VYzcP0j0SkpdgPRrKvsjBjdvPV aXzFqLurxZ7XKA69w473J60J/vmQ1209DjxV3sbvmkTHVSj7UbmyTWfjN0BKixWrSiy6 5zGNFkVPyoAtC5N5VCo5RegGsy2nE3xf/n+CpvqP9zSJCz6BpeT05tcgr+5I8xqkwSYZ eELPBLl67ZoRUp5zuZbZQKOZNDTOgEYOhrpPhMgHVQznJbrHiCY5ARDR2A98JBYdfmba 3w4w== X-Gm-Message-State: AJIora9H7zaejcfGrriNSZ/hLj0pysFYcx16Uhz7alsPmDjEUtwR70dW qd7HnbDPba6NGveUIvaGrQ== X-Google-Smtp-Source: AGRyM1uQj9XqR1H/j1xEWpea/Q+tQa2PKHOSbgCLwSEg/z123utZodWxiVGVv4vw8BKVxtlj/J0DYg== X-Received: by 2002:a05:6e02:154d:b0:2dc:6324:e1be with SMTP id j13-20020a056e02154d00b002dc6324e1bemr11287953ilu.47.1657649195773; Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id cq7-20020a056638478700b0033f21999e6csm4389983jab.90.2022.07.12.11.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: (nullmailer pid 2112717 invoked by uid 1000); Tue, 12 Jul 2022 18:06:32 -0000 Date: Tue, 12 Jul 2022 12:06:32 -0600 From: Rob Herring To: Rex-BC Chen Subject: Re: [PATCH v13 01/10] dt-bindings: mediatek,dp: Add Display Port binding Message-ID: <20220712180632.GH1823936-robh@kernel.org> References: <20220701062808.18596-1-rex-bc.chen@mediatek.com> <20220701062808.18596-2-rex-bc.chen@mediatek.com> <20220701202914.GA1457156-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, krzysztof.kozlowski+dt@linaro.org, deller@gmx.de, Project_Global_Chrome_Upstream_Group@mediatek.com, wenst@chromium.org, chunkuang.hu@kernel.org, jitao.shi@mediatek.com, tzimmermann@suse.de, liangxu.xu@mediatek.com, msp@baylibre.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com, granquet@baylibre.com, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 05, 2022 at 05:40:27PM +0800, Rex-BC Chen wrote: > On Fri, 2022-07-01 at 14:29 -0600, Rob Herring wrote: > > On Fri, Jul 01, 2022 at 02:27:59PM +0800, Bo-Chen Chen wrote: > > > From: Markus Schneider-Pargmann > > > > > > This controller is present on several mediatek hardware. Currently > > > mt8195 and mt8395 have this controller without a functional > > > difference, > > > so only one compatible field is added. > > > > > > The controller can have two forms, as a normal display port and as > > > an > > > embedded display port. > > > > I'm sure you answered this before, but I'll keep asking until the > > information is contained within this patch. Otherwise, I won't > > remember. > > Is there a h/w difference in the 2 blocks? Different registers? Why > > can't you just look at what the output is connected to? > > > > Hello Rob, > > Thanks for your review. > Yes, it's two different hw for edp and dp and they have different > registers base address. Multiple instances *always* have different base addresses. That's not a difference. I probably asked before on what the difference is between edp and dp variants if anything? If the blocks have some difference then, different compatibles makes sense. But you need to explain the difference or I'll just be asking again... Rob