From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>,
netdev@vger.kernel.org,
Mateusz Palczewski <mateusz.palczewski@intel.com>,
Marek Szlosek <marek.szlosek@intel.com>
Subject: Re: [PATCH net 4/7] iavf: Fix NULL pointer dereference in iavf_get_link_ksettings
Date: Tue, 12 Jul 2022 18:26:36 -0700 [thread overview]
Message-ID: <20220712182636.53a957cc@kernel.org> (raw)
In-Reply-To: <20220711230243.3123667-5-anthony.l.nguyen@intel.com>
On Mon, 11 Jul 2022 16:02:40 -0700 Tony Nguyen wrote:
> + /* if VF failed initialization during __IAVF_INIT_GET_RESOURCES,
> + * it is possible for this variable to be freed there.
> + */
> + if (!adapter->vf_res)
> + return -EAGAIN;
I think I already rejected a similar patch in the past.
ethtool APIs should not return -EAGAIN, if the driver needs to wait
for some init or reset to finish -- it should just wait, we can't
throw errors at user space and hope it will retry.
next prev parent reply other threads:[~2022-07-13 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 23:02 [PATCH net 0/7][pull request] Intel Wired LAN Driver Updates 2022-07-11 Tony Nguyen
2022-07-11 23:02 ` [PATCH net 1/7] iavf: Fix VLAN_V2 addition/rejection Tony Nguyen
2022-07-11 23:02 ` [PATCH net 2/7] iavf: Disallow changing rx/tx-frames and rx/tx-frames-irq Tony Nguyen
2022-07-11 23:02 ` [PATCH net 3/7] iavf: Fix reset error handling Tony Nguyen
2022-07-11 23:02 ` [PATCH net 4/7] iavf: Fix NULL pointer dereference in iavf_get_link_ksettings Tony Nguyen
2022-07-13 1:26 ` Jakub Kicinski [this message]
2022-07-14 16:18 ` Tony Nguyen
2022-07-11 23:02 ` [PATCH net 5/7] iavf: Fix adminq error handling Tony Nguyen
2022-07-11 23:02 ` [PATCH net 6/7] iavf: Fix handling of dummy receive descriptors Tony Nguyen
2022-07-11 23:02 ` [PATCH net 7/7] iavf: Fix missing state logs Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712182636.53a957cc@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=marek.szlosek@intel.com \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslawx.patynowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.