From: Kent Gibson <warthog618@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Dipen Patel <dipenp@nvidia.com>
Subject: Re: [PATCH 6/6] gpiolib: cdev: compile out HTE unless CONFIG_HTE selected
Date: Wed, 13 Jul 2022 18:30:14 +0800 [thread overview]
Message-ID: <20220713103014.GC113115@sol> (raw)
In-Reply-To: <CAHp75Vd7je7U7qsoFDz+2jcNkwCzJHJOadsaSNwk6xD2_vgdpA@mail.gmail.com>
On Wed, Jul 13, 2022 at 12:03:07PM +0200, Andy Shevchenko wrote:
> On Wed, Jul 13, 2022 at 3:39 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > The majority of builds do not include HTE, so compile out hte
> > functionality unless CONFIG_HTE is selected.
>
> ...
>
> > +#ifdef CONFIG_HTE
> > /*
> > * -- hte specific fields --
> > */
>
> Now this comment seems useless to me and it takes 3 LoCs.
>
> ...
>
> > + else if (IS_ENABLED(CONFIG_HTE) &&
> > + (test_bit(FLAG_EVENT_CLOCK_HTE, &line->desc->flags)))
>
> Too many parentheses.
>
> ...
>
> > + if (!IS_ENABLED(CONFIG_HTE) ||
> > + !test_bit(FLAG_EVENT_CLOCK_HTE, &line->desc->flags)) {
>
> if (!(x && y)) ?
>
> ...
>
> > + if (!IS_ENABLED(CONFIG_HTE) &&
> > + (flags & GPIO_V2_LINE_FLAG_EVENT_CLOCK_HTE))
> > + return -EOPNOTSUPP;
>
> Ditto for consistency?
>
Those all make sense - will do.
Thanks for the prompt review.
Cheers,
Kent.
next prev parent reply other threads:[~2022-07-13 10:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 1:37 [PATCH 0/6] gpiolib: cdev: code cleanup following hte integration Kent Gibson
2022-07-13 1:37 ` [PATCH 1/6] gpiolib: cdev: simplify linereq_free Kent Gibson
2022-07-18 9:27 ` Linus Walleij
2022-07-13 1:37 ` [PATCH 2/6] gpiolib: cdev: simplify parameter in call to hte_edge_setup Kent Gibson
2022-07-13 1:37 ` [PATCH 3/6] gpiolib: cdev: replace if-else chains with switches Kent Gibson
2022-07-13 1:37 ` [PATCH 4/6] gpiolib: cdev: simplify line event identification Kent Gibson
2022-07-13 9:59 ` Andy Shevchenko
2022-07-13 10:27 ` Kent Gibson
2022-07-13 11:24 ` Andy Shevchenko
2022-07-14 0:32 ` Kent Gibson
2022-07-13 1:37 ` [PATCH 5/6] gpiolib: cdev: consolidate edge detector configuration flags Kent Gibson
2022-07-13 10:07 ` Andy Shevchenko
2022-07-13 10:24 ` Kent Gibson
2022-07-13 11:29 ` Andy Shevchenko
2022-07-13 1:37 ` [PATCH 6/6] gpiolib: cdev: compile out HTE unless CONFIG_HTE selected Kent Gibson
2022-07-13 10:03 ` Andy Shevchenko
2022-07-13 10:30 ` Kent Gibson [this message]
2022-07-14 1:08 ` Kent Gibson
2022-07-13 10:08 ` [PATCH 0/6] gpiolib: cdev: code cleanup following hte integration Andy Shevchenko
2022-07-15 2:06 ` Dipen Patel
2022-07-15 2:08 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713103014.GC113115@sol \
--to=warthog618@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=dipenp@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.