From: Johan Hovold <johan+linaro@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 2/7] dt-bindings: usb: qcom,dwc3: refine interrupt requirements
Date: Wed, 13 Jul 2022 15:13:35 +0200 [thread overview]
Message-ID: <20220713131340.29401-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220713131340.29401-1-johan+linaro@kernel.org>
Not all platforms have all of the four wakeup interrupts currently
described by the bindings.
Specifically, MSM8953/6/8 and SDM660 do not use the DP/DM interrupts,
while the SS PHY interrupt is optional on SDM660 and SC7280.
Note that no devicetree in mainline specify any wakeup interrupts for
- qcom,ipq4019-dwc3
- qcom,ipq6018-dwc3
- qcom,ipq8064-dwc3
- qcom,ipq8074-dwc3
- qcom,msm8994-dwc3
- qcom,qcs404-dwc3
but let's keep the schema warnings about that for now.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../devicetree/bindings/usb/qcom,dwc3.yaml | 60 +++++++++++++++++--
1 file changed, 55 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index c991d9103f87..fea3e7092ace 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -94,9 +94,11 @@ properties:
- const: apps-usb
interrupts:
+ minItems: 1
maxItems: 4
interrupt-names:
+ minItems: 1
maxItems: 4
qcom,select-utmi-as-pipe-clk:
@@ -333,14 +335,9 @@ allOf:
- qcom,ipq6018-dwc3
- qcom,ipq8064-dwc3
- qcom,ipq8074-dwc3
- - qcom,msm8953-dwc3
- qcom,msm8994-dwc3
- - qcom,msm8996-dwc3
- - qcom,msm8998-dwc3
- qcom,qcs404-dwc3
- qcom,sc7180-dwc3
- - qcom,sc7280-dwc3
- - qcom,sdm660-dwc3
- qcom,sdm845-dwc3
- qcom,sdx55-dwc3
- qcom,sdx65-dwc3
@@ -369,6 +366,59 @@ allOf:
- const: dm_hs_phy_irq
- const: dp_hs_phy_irq
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,msm8953-dwc3
+ - qcom,msm8996-dwc3
+ - qcom,msm8998-dwc3
+ then:
+ properties:
+ interrupts:
+ maxItems: 2
+ interrupt-names:
+ items:
+ - const: hs_phy_irq
+ - const: ss_phy_irq
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sdm660-dwc3
+ then:
+ properties:
+ interrupts:
+ minItems: 1
+ maxItems: 2
+ interrupt-names:
+ minItems: 1
+ items:
+ - const: hs_phy_irq
+ - const: ss_phy_irq
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc7280-dwc3
+ then:
+ properties:
+ interrupts:
+ minItems: 3
+ maxItems: 4
+ interrupt-names:
+ minItems: 3
+ items:
+ - const: hs_phy_irq
+ - const: dp_hs_phy_irq
+ - const: dm_hs_phy_irq
+ - const: ss_phy_irq
+
- if:
properties:
compatible:
--
2.35.1
next prev parent reply other threads:[~2022-07-13 13:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:13 [PATCH 0/7] usb: dwc3: add support for SC8280XP Johan Hovold
2022-07-13 13:13 ` [PATCH 1/7] dt-bindings: usb: qcom,dwc3: add SC8280XP binding Johan Hovold
2022-07-14 10:48 ` Krzysztof Kozlowski
2022-07-14 10:51 ` Krzysztof Kozlowski
2022-07-13 13:13 ` Johan Hovold [this message]
2022-07-14 10:50 ` [PATCH 2/7] dt-bindings: usb: qcom,dwc3: refine interrupt requirements Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 3/7] usb: dwc3: qcom: fix missing optional irq warnings Johan Hovold
2022-07-13 14:00 ` Andrew Halaney
2022-07-13 13:13 ` [PATCH 4/7] arm64: dts: qcom: sc8280xp: fix USB clock order Johan Hovold
2022-07-14 10:52 ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 5/7] arm64: dts: qcom: sc8280xp: fix USB interrupts Johan Hovold
2022-07-13 14:12 ` Andrew Halaney
2022-07-13 14:35 ` Johan Hovold
2022-07-13 14:43 ` Andrew Halaney
2022-07-13 15:03 ` Johan Hovold
2022-07-14 10:52 ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 6/7] arm64: dts: qcom: sc7280: reorder " Johan Hovold
2022-07-14 10:54 ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 7/7] arm64: dts: qcom: " Johan Hovold
2022-07-14 10:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713131340.29401-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.