From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C478DC433EF for ; Wed, 13 Jul 2022 13:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234652AbiGMNYs (ORCPT ); Wed, 13 Jul 2022 09:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbiGMNYs (ORCPT ); Wed, 13 Jul 2022 09:24:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64A292E8 for ; Wed, 13 Jul 2022 06:24:47 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBcM3-0003W0-Av; Wed, 13 Jul 2022 15:24:39 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oBcM1-0004Jl-If; Wed, 13 Jul 2022 15:24:37 +0200 Date: Wed, 13 Jul 2022 15:24:37 +0200 From: Oleksij Rempel To: Francesco Dolcini Cc: Oleksandr Suvorov , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wolfram Sang , Marco Felsch , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] i2c: imx: Retry transfer on transient failure Message-ID: <20220713132437.GF24373@pengutronix.de> References: <20220712082415.319738-1-francesco.dolcini@toradex.com> <20220712090514.lt4r4dvlkn55jf2o@pengutronix.de> <20220712100504.GB319880@francesco-nb.int.toradex.com> <20220713115750.GA504159@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220713115750.GA504159@francesco-nb.int.toradex.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Jul 13, 2022 at 01:57:50PM +0200, Francesco Dolcini wrote: > + oleksandr.suvorov@foundries.io > > Hello all, > > On Tue, Jul 12, 2022 at 12:05:04PM +0200, Francesco Dolcini wrote: > > On Tue, Jul 12, 2022 at 11:05:14AM +0200, Uwe Kleine-König wrote: > > > In which situations does this help? Please mention these in the > > > commit log. > > I'll do > > I did some investigation on this, unfortunately we have this change > laying around since 1 year, it was written by Oleksandr, and in the > meantime he moved to a new company. I added him to this email thread, so > he can comment in case he remembers more. > > We introduced this change while working on OV5640 camera sensor on an > apalis-imx6q evaluation board, without this change we had some sporadic > i2c communication issues. Unfortunately I do not have any better > details. > > To me looks like having some (3? 5?) retry as a default is somehow > more reasonable than to never retry, not sure if this should be > implemented as a default for all the i2c adapters. From what I was able > to see that would not be a trivial change (the retry parameter is coming > from the i2c_imx driver, there is no obvious way to have a default in > the i2c core). > > Would it work for you to keep the change as it is (just getting rid > of the useless define) and add a little bit more blurb to the commit > message to include the various comments collected so far? I assume, it is related to reset time or other reason where the camera is not responding. In this case, amount of retries would depend on I2C CLK speed and host CPU speed. May be it is worth to investigate real issue and potentially fix camera driver? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EE65C43334 for ; Wed, 13 Jul 2022 13:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cY2RSdCem3tRUy2MUhBQDyhk7qagmJdlEcLmhQYP01w=; b=QNp4nGUPMsBMr3 4IsxH89C4oUeWr1x5vaGpH5qzQlSoZQOLfu861dyquMoqjwIG5VKa8/JSvdVll9RD0nmfdQeCYr3y wRpzsxeW5yY9mw7akfH+C4NE1OnHXqn2jqirj2kdLUl8payJmd+FD2xR4IGw/SHNQ4SbNr6Tj6Arq fruSu/mbypoastl0iC0GjBzFQw9AOu8EXdtViYsIrSzyWPsBJWbEXMZ++Rxkq0OWfP1NJaBmTxbI1 dUQVi42X1bdkexnOGnWGe7BRsBEp9aSWKE9hOU0RJIZ6WOvoUQy30IDHRGzZQHl2YY3f3JjlTm+Kp t9MMEOC2X/uQglYrFJ+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBcMI-003uno-VK; Wed, 13 Jul 2022 13:24:55 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBcMG-003uki-4K for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 13:24:53 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBcM3-0003W0-Av; Wed, 13 Jul 2022 15:24:39 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oBcM1-0004Jl-If; Wed, 13 Jul 2022 15:24:37 +0200 Date: Wed, 13 Jul 2022 15:24:37 +0200 From: Oleksij Rempel To: Francesco Dolcini Cc: Oleksandr Suvorov , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wolfram Sang , Marco Felsch , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] i2c: imx: Retry transfer on transient failure Message-ID: <20220713132437.GF24373@pengutronix.de> References: <20220712082415.319738-1-francesco.dolcini@toradex.com> <20220712090514.lt4r4dvlkn55jf2o@pengutronix.de> <20220712100504.GB319880@francesco-nb.int.toradex.com> <20220713115750.GA504159@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220713115750.GA504159@francesco-nb.int.toradex.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_062452_190294_01B74339 X-CRM114-Status: GOOD ( 29.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMTMsIDIwMjIgYXQgMDE6NTc6NTBQTSArMDIwMCwgRnJhbmNlc2NvIERvbGNp bmkgd3JvdGU6Cj4gKyBvbGVrc2FuZHIuc3V2b3JvdkBmb3VuZHJpZXMuaW8KPiAKPiBIZWxsbyBh bGwsCj4gCj4gT24gVHVlLCBKdWwgMTIsIDIwMjIgYXQgMTI6MDU6MDRQTSArMDIwMCwgRnJhbmNl c2NvIERvbGNpbmkgd3JvdGU6Cj4gPiBPbiBUdWUsIEp1bCAxMiwgMjAyMiBhdCAxMTowNToxNEFN ICswMjAwLCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiA+ID4gSW4gd2hpY2ggc2l0dWF0aW9u cyBkb2VzIHRoaXMgaGVscD8gUGxlYXNlIG1lbnRpb24gdGhlc2UgaW4gdGhlCj4gPiA+IGNvbW1p dCBsb2cuCj4gPiBJJ2xsIGRvCj4gCj4gSSBkaWQgc29tZSBpbnZlc3RpZ2F0aW9uIG9uIHRoaXMs IHVuZm9ydHVuYXRlbHkgd2UgaGF2ZSB0aGlzIGNoYW5nZQo+IGxheWluZyBhcm91bmQgc2luY2Ug MSB5ZWFyLCBpdCB3YXMgd3JpdHRlbiBieSBPbGVrc2FuZHIsIGFuZCBpbiB0aGUKPiBtZWFudGlt ZSBoZSBtb3ZlZCB0byBhIG5ldyBjb21wYW55LiBJIGFkZGVkIGhpbSB0byB0aGlzIGVtYWlsIHRo cmVhZCwgc28KPiBoZSBjYW4gY29tbWVudCBpbiBjYXNlIGhlIHJlbWVtYmVycyBtb3JlLgo+IAo+ IFdlIGludHJvZHVjZWQgdGhpcyBjaGFuZ2Ugd2hpbGUgd29ya2luZyBvbiBPVjU2NDAgY2FtZXJh IHNlbnNvciBvbiBhbgo+IGFwYWxpcy1pbXg2cSBldmFsdWF0aW9uIGJvYXJkLCB3aXRob3V0IHRo aXMgY2hhbmdlIHdlIGhhZCBzb21lIHNwb3JhZGljCj4gaTJjIGNvbW11bmljYXRpb24gaXNzdWVz LiBVbmZvcnR1bmF0ZWx5IEkgZG8gbm90IGhhdmUgYW55IGJldHRlcgo+IGRldGFpbHMuCj4gCj4g VG8gbWUgbG9va3MgbGlrZSBoYXZpbmcgc29tZSAoMz8gNT8pIHJldHJ5IGFzIGEgZGVmYXVsdCBp cyBzb21laG93Cj4gbW9yZSByZWFzb25hYmxlIHRoYW4gdG8gbmV2ZXIgcmV0cnksIG5vdCBzdXJl IGlmIHRoaXMgc2hvdWxkIGJlCj4gaW1wbGVtZW50ZWQgYXMgYSBkZWZhdWx0IGZvciBhbGwgdGhl IGkyYyBhZGFwdGVycy4gRnJvbSB3aGF0IEkgd2FzIGFibGUKPiB0byBzZWUgdGhhdCB3b3VsZCBu b3QgYmUgYSB0cml2aWFsIGNoYW5nZSAodGhlIHJldHJ5IHBhcmFtZXRlciBpcyBjb21pbmcKPiBm cm9tIHRoZSBpMmNfaW14IGRyaXZlciwgdGhlcmUgaXMgbm8gb2J2aW91cyB3YXkgdG8gaGF2ZSBh IGRlZmF1bHQgaW4KPiB0aGUgaTJjIGNvcmUpLgo+IAo+IFdvdWxkIGl0IHdvcmsgZm9yIHlvdSB0 byBrZWVwIHRoZSBjaGFuZ2UgYXMgaXQgaXMgKGp1c3QgZ2V0dGluZyByaWQKPiBvZiB0aGUgdXNl bGVzcyBkZWZpbmUpIGFuZCBhZGQgYSBsaXR0bGUgYml0IG1vcmUgYmx1cmIgdG8gdGhlIGNvbW1p dAo+IG1lc3NhZ2UgdG8gaW5jbHVkZSB0aGUgdmFyaW91cyBjb21tZW50cyBjb2xsZWN0ZWQgc28g ZmFyPwoKSSBhc3N1bWUsIGl0IGlzIHJlbGF0ZWQgdG8gcmVzZXQgdGltZSBvciBvdGhlciByZWFz b24gd2hlcmUgdGhlIGNhbWVyYQppcyBub3QgcmVzcG9uZGluZy4gSW4gdGhpcyBjYXNlLCBhbW91 bnQgb2YgcmV0cmllcyB3b3VsZCBkZXBlbmQgb24gSTJDCkNMSyBzcGVlZCBhbmQgaG9zdCBDUFUg c3BlZWQuCgpNYXkgYmUgaXQgaXMgd29ydGggdG8gaW52ZXN0aWdhdGUgcmVhbCBpc3N1ZSBhbmQg cG90ZW50aWFsbHkgZml4IGNhbWVyYSBkcml2ZXI/CgpSZWdhcmRzLApPbGVrc2lqCi0tIApQZW5n dXRyb25peCBlLksuICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfApTdGV1ZXJ3YWxkZXIgU3RyLiAyMSAgICAgICAgICAgICAgICAgICAgICAg fCBodHRwOi8vd3d3LnBlbmd1dHJvbml4LmRlLyAgfAozMTEzNyBIaWxkZXNoZWltLCBHZXJtYW55 ICAgICAgICAgICAgICAgICAgfCBQaG9uZTogKzQ5LTUxMjEtMjA2OTE3LTAgICAgfApBbXRzZ2Vy aWNodCBIaWxkZXNoZWltLCBIUkEgMjY4NiAgICAgICAgICAgfCBGYXg6ICAgKzQ5LTUxMjEtMjA2 OTE3LTU1NTUgfAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=