All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: akpm@linux-foundation.org, axboe@kernel.dk, neilb@suse.de,
	johannes.thumshirn@wdc.com, jack@suse.cz, willy@infradead.org,
	mgorman@techsingularity.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()
Date: Wed, 13 Jul 2022 16:03:08 +0200	[thread overview]
Message-ID: <20220713140308.5je2p3zz4vm4fvjb@quack3> (raw)
In-Reply-To: <20220713125314.171345-1-xiujianfeng@huawei.com>

On Wed 13-07-22 20:53:14, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..e84b745a6811 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
>  	return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
>  }
>  
> -static inline int bdi_sched_wait(void *word)
> -{
> -	schedule();
> -	return 0;
> -}
> -
>  #ifdef CONFIG_CGROUP_WRITEBACK
>  
>  struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2022-07-13 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 12:53 [PATCH -next] writeback: Cleanup bdi_sched_wait() Xiu Jianfeng
2022-07-13 14:03 ` Jan Kara [this message]
2022-07-13 14:05 ` Johannes Thumshirn
2022-07-13 15:58 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713140308.5je2p3zz4vm4fvjb@quack3 \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=neilb@suse.de \
    --cc=willy@infradead.org \
    --cc=xiujianfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.