From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 514F6C433EF for ; Wed, 13 Jul 2022 14:19:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0272084005; Wed, 13 Jul 2022 16:19:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="S/OWJiYG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2ADA284005; Wed, 13 Jul 2022 16:19:32 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 69A7583FE8 for ; Wed, 13 Jul 2022 16:19:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id f12so8605337qka.12 for ; Wed, 13 Jul 2022 07:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QU1ArOBerud+UT/X92yOKOX0qTZEFq3QFbxUClRvGyM=; b=S/OWJiYGpyGBbMLHGsVgspyWt9bIJgK8TVaJF/K3S3dIYaLJyddnS4C/3UWb56rQWX sUYjXJ0GQxj5p5CLLCzChRh0zUAdcwGskTny5SJNJAktaALWyEWcxYtAZNm2iOeVG69M tjh2zwofQpcTS/E+4oqQJV5zd4mpDh3z9V7IQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QU1ArOBerud+UT/X92yOKOX0qTZEFq3QFbxUClRvGyM=; b=yHHsZOQ89iCL4zg4zdkLtuhjro72IwRqPlt+OY5qabmb2+yqnHHXQfwYTDU8L/cs0P OmVw+0jqZwChPmn1ynkmGHjbQ0wzVa/3LOm6Vcikp7kNiCvK00g5QTC5kiMDFGygjihA wDOXVZ7siSGV6WbL5iNSfwrEOtxj+GJ5N997nNssWX4PcYtoQYlo3wCHtj2WXR/skaIb ETTUtmCRkz110lGDyyGVPu/HQk8odj4oa6sfFnKIvJk4EpoYfdzhHgjiU8nZMwrmjRnb JVG3Z/WppgPj9VaOshAE7Bx/kx/2lAoHUWD0h8JFN49VPZi2pT7dIo4pg0w2H5zZ2AuQ VfsA== X-Gm-Message-State: AJIora8k4+c6RaajbPEoCROc8lP+GfFOBUGmtGRRLE+1gCwpgNoGgobC 2o2C+ZYNNUYtdnghb2RVTVxnog== X-Google-Smtp-Source: AGRyM1tsolAi8Po0k63KlXahHxo8ALHh8k03ajCykxPq0qYs7pijn2uniMFwKzyr6bjoen4V0jFwCA== X-Received: by 2002:a05:620a:222e:b0:6b5:8ea6:7517 with SMTP id n14-20020a05620a222e00b006b58ea67517mr2441331qkh.309.1657721964207; Wed, 13 Jul 2022 07:19:24 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id c73-20020ae9ed4c000000b006a37c908d33sm11244491qkg.28.2022.07.13.07.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 07:19:23 -0700 (PDT) Date: Wed, 13 Jul 2022 10:19:21 -0400 From: Tom Rini To: Alexander Dahl Cc: Michal Simek , u-boot@lists.denx.de, Alexander Dahl , Wolfgang Wegner , Simon Glass , Stefan Roese , Patrick Delaunay , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH v2 2/2] fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig Message-ID: <20220713141921.GD1146598@bill-the-cat> References: <20220713123307.21314-1-post@lespocky.de> <20220713123307.21314-3-post@lespocky.de> <3c866442-f9b0-f638-46e4-a917b4187bc4@amd.com> <20220713131109.GA1941@falbala.internal.home.lespocky.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KZ5dCXpsDJX4fH9g" Content-Disposition: inline In-Reply-To: <20220713131109.GA1941@falbala.internal.home.lespocky.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --KZ5dCXpsDJX4fH9g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 13, 2022 at 03:11:09PM +0200, Alexander Dahl wrote: > Hei hei, >=20 > On Wed, Jul 13, 2022 at 02:50:14PM +0200, Michal Simek wrote: > >=20 > >=20 > > On 7/13/22 14:33, Alexander Dahl wrote: > > > From: Alexander Dahl > >=20 > >=20 > > WARNING: please write a paragraph that describes the config symbol fully > >=20 > > We don't allow patches with empty commit message. >=20 > In general I would agree. However several of Tom's patches addressing > kconfig migration have a commit message like this: >=20 > This converts the following to Kconfig: FOO_BAR >=20 > This is redundant to the subject saying exactly the same. I can add > this if you want, but I saw no sense in it. Yes, the moveconfig.py tool adds that and it's a little redundant sometimes, but is (a) a starting point for the times when the conversion required a little extra work or (b) lists all the symbols when you migrate more than one at a time. > > > Signed-off-by: Alexander Dahl > > > --- > > > README | 4 ---- > > > configs/astro_mcf5373l_defconfig | 1 + > > > drivers/fpga/Kconfig | 6 ++++++ > > > include/configs/astro_mcf5373l.h | 1 - > > > scripts/config_whitelist.txt | 1 - > >=20 > > Tom can confirm this but IIRC you don't need to remove this from this f= ile. > > Tom is doing sync up time to time. It is enough to do conversion only. >=20 > This was done by the script ./tools/moveconfig.py where I just hit > enter with defaults presented. The other Kconfig patches change > defconfig, but not whitelist. Seems a little inconsistent to me. But > I can remove that part, sure. So, I usually run "-yC" with moveconfig.py as that gives the commit message. It's not a problem, really, to touch scripts/config_whitelist.txt it just also can conflict easily. Omitting it makes it easier to "git am", fixing up / dropping that hunk if it conflicts later is also fine. --=20 Tom --KZ5dCXpsDJX4fH9g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLO1GkACgkQFHw5/5Y0 tyygGgv/YJU63PtWMj98Vyqg4Zptck2de7kdUarcPlj5iocmWQG7KzGUC2PF8Wa3 oJPcN23DvXKtitvv5bzut1Dc85zHZ9cZ+AIUtj4oLS3ER3taiWrIJPtxBcbN5aYB gTAvc/TKDI56CCrn11sx6s3lfXFGJSuoOgVRwzIxtHOs1N5mxznT3iSWpEv0xTuc S0rbhBwMt/NXWU16UMQHqrauj846JagigW/c00WEumvOU1tC5zcZMi0spHAU4h57 VMQ6hVxOp9iqArKcQOeGLw0MFue5k89uQ296sixSQ9Qf46OemagxF6C4lRLXqsBG zdXrxRQZsgXH7lpuZAnn5D4DMot9KTbFCJ4ugnDvtaJACtdsGLYHeQ/qi6Ow/CxH 1BaydNtNSnykBMOr0PlFX7ZPgR9csIRKd+Ri3axx9sM+hm/stbfSqy3uQjXFaInO LKL+m2CZGSVbK6C4BjdWg95sQ8KxueTvsjAifzfVYfeeZBNvQ6jOwtzL8zOb79lO pNe8/SEH =turc -----END PGP SIGNATURE----- --KZ5dCXpsDJX4fH9g--