All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Aleksander Bajkowski <olek2@wp.pl>
Cc: Eric Dumazet <edumazet@google.com>,
	hauke@hauke-m.de, David Miller <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: lantiq_xrx200: use skb cache
Date: Wed, 13 Jul 2022 14:24:33 -0700	[thread overview]
Message-ID: <20220713142433.131e5a26@kernel.org> (raw)
In-Reply-To: <72d3a578-f321-41aa-858c-9f3a6978a277@wp.pl>

On Wed, 13 Jul 2022 22:38:37 +0200 Aleksander Bajkowski wrote:
> > If you are changing this code path, what about adding proper error recovery ?
> > 
> > skb can be NULL at this point :/
>
> Good catch. I will try to test the fix on the device tomorrow and send the patch.

Let's defer this patch until we merge the fix, otherwise we'll get 
a conflict. Not a big deal but easily avoidable here.

      reply	other threads:[~2022-07-13 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 18:14 [PATCH net-next] net: lantiq_xrx200: use skb cache Aleksander Jan Bajkowski
2022-07-12 22:23 ` Hauke Mehrtens
2022-07-13 12:50 ` Eric Dumazet
2022-07-13 20:38   ` Aleksander Bajkowski
2022-07-13 21:24     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713142433.131e5a26@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.