From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Steve Capper <Steve.Capper@arm.com>
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
Date: Wed, 13 Jul 2022 20:43:05 +0530 [thread overview]
Message-ID: <20220713151305.GA4591@workstation> (raw)
In-Reply-To: <Ys7c0JGAV7AAEjaO@hovoldconsulting.com>
On Wed, Jul 13, 2022 at 04:55:12PM +0200, Johan Hovold wrote:
> On Wed, Jul 13, 2022 at 08:04:29PM +0530, Manivannan Sadhasivam wrote:
> > PPI interrupt should be 7 for the PMU.
> >
> > Cc: Johan Hovold <johan+linaro@kernel.org>
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Reported-by: Steve Capper <Steve.Capper@arm.com>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > index 268ab423577a..2d7823cb783c 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > @@ -477,7 +477,7 @@ memory@80000000 {
> >
> > pmu {
> > compatible = "arm,armv8-pmuv3";
> > - interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > };
> >
> > psci {
>
> The interrupt number matches the vendor devicetree I have access to, but
> the vendor source also has IRQ_TYPE_LEVEL_LOW instead of
> IRQ_TYPE_LEVEL_HIGH here.
>
> Is that another copy-paste error, perhaps?
>
I don't have access to the documentation of this SoC now but since Steve
tried with IRQ_TYPE_LEVEL_HIGH and it worked for him, I think it is best
to leave it as it is.
Thanks,
Mani
> Johan
next prev parent reply other threads:[~2022-07-13 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 14:34 [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt Manivannan Sadhasivam
2022-07-13 14:51 ` Andrew Halaney
2022-07-13 14:55 ` Johan Hovold
2022-07-13 15:13 ` Manivannan Sadhasivam [this message]
2022-07-13 15:26 ` Andrew Halaney
2022-07-16 15:18 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713151305.GA4591@workstation \
--to=manivannan.sadhasivam@linaro.org \
--cc=Steve.Capper@arm.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.