From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E978AC433EF for ; Wed, 13 Jul 2022 15:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236576AbiGMPUS (ORCPT ); Wed, 13 Jul 2022 11:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236820AbiGMPUP (ORCPT ); Wed, 13 Jul 2022 11:20:15 -0400 Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F4004504B for ; Wed, 13 Jul 2022 08:20:14 -0700 (PDT) Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-f2a4c51c45so14409182fac.9 for ; Wed, 13 Jul 2022 08:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=UGv5W4X0AgNs0e90Jxbuk8yoqkf1YIvPuG32cxJaOFdhOKMYtLT3UzjNMyJo3NmCSB h/K0iglgBA1TRNjZsaY3WPDnmRX23YpSMViygd9NRIhPlSo9yiPb+fbPadGOwbmeYz9x 0j6tumQO78ZJbjdyG1XX+ZjluB6BIV4JYujzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=kBuu7UpSBd0BHEzIIpe3TvZpcy0QAkl9/GEihuEe1/j/xoPK3AxHEJipzcJVCmVFI5 w7aAo9NDnjoSWMQJOBNeRPMJj1WjKL68zRQLcCjMTMGDpB2vuvcknpseU7tp2i3jVejl czcFsTs9MVE+1VdVIeMTJcPSM2AqQnUZRh72qsCiFiSKLBHB4IzAgianTCBSouX+bi/N j97YGv+ZabW3SBRNmjQpiV9gh1GNW0oQZ4RfBvLFg8MyVoMzZuT92WIcsNDqCtL1oTCO hwh6Jg+uJ7vOCxwuAP1jOLeLNhNFti+xMp8NvTJXaNNdVuS01OemQ/vJObPeJ5NPdBT4 86BQ== X-Gm-Message-State: AJIora+sUt9szQ0WS4/0SVqJN62aN6f6fP9/n5/oTNtLmlyqyBC5LMVA l44tHVSITBpRkvged/CqJPFvIA== X-Google-Smtp-Source: AGRyM1usHml13CDD+aHqFlxY8s5H+Eng7j9UX5kgdAqCwghIPyT60PRhwo1GRoZ8vA6nrb+/q/6Bdg== X-Received: by 2002:a05:6871:60c:b0:10b:ee7c:2e28 with SMTP id w12-20020a056871060c00b0010bee7c2e28mr4774059oan.21.1657725613728; Wed, 13 Jul 2022 08:20:13 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id x24-20020a4a3f58000000b00432ac97ad09sm4895477ooe.26.2022.07.13.08.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:20:12 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Richard Palethorpe , Jeroen Hofstee , Linux Memory Management List , kernel test robot , lkp@intel.com, lkp@lists.01.org, ltp@lists.linux.it, Dario Binacchi , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] can: slcan: do not sleep with a spin lock held Date: Wed, 13 Jul 2022 17:19:47 +0200 Message-Id: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..6aaf2986effc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) /* TTY discipline is running. */ clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } + spin_unlock_bh(&sl->lock); netif_stop_queue(dev); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) sl->rcount = 0; sl->xleft = 0; - spin_unlock_bh(&sl->lock); return 0; } -- 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01DECC43334 for ; Wed, 13 Jul 2022 15:20:28 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9F50B3CA8AD for ; Wed, 13 Jul 2022 17:20:26 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 8C76B3CA52D for ; Wed, 13 Jul 2022 17:20:15 +0200 (CEST) Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 0CC65200B91 for ; Wed, 13 Jul 2022 17:20:15 +0200 (CEST) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-10c0052da61so14361970fac.12 for ; Wed, 13 Jul 2022 08:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=UGv5W4X0AgNs0e90Jxbuk8yoqkf1YIvPuG32cxJaOFdhOKMYtLT3UzjNMyJo3NmCSB h/K0iglgBA1TRNjZsaY3WPDnmRX23YpSMViygd9NRIhPlSo9yiPb+fbPadGOwbmeYz9x 0j6tumQO78ZJbjdyG1XX+ZjluB6BIV4JYujzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=hEjCRxOtnPd60JhV40/gtqfOxp+dr1/7Lp43OEX5UxR/jzh7TRICepMrY5eCGsiUSZ 2RYkpFbwgFt3pu4c6Vt6LErAprrNam1qldyeUYjnZlPqbSB0zV1ZWLTLJ+vKGDQzCULR eaDEFvcYz4JURrKWXhVvrUyCrIvrAL9odVE/cEVuQ2ugSSwJirpk8WSV5il/gyBEWF+m YuNrMdjKZlAuuc5OSY2AsMZSLRhDUkXecl2NNDpGgdxQj9ffCPmfnbKJYqmSEXLt2/4z 48SDyB5F+z+nA1n7ihU29ylTv8xFyJVpa3uHsQgngAd5T/Tna1p5UGKTYyOZt4nX0Kqo DlPQ== X-Gm-Message-State: AJIora8zsMJ9+ee9X+tM7HTP8vsigJXFQtrVI/EpvQtYwavWFYj09rtw DvSDOzggGvA8kqtcd4t7Odct3w== X-Google-Smtp-Source: AGRyM1usHml13CDD+aHqFlxY8s5H+Eng7j9UX5kgdAqCwghIPyT60PRhwo1GRoZ8vA6nrb+/q/6Bdg== X-Received: by 2002:a05:6871:60c:b0:10b:ee7c:2e28 with SMTP id w12-20020a056871060c00b0010bee7c2e28mr4774059oan.21.1657725613728; Wed, 13 Jul 2022 08:20:13 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id x24-20020a4a3f58000000b00432ac97ad09sm4895477ooe.26.2022.07.13.08.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:20:12 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Date: Wed, 13 Jul 2022 17:19:47 +0200 Message-Id: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH] can: slcan: do not sleep with a spin lock held X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Abeni , lkp@intel.com, lkp@lists.01.org, Greg Kroah-Hartman , Jeroen Hofstee , linux-can@vger.kernel.org, Linux Memory Management List , Eric Dumazet , Sebastian Andrzej Siewior , kernel test robot , Vincent Mailhol , netdev@vger.kernel.org, Jakub Kicinski , Marc Kleine-Budde , Dario Binacchi , Jiri Slaby , "David S. Miller" , ltp@lists.linux.it, Wolfgang Grandegger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..6aaf2986effc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) /* TTY discipline is running. */ clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } + spin_unlock_bh(&sl->lock); netif_stop_queue(dev); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) sl->rcount = 0; sl->xleft = 0; - spin_unlock_bh(&sl->lock); return 0; } -- 2.32.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8940826584891858578==" MIME-Version: 1.0 From: Dario Binacchi To: lkp@lists.01.org Subject: [PATCH] can: slcan: do not sleep with a spin lock held Date: Wed, 13 Jul 2022 17:19:47 +0200 Message-ID: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> List-Id: --===============8940826584891858578== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE(a)xsang-OptiPle= x-9020/ Signed-off-by: Dario Binacchi --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slc= an-core.c index 54d29a410ad5..6aaf2986effc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) /* TTY discipline is running. */ clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } + spin_unlock_bh(&sl->lock); netif_stop_queue(dev); close_candev(dev); sl->can.state =3D CAN_STATE_STOPPED; @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) = sl->rcount =3D 0; sl->xleft =3D 0; - spin_unlock_bh(&sl->lock); = return 0; } -- = 2.32.0 --===============8940826584891858578==--