From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2C2ACCA486 for ; Thu, 14 Jul 2022 04:25:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0E96317EB; Thu, 14 Jul 2022 06:25:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0E96317EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657772756; bh=dt8pDqk8iKTyANiXWzkfAhvww3xMsxUF+gbazu59Dis=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=h9VBvMHmTzDXD1FzZuKOOL8ZaiW616gzA51np38rscjvESk0l4klwyMJiyinFYxGp 9DVjQKYqzffkUvjSG1dyR6cMtgExzo0t18m+vpDz4dHARWlOnJ6reyXjKNpPB1/fJ3 zYHtod4VUnPdphAjWXrjnNeLQ7vm0BXFC6Z1MspU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6B8D9F805AE; Thu, 14 Jul 2022 06:23:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 157ADF805AF; Thu, 14 Jul 2022 06:23:03 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5FEB0F805A0 for ; Thu, 14 Jul 2022 06:22:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5FEB0F805A0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PSJXdR4C" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13F2661E59; Thu, 14 Jul 2022 04:22:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF5B4C341C6; Thu, 14 Jul 2022 04:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657772576; bh=dt8pDqk8iKTyANiXWzkfAhvww3xMsxUF+gbazu59Dis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PSJXdR4CKJlvx9qYNN4saKAJCdyWWxGsD3HTFG9eZi5rz82LQhSsOOBNXDqXJ75eN YWg9uYXKAmcPYYiTVWqu3tTHYxwi9+0p+W5H8TD+jJY50lNSAKfT4M22K4axex4tWY XJ/QLuu2uiZ1LbxPN4EUSGFNb9imPCg4IiY0Ljh+SqgKUxlaMwsh4uWLjuTzgwT8sW DpINz5cZT9Oc1IozTknGlobU/p7Di7oD1jCyVeMiYtJQlS63kGSHSPy8CTcUrBHcrE hzkEMNAhWanOT8aYp9Fm5CjzM0DnzvA/YCirejGS6HbK/tSXqjmuh1UerZ0e4dzw9a bKDw1u0XfIieA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.18 13/41] ASoC: wcd9335: Fix spurious event generation Date: Thu, 14 Jul 2022 00:21:53 -0400 Message-Id: <20220714042221.281187-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220714042221.281187-1-sashal@kernel.org> References: <20220714042221.281187-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com, Mark Brown , srinivas.kandagatla@linaro.org, bgoswami@quicinc.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit a7786cbae4b2732815da98efa39df96746b5bd0d ] The slimbus mux put operation unconditionally reports a change in value which means that spurious events are generated. Fix this by exiting early in that case. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220603124609.4024666-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wcd9335.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 12be043ee9a3..aa685980a97b 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -1287,6 +1287,9 @@ static int slim_rx_mux_put(struct snd_kcontrol *kc, struct snd_soc_dapm_update *update = NULL; u32 port_id = w->shift; + if (wcd->rx_port_value[port_id] == ucontrol->value.enumerated.item[0]) + return 0; + wcd->rx_port_value[port_id] = ucontrol->value.enumerated.item[0]; /* Remove channel from any list it's in before adding it to a new one */ -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7F7C433EF for ; Thu, 14 Jul 2022 04:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235011AbiGNEYz (ORCPT ); Thu, 14 Jul 2022 00:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234804AbiGNEYJ (ORCPT ); Thu, 14 Jul 2022 00:24:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB8E229802; Wed, 13 Jul 2022 21:22:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6721BB8237C; Thu, 14 Jul 2022 04:22:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF5B4C341C6; Thu, 14 Jul 2022 04:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657772576; bh=dt8pDqk8iKTyANiXWzkfAhvww3xMsxUF+gbazu59Dis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PSJXdR4CKJlvx9qYNN4saKAJCdyWWxGsD3HTFG9eZi5rz82LQhSsOOBNXDqXJ75eN YWg9uYXKAmcPYYiTVWqu3tTHYxwi9+0p+W5H8TD+jJY50lNSAKfT4M22K4axex4tWY XJ/QLuu2uiZ1LbxPN4EUSGFNb9imPCg4IiY0Ljh+SqgKUxlaMwsh4uWLjuTzgwT8sW DpINz5cZT9Oc1IozTknGlobU/p7Di7oD1jCyVeMiYtJQlS63kGSHSPy8CTcUrBHcrE hzkEMNAhWanOT8aYp9Fm5CjzM0DnzvA/YCirejGS6HbK/tSXqjmuh1UerZ0e4dzw9a bKDw1u0XfIieA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown , Sasha Levin , srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.18 13/41] ASoC: wcd9335: Fix spurious event generation Date: Thu, 14 Jul 2022 00:21:53 -0400 Message-Id: <20220714042221.281187-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220714042221.281187-1-sashal@kernel.org> References: <20220714042221.281187-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mark Brown [ Upstream commit a7786cbae4b2732815da98efa39df96746b5bd0d ] The slimbus mux put operation unconditionally reports a change in value which means that spurious events are generated. Fix this by exiting early in that case. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220603124609.4024666-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wcd9335.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 12be043ee9a3..aa685980a97b 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -1287,6 +1287,9 @@ static int slim_rx_mux_put(struct snd_kcontrol *kc, struct snd_soc_dapm_update *update = NULL; u32 port_id = w->shift; + if (wcd->rx_port_value[port_id] == ucontrol->value.enumerated.item[0]) + return 0; + wcd->rx_port_value[port_id] = ucontrol->value.enumerated.item[0]; /* Remove channel from any list it's in before adding it to a new one */ -- 2.35.1