From: Yang Li <yang.lee@linux.alibaba.com>
To: krzysztof.kozlowski@linaro.org
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
konrad.dybcio@somainline.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH -next] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
Date: Thu, 14 Jul 2022 15:22:53 +0800 [thread overview]
Message-ID: <20220714072253.63052-1-yang.lee@linux.alibaba.com> (raw)
Eliminate the follow coccicheck warning:
./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/soc/qcom/icc-bwmon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index bea3ea1de7a4..7f8aca533cd3 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -345,10 +345,8 @@ static int bwmon_probe(struct platform_device *pdev)
}
bwmon->irq = platform_get_irq(pdev, 0);
- if (bwmon->irq < 0) {
- dev_err(dev, "failed to acquire bwmon IRQ\n");
+ if (bwmon->irq < 0)
return bwmon->irq;
- }
ret = devm_pm_opp_of_add_table(dev);
if (ret)
--
2.20.1.7.g153144c
next reply other threads:[~2022-07-14 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 7:22 Yang Li [this message]
2022-07-14 7:46 ` [PATCH -next] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714072253.63052-1-yang.lee@linux.alibaba.com \
--to=yang.lee@linux.alibaba.com \
--cc=abaci@linux.alibaba.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.