From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [EXT] [bug report] octeontx2-af: Drop rules for NPC MCAM
Date: Thu, 14 Jul 2022 12:55:22 +0300 [thread overview]
Message-ID: <20220714095522.GU2338@kadam> (raw)
In-Reply-To: <MWHPR1801MB19186110DDA1663479B6E6AED3889@MWHPR1801MB1918.namprd18.prod.outlook.com>
On Thu, Jul 14, 2022 at 03:25:02AM +0000, Ratheesh Kannoth wrote:
> Dan,
> Thanks !!
>
> I tried to run smatch tool and could not see any of these errors ? Am I missing any step ?
> ===
> ./smatch-master/smatch_scripts/kchecker drivers/net/ethernet/marvell/octeontx2/
>
> CHECK drivers/net/ethernet/marvell/octeontx2/af/rvu_sdp.c
> CC drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.o
> CHECK drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> AR drivers/net/ethernet/marvell/octeontx2/af/built-in.a
> CHECK drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> CHECK drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
Hm... To see those warnings then you need the cross function DB enabled.
It takes forever (over night) to build.
./smatch-master/smatch_scripts/build_kernel_data.sh
>
> >drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:735 otx2_mbox_alloc_msg_npc_get_secret_key() warn: struct type mismatch 'mbox_msghdr vs npc_get_secret_key_req'
> I don't see any issue in the code.
>
Sorry, this is unpublished Smatch code which was buggy. I have fixed
it now.
regards,
dan carpenter
prev parent reply other threads:[~2022-07-14 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 11:32 [bug report] octeontx2-af: Drop rules for NPC MCAM Dan Carpenter
2022-07-14 3:25 ` [EXT] " Ratheesh Kannoth
2022-07-14 9:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714095522.GU2338@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.