From: David Sterba <dsterba@suse.cz>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Filipe Manana <fdmanana@kernel.org>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] btrfs: Replace kmap() with kmap_local_page() in zstd.c
Date: Thu, 14 Jul 2022 14:33:17 +0200 [thread overview]
Message-ID: <20220714123317.GI15169@suse.cz> (raw)
In-Reply-To: <20220714082519.A7C9.409509F4@e16-tech.com>
On Thu, Jul 14, 2022 at 08:25:20AM +0800, Wang Yugui wrote:
> Hi,
>
> Compiler warning:
>
> fs/btrfs/zstd.c:478:55: warning: passing argument 1 of ‘__kunmap_local’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> 478 | kunmap_local(workspace->in_buf.src);
> ./include/linux/highmem-internal.h:284:24: note: in definition of macro ‘kunmap_local’
> 284 | __kunmap_local(__addr); \
> | ^~~~~~
> ./include/linux/highmem-internal.h:200:41: note: expected ‘void *’ but argument is of type ‘const void *’
> 200 | static inline void __kunmap_local(void *addr)
> | ~~~~~~^~~~
This requires patch
https://lore.kernel.org/all/20220706111520.12858-2-fmdefrancesco@gmail.com/
that adds const to kmap/kunmap API.
prev parent reply other threads:[~2022-07-14 12:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 13:52 [PATCH] btrfs: Replace kmap() with kmap_local_page() in zstd.c Fabio M. De Francesco
2022-06-13 18:39 ` David Sterba
2022-06-13 23:22 ` Fabio M. De Francesco
2022-06-13 23:42 ` Fabio M. De Francesco
2022-06-14 14:25 ` David Sterba
2022-06-14 16:28 ` Fabio M. De Francesco
2022-06-14 17:07 ` Ira Weiny
2022-06-15 5:29 ` Fabio M. De Francesco
2022-06-15 13:27 ` David Sterba
2022-06-15 13:32 ` David Sterba
2022-07-14 0:25 ` Wang Yugui
2022-07-14 7:46 ` Fabio M. De Francesco
2022-07-14 12:33 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714123317.GI15169@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=terrelln@fb.com \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.