From: Avinesh Kumar <akumar@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] open06.c: convert to new LTP API
Date: Thu, 14 Jul 2022 18:16:11 +0530 [thread overview]
Message-ID: <20220714124611.9772-1-akumar@suse.de> (raw)
Signed-off-by: Avinesh Kumar <akumar@suse.de>
---
testcases/kernel/syscalls/open/open06.c | 94 +++++--------------------
1 file changed, 19 insertions(+), 75 deletions(-)
diff --git a/testcases/kernel/syscalls/open/open06.c b/testcases/kernel/syscalls/open/open06.c
index 6c774ce84..a3c3bcb89 100644
--- a/testcases/kernel/syscalls/open/open06.c
+++ b/testcases/kernel/syscalls/open/open06.c
@@ -1,90 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
/*
- *
* Copyright (c) International Business Machines Corp., 2001
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
- * the GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ * Copyright (c) 2022 SUSE LLC Avinesh Kumar <avinesh.kumar@suse.com>
*/
-/*
- * DESCRIPTION
- * Testcase to check open(2) sets errno to ENXIO correctly.
+/*\
+ * [Description]
*
- * ALGORITHM
- * Create a named pipe using mknod(2). Attempt to
- * open(2) the pipe for writing. The open(2) should
- * fail with ENXIO.
+ * Verify that open(2) fails with ENXIO when
+ * O_NONBLOCK | O_WRONLY is set, the named file is a FIFO,
+ * and no process has the FIFO open for reading.
*/
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <errno.h>
-#include <unistd.h>
-#include "test.h"
-
-char *TCID = "open06";
-int TST_TOTAL = 1;
-
-static void setup(void);
-static void cleanup(void);
-
-static char fname[100] = "fifo";
-
-int main(int ac, char **av)
-{
- int lc;
- tst_parse_opts(ac, av, NULL, NULL);
+#include "tst_test.h"
- setup();
-
- for (lc = 0; TEST_LOOPING(lc); lc++) {
- tst_count = 0;
-
- TEST(open(fname, O_NONBLOCK | O_WRONLY));
- if (TEST_RETURN != -1) {
- tst_resm(TFAIL, "open(2) succeeded unexpectedly");
- continue;
- }
-
- if (TEST_ERRNO != ENXIO)
- tst_resm(TFAIL, "Expected ENXIO got %d", TEST_ERRNO);
- else
- tst_resm(TPASS, "call returned expected ENXIO error");
- }
-
- cleanup();
- tst_exit();
-}
+#define TEMP_FIFO "tmpfile"
static void setup(void)
{
- tst_sig(NOFORK, DEF_HANDLER, cleanup);
-
- TEST_PAUSE;
-
- tst_tmpdir();
-
- sprintf(fname, "%s.%d", fname, getpid());
-
- if (mknod(fname, S_IFIFO | 0644, 0) == -1)
- tst_brkm(TBROK, cleanup, "mknod FAILED");
+ SAFE_MKFIFO(TEMP_FIFO, 0644);
}
-static void cleanup(void)
+static void run(void)
{
- unlink(fname);
-
- tst_rmdir();
+ TST_EXP_FAIL2(open(TEMP_FIFO, O_NONBLOCK | O_WRONLY), ENXIO);
}
+
+static struct tst_test test = {
+ .test_all = run,
+ .setup = setup,
+ .needs_tmpdir = 1
+};
--
2.36.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2022-07-14 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:46 Avinesh Kumar [this message]
2022-07-14 13:18 ` [LTP] [PATCH v2] open06.c: convert to new LTP API Petr Vorel
2022-07-27 7:28 ` Avinesh Kumar
2022-08-11 8:49 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714124611.9772-1-akumar@suse.de \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.