From: Jakub Kicinski <kuba@kernel.org>
To: Ben Dooks <ben.dooks@sifive.com>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudip.mukherjee@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: macb: fixup sparse warnings on __be16 ports
Date: Thu, 14 Jul 2022 16:43:36 -0700 [thread overview]
Message-ID: <20220714164336.0f2768a2@kernel.org> (raw)
In-Reply-To: <20220714084305.209425-1-ben.dooks@sifive.com>
On Thu, 14 Jul 2022 09:43:05 +0100 Ben Dooks wrote:
> - htons(fs->h_u.tcp_ip4_spec.psrc), htons(fs->h_u.tcp_ip4_spec.pdst));
> + be16_to_cpu(fs->h_u.tcp_ip4_spec.psrc),
> + be16_to_cpu(fs->h_u.tcp_ip4_spec.pdst));
There are some spaces on this line, please use tabs,
checkpatch will be able to help you validate.
next prev parent reply other threads:[~2022-07-14 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:43 [PATCH] net: macb: fixup sparse warnings on __be16 ports Ben Dooks
2022-07-14 23:43 ` Jakub Kicinski [this message]
2022-07-15 17:33 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714164336.0f2768a2@kernel.org \
--to=kuba@kernel.org \
--cc=ben.dooks@sifive.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jude.onyenegecha@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=sudip.mukherjee@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.