All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: Jianglei Nie <niejianglei2021@163.com>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()
Date: Thu, 14 Jul 2022 17:43:17 +0000	[thread overview]
Message-ID: <20220714174317.49994-1-sj@kernel.org> (raw)
In-Reply-To: <20220714164427.157184-1-sj@kernel.org>

Hello Jianglei,

On Thu, 14 Jul 2022 16:44:27 +0000 SeongJae Park <sj@kernel.org> wrote:

> Hello Jianglei,
> 
> On Thu, 14 Jul 2022 14:37:46 +0800 Jianglei Nie <niejianglei2021@163.com> wrote:
> 
> > damon_reclaim_init() allocates a memory chunk for ctx with
> > damon_new_ctx(). When damon_select_ops() fails, ctx is not released, which
> > will lead to a memory leak.

I realized this issue is also in DAMON_LRU_SORT, so posted a patch:
https://lore.kernel.org/damon/20220714170458.49727-1-sj@kernel.org/

I mistakenly forgot CC-ing you, so letting you know here.


Thanks,
SJ

  reply	other threads:[~2022-07-14 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  6:37 [PATCH] mm/damon/reclaim: fix potential memory leak in damon_reclaim_init() Jianglei Nie
2022-07-14 16:44 ` SeongJae Park
2022-07-14 17:43   ` SeongJae Park [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-24  6:52 Jianglei Nie
2022-07-24  7:18 ` Greg KH
2022-07-24 10:15   ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714174317.49994-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=niejianglei2021@163.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.