From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B18C43334 for ; Thu, 14 Jul 2022 23:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232815AbiGNXPZ (ORCPT ); Thu, 14 Jul 2022 19:15:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiGNXPY (ORCPT ); Thu, 14 Jul 2022 19:15:24 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5833970E49 for ; Thu, 14 Jul 2022 16:15:22 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id AB6FA62C65C; Fri, 15 Jul 2022 09:15:20 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1oC83C-000yCP-4W; Fri, 15 Jul 2022 09:15:18 +1000 Date: Fri, 15 Jul 2022 09:15:18 +1000 From: Dave Chinner To: Linus Torvalds Cc: ansgar.loesser@kom.tu-darmstadt.de, "Darrick J. Wong" , Josef Bacik , Christoph Hellwig , Amir Goldstein , Mark Fasheh , Matthew Wilcox , Miklos Szeredi , Al Viro , linux-fsdevel , Security Officers , Max Schlecht , =?iso-8859-1?Q?Bj=F6rn?= Scheuermann Subject: Re: [PATCH] vf/remap: return the amount of bytes actually deduplicated Message-ID: <20220714231518.GI3600936@dread.disaster.area> References: <20220713064631.GC3600936@dread.disaster.area> <20220713074915.GD3600936@dread.disaster.area> <5548ef63-62f9-4f46-5793-03165ceccacc@tu-darmstadt.de> <20220714223238.GH3600936@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=OJNEYQWB c=1 sm=1 tr=0 ts=62d0a389 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=RgO8CyIxsXoA:10 a=7-415B0cAAAA:8 a=gYgG_CQIOByMtlcn9XEA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jul 14, 2022 at 03:42:13PM -0700, Linus Torvalds wrote: > On Thu, Jul 14, 2022 at 3:32 PM Dave Chinner wrote: > > > > Linus, can you please revert this commit for the 5.19 series (before > > the stable autosel bot sends it back to stable kernels, please!) to > > give us more time to investigate and consider the impact of the the > > API change on userspace applications before we commit to changing > > the API. > > Done. Thanks! > That said, even from the fastest output, I have to say that the new > behavior looks like the right one, and the old one just returned a > fantasy that didn't actually match what the dedupe operation actually > *did*. Very true, and I'm definitely not arguing that the change is wrong. We just need a bit of time to look at the various major dedupe apps and check that they still do the right thing w.r.t. proposed change. This late in the cycle I want to make sure we don't end up screwing things up and creating unnecessary urgent work for anyone in the near future... > But leaving this for later is not a problem. *nod* Cheers, Dave. -- Dave Chinner david@fromorbit.com