From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: r8188eu: remove unused parameter from update_TSF()
Date: Fri, 15 Jul 2022 12:49:02 +0300 [thread overview]
Message-ID: <20220715094902.GZ2338@kadam> (raw)
In-Reply-To: <20220715062908.8547-4-straube.linux@gmail.com>
On Fri, Jul 15, 2022 at 08:29:06AM +0200, Michael Straube wrote:
> The parameter 'len' of update_TSF() is unused. Remove it.
>
I really do think this driver should do a lot of more checking on len.
It's not totally clear to me if this len can even be trusted though...
regards,
dan carpenter
next prev parent reply other threads:[~2022-07-15 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 6:29 [PATCH 0/5] staging: r8188eu: remove SetHwReg8188EU() Michael Straube
2022-07-15 6:29 ` [PATCH 1/5] staging: r8188eu: remove HW_VAR_SET_OPMODE from SetHwReg8188EU() Michael Straube
2022-07-15 6:29 ` [PATCH 2/5] staging: r8188eu: remove unused parameter from correct_TSF() Michael Straube
2022-07-15 6:29 ` [PATCH 3/5] staging: r8188eu: remove unused parameter from update_TSF() Michael Straube
2022-07-15 9:49 ` Dan Carpenter [this message]
2022-07-15 6:29 ` [PATCH 4/5] staging: r8188eu: make update_TSF() and correct_TSF() static Michael Straube
2022-07-15 6:29 ` [PATCH 5/5] staging: r8188eu: remove SetHwReg8188EU() Michael Straube
2022-07-15 20:16 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715094902.GZ2338@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.