From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jonathan Toppins <jtoppins@redhat.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Brian Hutchinson <b.hutchman@gmail.com>
Subject: Re: [PATCH net] net: dsa: fix bonding with ARP monitoring by updating trans_start manually
Date: Fri, 15 Jul 2022 17:55:16 -0700 [thread overview]
Message-ID: <20220715175516.6770c863@kernel.org> (raw)
In-Reply-To: <20220716002612.rd6ir65njzc2g3cc@skbuf>
On Sat, 16 Jul 2022 00:26:13 +0000 Vladimir Oltean wrote:
> > Make bonding not depend on a field which is only valid for HW devices
> > which use the Tx watchdog. Let me find the thread...
> > https://lore.kernel.org/all/20220621213823.51c51326@kernel.org/
>
> That won't work in the general case with dsa_slave_get_stats64(), which
> may take the stats from hardware (delayed) or from dev_get_tstats64().
Ah, that's annoying.
> Also, not to mention that ARP monitoring used to work before the commit
> I blamed, this is a punctual fix for a regression.
trans_start is for the watchdog. This is the third patch pointlessly
messing with trans_start while the bug is in bonding. It's trying to
piggy back on semantics which are not universally true.
Fix bonding please.
next prev parent reply other threads:[~2022-07-16 0:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 23:26 [PATCH net] net: dsa: fix bonding with ARP monitoring by updating trans_start manually Vladimir Oltean
2022-07-15 23:52 ` Florian Fainelli
2022-07-16 0:00 ` Jakub Kicinski
2022-07-16 0:14 ` Vladimir Oltean
2022-07-16 0:19 ` Jakub Kicinski
2022-07-16 0:26 ` Vladimir Oltean
2022-07-16 0:55 ` Jakub Kicinski [this message]
2022-07-16 13:30 ` Vladimir Oltean
2022-07-16 23:33 ` Jakub Kicinski
2022-07-25 20:31 ` Vladimir Oltean
2022-07-25 20:40 ` Jakub Kicinski
2022-07-25 21:39 ` Jonathan Toppins
2022-07-25 21:53 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715175516.6770c863@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=b.hutchman@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vfalico@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.