All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openssl: fix libressl dependency
Date: Sun, 17 Jul 2022 00:04:26 +0200	[thread overview]
Message-ID: <20220716220426.GN2543@scaer> (raw)
In-Reply-To: <20220716134714.611106-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-07-16 15:47 +0200, Fabrice Fontaine spake thusly:
> libressl can be built with uclibc on noMMU since bump to version 3.0.2
> in commit 26f42106e8acfd336d8e902da96cd2ac9e63c09d and
> https://github.com/libressl-portable/openbsd/commit/f542e84c859e3fb2728075c702062cce8a0ea93f
> 
> However, uclibc-ng doesn't provide __register_atfork without NPTL
> resulting in the following libressl build failure:
> 
> /nvmedata/autobuild/instance-28/output-1/host/lib/gcc/arceb-buildroot-linux-uclibc/10.3.0/../../../../arceb-buildroot-linux-uclibc/bin/ld: ../../tls/libtls.a(arc4random.c.o): in function `_rs_stir':
> arc4random.c:(.text+0x50c): undefined reference to `__register_atfork'
> 
> So fix the dependency and, while at it, drop the double negation for
> readability
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/2fa4fa10cf19f1f942b6b49b5f6f05339c008cd4
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/openssl/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/openssl/Config.in b/package/openssl/Config.in
> index 7bf49b05f6..c7641ecefa 100644
> --- a/package/openssl/Config.in
> +++ b/package/openssl/Config.in
> @@ -34,8 +34,8 @@ config BR2_PACKAGE_LIBRESSL
>  	bool "libressl"
>  	depends on !BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> -	# uClibc on noMMU doesn't provide __register_atfork()
> -	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
> +	# uClibc doesn't provide __register_atfork() without NPTL
> +	depends on !BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	help
>  	  LibreSSL is a version of the TLS/crypto stack forked from
>  	  OpenSSL in 2014, with goals of modernizing the codebase,
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-16 22:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-16 13:47 [Buildroot] [PATCH 1/1] package/openssl: fix libressl dependency Fabrice Fontaine
2022-07-16 22:04 ` Yann E. MORIN [this message]
2022-08-04 15:01 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220716220426.GN2543@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.