From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Kris Bahnsen <kris@embeddedTS.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Mark Featherston <mark@embeddedTS.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax
Date: Sun, 17 Jul 2022 00:08:00 +0200 [thread overview]
Message-ID: <20220716220800.GP2543@scaer> (raw)
In-Reply-To: <20220715211041.7902-1-kris@embeddedTS.com>
Kris, All,
On 2022-07-15 14:10 -0700, Kris Bahnsen via buildroot spake thusly:
> Sub-options SPI and SDIO weren't rendering as nested options for
> wilc-driver, instead showing on the same indent level. Move the
> comment and depends on to bottom of file to correct this.
>
> Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/wilc-driver/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
> index 24a7b05b17..7ed062bb66 100644
> --- a/package/wilc-driver/Config.in
> +++ b/package/wilc-driver/Config.in
> @@ -17,9 +17,6 @@ config BR2_PACKAGE_WILC_DRIVER
>
> https://github.com/embeddedTS/wilc3000-external-module
>
> -comment "wilc kernel module needs a Linux kernel to be built"
> - depends on !BR2_LINUX_KERNEL
> -
> if BR2_PACKAGE_WILC_DRIVER
>
> config BR2_PACKAGE_WILC_DRIVER_SPI
> @@ -60,3 +57,6 @@ config BR2_PACKAGE_WILC_DRIVER_SDIO_OOB
> time division interrupt.
> endif
> endif
> +
> +comment "wilc kernel module needs a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-16 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 21:10 [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax Kris Bahnsen via buildroot
2022-07-16 22:08 ` Yann E. MORIN [this message]
2022-08-04 15:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220716220800.GP2543@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=kris@embeddedTS.com \
--cc=mark@embeddedTS.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.