From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67A48C433EF for ; Sun, 17 Jul 2022 08:36:34 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1oCzlP-0000rq-Cb; Sun, 17 Jul 2022 08:36:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oCzlO-0000rk-6B for linux-f2fs-devel@lists.sourceforge.net; Sun, 17 Jul 2022 08:36:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KPdpIj6+zuOLFfGVczdnmA1kYYpvkGTEpBqmCCkcOr0=; b=LZny27Wtsgv9AljgABhqdT1daY w4px3dgKSveM6z1C2JZHXCQRsxJa3bHY1e5T7soCgVnMpBDGH9wX/BV5YhUJT8MLE14xS6r2D58Fz asi+Myaru1iXbRvueyrdvIadgIz68oye/wq/0459pAo9Gtu4yAkkBc4BbnAtnJcDqiiI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=KPdpIj6+zuOLFfGVczdnmA1kYYpvkGTEpBqmCCkcOr0=; b=P YYUTmeYara5i6LcYXW4xJwZ4JYHhPVGEIrY+mZLfi4j5XF5ZOPLWL+jgXLiasgQNZXmWCZNY1pXgO PG1Awh4Ztg5SGv7cB+GTCVrkK17KJlL93tpINR7fV2RBW8WDqGUh/4dZ+9jwVRJkKu2mcnO7KbSJR TA9EiHmCTycrw2gI=; Received: from mail-wm1-f51.google.com ([209.85.128.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1oCzlK-0006qB-G5 for linux-f2fs-devel@lists.sourceforge.net; Sun, 17 Jul 2022 08:36:28 +0000 Received: by mail-wm1-f51.google.com with SMTP id ay11-20020a05600c1e0b00b003a3013da120so5827362wmb.5 for ; Sun, 17 Jul 2022 01:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KPdpIj6+zuOLFfGVczdnmA1kYYpvkGTEpBqmCCkcOr0=; b=ho0FfW0pzlLfTloSwm6NgaWVW4pOv3rtpTRxR10iGG3jkA9gzty0hmbnjYYKm4MVu1 6KL5aXu14gFYJo419YFIBHhoNhaKn7cCtWnm6VIi8mpaFVy2w6gP+OpHpUZMxTKYMssv Bw5QNXHf9h65o+bnmZ/A7EcOzv2z/jeoczzZswXfyLQqtf5dzkcJRoSmLx7eUDB8tK0m F6NYIoJQb+rH8WRfEoq7DEYRGHZTraUcf9Wh3VuffqtuRC/CGSPU/ivWkpxj1N6e2wr2 lkcB0CHehDxga/HVL1qJG2aUZnOohW420anJm1Nsy3GD5F5CBjg9MJ0c7Si3y8loiPgp bdkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KPdpIj6+zuOLFfGVczdnmA1kYYpvkGTEpBqmCCkcOr0=; b=H0Mu69crzvVIgVRj3rEICz8fXAsst9+LuivhtG3OWcuo4Lpg/NbJhEudhL7TTPkW/G 1CQV7TQLv0tlfdTakeVub7cIurn8/jWLkyf76Y5TVCY4E8Clhfz5ZRSBuNcs+2Rxex+g fXgfaV7m+Yu0xPoTS65s2c2C9zHWIex1kXIZzq8zMolWPwf3G7X0GNK46Gt+A6fnvwxr NVZu5yeRsMecGkOv+3D+3ijFHiRH6RF4Y0kZOEwks9jaKQR1kCXC7ynDyU+yZ9MwLuNx PrFwKoDLMZdPYbPkAb3HA6PUTcm8sw8HZTFYy/p6qDYxKPg4HSnkVDegb1VW5+G3pOqJ x3Jw== X-Gm-Message-State: AJIora8rmIiW/dukPK/l2XbSrNd4gWmbJnI1Gw6dmO3PccELhCVPy91S IBlEwpSye4thiV3K3uGehaA= X-Google-Smtp-Source: AGRyM1sqobUZzrErJtyW6GoiEJMsugB4ZhdeqcqwoPOaR3IhOIV61PAuC34TD9zvVdZFbfTK/NPJdg== X-Received: by 2002:a05:600c:3399:b0:3a3:f1e:ebd8 with SMTP id o25-20020a05600c339900b003a30f1eebd8mr9493905wmp.6.1658046979942; Sun, 17 Jul 2022 01:36:19 -0700 (PDT) Received: from localhost.localdomain (host-95-235-102-55.retail.telecomitalia.it. [95.235.102.55]) by smtp.gmail.com with ESMTPSA id r8-20020a5d52c8000000b0021d65e9d449sm8117515wrv.73.2022.07.17.01.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 01:36:18 -0700 (PDT) From: "Fabio M. De Francesco" To: Jaegeuk Kim , Chao Yu , Nick Terrell , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Sun, 17 Jul 2022 10:36:13 +0200 Message-Id: <20220717083613.3861-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Headers-End: 1oCzlK-0006qB-G5 Subject: [f2fs-dev] [PATCH] f2fs: Delete f2fs_copy_page() and replace with memcpy_page() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Hellwig , Ira Weiny , "Fabio M. De Francesco" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net ZjJmc19jb3B5X3BhZ2UoKSBpcyBhIHdyYXBwZXIgYXJvdW5kIHR3byBrbWFwKCkgKyBvbmUgbWVt Y3B5KCkgZnJvbS90bwp0aGUgbWFwcGVkIHBhZ2VzLiBJdCB1bm5lY2Vzc2FyaWx5IGR1cGxpY2F0 ZXMgYSBrZXJuZWwgQVBJIGFuZCBpdCBtYWtlcwp1c2Ugb2Yga21hcCgpLCB3aGljaCBpcyBiZWlu ZyBkZXByZWNhdGVkIGluIGZhdm9yIG9mIGttYXBfbG9jYWxfcGFnZSgpLgoKVHdvIG1haW4gcHJv YmxlbXMgd2l0aCBrbWFwKCk6ICgxKSBJdCBjb21lcyB3aXRoIGFuIG92ZXJoZWFkIGFzIG1hcHBp bmcKc3BhY2UgaXMgcmVzdHJpY3RlZCBhbmQgcHJvdGVjdGVkIGJ5IGEgZ2xvYmFsIGxvY2sgZm9y IHN5bmNocm9uaXphdGlvbiBhbmQKKDIpIGl0IGFsc28gcmVxdWlyZXMgZ2xvYmFsIFRMQiBpbnZh bGlkYXRpb24gd2hlbiB0aGUga21hcOKAmXMgcG9vbCB3cmFwcwphbmQgaXQgbWlnaHQgYmxvY2sg d2hlbiB0aGUgbWFwcGluZyBzcGFjZSBpcyBmdWxseSB1dGlsaXplZCB1bnRpbCBhIHNsb3QKYmVj b21lcyBhdmFpbGFibGUuCgpXaXRoIGttYXBfbG9jYWxfcGFnZSgpIHRoZSBtYXBwaW5ncyBhcmUg cGVyIHRocmVhZCwgQ1BVIGxvY2FsLCBjYW4gdGFrZQpwYWdlIGZhdWx0cywgYW5kIGNhbiBiZSBj YWxsZWQgZnJvbSBhbnkgY29udGV4dCAoaW5jbHVkaW5nIGludGVycnVwdHMpLgpJdCBpcyBmYXN0 ZXIgdGhhbiBrbWFwKCkgaW4ga2VybmVscyB3aXRoIEhJR0hNRU0gZW5hYmxlZC4gVGhlcmVmb3Jl LCBpdHMKdXNlIGluIF9fY2xvbmVfYmxrYWRkcnMoKSBpcyBzYWZlIGFuZCBzaG91bGQgYmUgcHJl ZmVycmVkLgoKRGVsZXRlIGYyZnNfY29weV9wYWdlKCkgYW5kIHVzZSBhIHBsYWluIG1lbWNweV9w YWdlKCkgaW4gdGhlIG9ubHkgb25lCnNpdGUgY2FsbGluZyB0aGUgcmVtb3ZlZCBmdW5jdGlvbi4g bWVtY3B5X3BhZ2UoKSBhdm9pZHMgb3BlbiBjb2RpbmcgdHdvCmttYXBfbG9jYWxfcGFnZSgpICsg b25lIG1lbWNweSgpIGJldHdlZW4gdGhlIHR3byBrZXJuZWwgdmlydHVhbCBhZGRyZXNzZXMuCgpT dWdnZXN0ZWQtYnk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAaW5mcmFkZWFkLm9yZz4KU3VnZ2Vz dGVkLWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+ClNpZ25lZC1vZmYtYnk6IEZh YmlvIE0uIERlIEZyYW5jZXNjbyA8Zm1kZWZyYW5jZXNjb0BnbWFpbC5jb20+Ci0tLQoKVGhpcyBw YXRjaCBleHRlbmRzIHRoZSBzY29wZSBhbmQgcmVwbGFjZXMgImYyZnM6IFVzZSBtZW1jcHlfcGFn ZSgpIGluCmYyZnNfY29weV9wYWdlKCkiLCBhcyBzdWdnZXN0ZWQgYnkgQ2hyaXN0b3BoIEhlbGx3 aWcgKHRoYW5rcyEpOgpodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sL1l0T3lXT0tGTjlyYW1V eWJAaW5mcmFkZWFkLm9yZy8KCiBmcy9mMmZzL2YyZnMuaCB8IDEwIC0tLS0tLS0tLS0KIGZzL2Yy ZnMvZmlsZS5jIHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDExIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2ZzL2YyZnMvZjJmcy5oIGIvZnMvZjJmcy9mMmZzLmgK aW5kZXggZDliYmVjZDAwOGQyLi41MmJlM2UyM2FlN2MgMTAwNjQ0Ci0tLSBhL2ZzL2YyZnMvZjJm cy5oCisrKyBiL2ZzL2YyZnMvZjJmcy5oCkBAIC0yNjk2LDE2ICsyNjk2LDYgQEAgc3RhdGljIGlu bGluZSBzdHJ1Y3QgcGFnZSAqZjJmc19wYWdlY2FjaGVfZ2V0X3BhZ2UoCiAJcmV0dXJuIHBhZ2Vj YWNoZV9nZXRfcGFnZShtYXBwaW5nLCBpbmRleCwgZmdwX2ZsYWdzLCBnZnBfbWFzayk7CiB9CiAK LXN0YXRpYyBpbmxpbmUgdm9pZCBmMmZzX2NvcHlfcGFnZShzdHJ1Y3QgcGFnZSAqc3JjLCBzdHJ1 Y3QgcGFnZSAqZHN0KQotewotCWNoYXIgKnNyY19rYWRkciA9IGttYXAoc3JjKTsKLQljaGFyICpk c3Rfa2FkZHIgPSBrbWFwKGRzdCk7Ci0KLQltZW1jcHkoZHN0X2thZGRyLCBzcmNfa2FkZHIsIFBB R0VfU0laRSk7Ci0Ja3VubWFwKGRzdCk7Ci0Ja3VubWFwKHNyYyk7Ci19Ci0KIHN0YXRpYyBpbmxp bmUgdm9pZCBmMmZzX3B1dF9wYWdlKHN0cnVjdCBwYWdlICpwYWdlLCBpbnQgdW5sb2NrKQogewog CWlmICghcGFnZSkKZGlmZiAtLWdpdCBhL2ZzL2YyZnMvZmlsZS5jIGIvZnMvZjJmcy9maWxlLmMK aW5kZXggYmQxNGNlZjFiMDhmLi44ZDk4NGFlYjI3MGYgMTAwNjQ0Ci0tLSBhL2ZzL2YyZnMvZmls ZS5jCisrKyBiL2ZzL2YyZnMvZmlsZS5jCkBAIC0xMjc4LDcgKzEyNzgsNyBAQCBzdGF0aWMgaW50 IF9fY2xvbmVfYmxrYWRkcnMoc3RydWN0IGlub2RlICpzcmNfaW5vZGUsIHN0cnVjdCBpbm9kZSAq ZHN0X2lub2RlLAogCQkJCWYyZnNfcHV0X3BhZ2UocHNyYywgMSk7CiAJCQkJcmV0dXJuIFBUUl9F UlIocGRzdCk7CiAJCQl9Ci0JCQlmMmZzX2NvcHlfcGFnZShwc3JjLCBwZHN0KTsKKwkJCW1lbWNw eV9wYWdlKHBkc3QsIDAsIHBzcmMsIDAsIFBBR0VfU0laRSk7CiAJCQlzZXRfcGFnZV9kaXJ0eShw ZHN0KTsKIAkJCWYyZnNfcHV0X3BhZ2UocGRzdCwgMSk7CiAJCQlmMmZzX3B1dF9wYWdlKHBzcmMs IDEpOwotLSAKMi4zNy4xCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxA bGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3Rz L2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A877C43334 for ; Sun, 17 Jul 2022 08:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232300AbiGQIgZ (ORCPT ); Sun, 17 Jul 2022 04:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbiGQIgY (ORCPT ); Sun, 17 Jul 2022 04:36:24 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 908B617599 for ; Sun, 17 Jul 2022 01:36:21 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id r83-20020a1c4456000000b003a2fa488efdso724617wma.4 for ; Sun, 17 Jul 2022 01:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KPdpIj6+zuOLFfGVczdnmA1kYYpvkGTEpBqmCCkcOr0=; b=ho0FfW0pzlLfTloSwm6NgaWVW4pOv3rtpTRxR10iGG3jkA9gzty0hmbnjYYKm4MVu1 6KL5aXu14gFYJo419YFIBHhoNhaKn7cCtWnm6VIi8mpaFVy2w6gP+OpHpUZMxTKYMssv Bw5QNXHf9h65o+bnmZ/A7EcOzv2z/jeoczzZswXfyLQqtf5dzkcJRoSmLx7eUDB8tK0m F6NYIoJQb+rH8WRfEoq7DEYRGHZTraUcf9Wh3VuffqtuRC/CGSPU/ivWkpxj1N6e2wr2 lkcB0CHehDxga/HVL1qJG2aUZnOohW420anJm1Nsy3GD5F5CBjg9MJ0c7Si3y8loiPgp bdkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KPdpIj6+zuOLFfGVczdnmA1kYYpvkGTEpBqmCCkcOr0=; b=qU+PLbF+q75awJZjnKTEyk7IGZmuiTmv55appMaPSeWGBuBF3VLcNePD2VAMWgFM5E V1EompCxxuHwAwaE5s4IUlRrrqFSnywObZyRh0yfa6168dKQbkWLWQGtJOgSwZpflAsN bQKUHFn6dS924BkBC28XdbCtxuaqpM9EUfWzUDHRby0Idyjrn9cpOryhZYYEF2FRkMsy SmYPw9aB14jlh7tvF0j+66IHnp/2LUzUwTnoL1JKCKiD6x8wiLtMZnIBoTzApsO36Czv kLv+KLICpfk7wCcYzfV3gIDHxalyGSC+He6jypWBik5ZVngUf6NEl6/QdzZe1Cpiv8Vm ICHA== X-Gm-Message-State: AJIora89DdD8A75P6S46GiZ0RZqWeOd3FcIaLYCnrsiJfq40nwsmYjiM TG6BjZDUNPtEL04z1NtFhJV7XpFwmls= X-Google-Smtp-Source: AGRyM1sqobUZzrErJtyW6GoiEJMsugB4ZhdeqcqwoPOaR3IhOIV61PAuC34TD9zvVdZFbfTK/NPJdg== X-Received: by 2002:a05:600c:3399:b0:3a3:f1e:ebd8 with SMTP id o25-20020a05600c339900b003a30f1eebd8mr9493905wmp.6.1658046979942; Sun, 17 Jul 2022 01:36:19 -0700 (PDT) Received: from localhost.localdomain (host-95-235-102-55.retail.telecomitalia.it. [95.235.102.55]) by smtp.gmail.com with ESMTPSA id r8-20020a5d52c8000000b0021d65e9d449sm8117515wrv.73.2022.07.17.01.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 01:36:18 -0700 (PDT) From: "Fabio M. De Francesco" To: Jaegeuk Kim , Chao Yu , Nick Terrell , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" , Christoph Hellwig , Ira Weiny Subject: [PATCH] f2fs: Delete f2fs_copy_page() and replace with memcpy_page() Date: Sun, 17 Jul 2022 10:36:13 +0200 Message-Id: <20220717083613.3861-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org f2fs_copy_page() is a wrapper around two kmap() + one memcpy() from/to the mapped pages. It unnecessarily duplicates a kernel API and it makes use of kmap(), which is being deprecated in favor of kmap_local_page(). Two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available. With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Therefore, its use in __clone_blkaddrs() is safe and should be preferred. Delete f2fs_copy_page() and use a plain memcpy_page() in the only one site calling the removed function. memcpy_page() avoids open coding two kmap_local_page() + one memcpy() between the two kernel virtual addresses. Suggested-by: Christoph Hellwig Suggested-by: Ira Weiny Signed-off-by: Fabio M. De Francesco --- This patch extends the scope and replaces "f2fs: Use memcpy_page() in f2fs_copy_page()", as suggested by Christoph Hellwig (thanks!): https://lore.kernel.org/lkml/YtOyWOKFN9ramUyb@infradead.org/ fs/f2fs/f2fs.h | 10 ---------- fs/f2fs/file.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index d9bbecd008d2..52be3e23ae7c 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2696,16 +2696,6 @@ static inline struct page *f2fs_pagecache_get_page( return pagecache_get_page(mapping, index, fgp_flags, gfp_mask); } -static inline void f2fs_copy_page(struct page *src, struct page *dst) -{ - char *src_kaddr = kmap(src); - char *dst_kaddr = kmap(dst); - - memcpy(dst_kaddr, src_kaddr, PAGE_SIZE); - kunmap(dst); - kunmap(src); -} - static inline void f2fs_put_page(struct page *page, int unlock) { if (!page) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index bd14cef1b08f..8d984aeb270f 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1278,7 +1278,7 @@ static int __clone_blkaddrs(struct inode *src_inode, struct inode *dst_inode, f2fs_put_page(psrc, 1); return PTR_ERR(pdst); } - f2fs_copy_page(psrc, pdst); + memcpy_page(pdst, 0, psrc, 0, PAGE_SIZE); set_page_dirty(pdst); f2fs_put_page(pdst, 1); f2fs_put_page(psrc, 1); -- 2.37.1